You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/07/25 00:16:05 UTC

[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #8144: Web-console: Add continue to spec view

vogievetsky commented on a change in pull request #8144: Web-console: Add continue to spec view
URL: https://github.com/apache/incubator-druid/pull/8144#discussion_r307071211
 
 

 ##########
 File path: web-console/src/views/load-data-view/load-data-view.tsx
 ##########
 @@ -408,11 +416,37 @@ export class LoadDataView extends React.PureComponent<LoadDataViewProps, LoadDat
   };
 
   render() {
-    const { step } = this.state;
+    const { step, continueToSpec } = this.state;
+    if (!continueToSpec) {
+      return (
+        <div className={classNames('load-data-continue-view')}>
 
 Review comment:
   everything returned in the `load-data-view` should have that class on it, you should set the class to `load-data-view continue-view` and then in the scss do:
   
   ```scss
   .load-data-view {
     &.continue-view {
       ...
     }
   }
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org