You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "arturobernalg (via GitHub)" <gi...@apache.org> on 2023/09/16 20:41:40 UTC
[GitHub] [httpcomponents-core] arturobernalg opened a new pull request, #430: HTTPCORE-756 - Implement 'If-Range' request validation as per RFC 9110
arturobernalg opened a new pull request, #430:
URL: https://github.com/apache/httpcomponents-core/pull/430
- Ensure the presence of 'Range' header when 'If-Range' is specified.
- Enforce strong validator requirements when 'If-Range' is paired with a Date.
- Exit processing early if 'Last-Modified' header is missing, ensuring strong validation adherence.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] arturobernalg closed pull request #430: HTTPCORE-756 - Implement 'If-Range' request validation as per RFC 9110
Posted by "arturobernalg (via GitHub)" <gi...@apache.org>.
arturobernalg closed pull request #430: HTTPCORE-756 - Implement 'If-Range' request validation as per RFC 9110
URL: https://github.com/apache/httpcomponents-core/pull/430
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] arturobernalg commented on pull request #430: HTTPCORE-756 - Implement 'If-Range' request validation as per RFC 9110
Posted by "arturobernalg (via GitHub)" <gi...@apache.org>.
arturobernalg commented on PR #430:
URL: https://github.com/apache/httpcomponents-core/pull/430#issuecomment-1726330738
> * This change-set is definitely useful, but it kind of goes counter to the overall philosophy of the library. Generally we provide higher level APIs for consumers to use and generate low level HTTP protocol headers based on request details or execution context. Consider our statement management and authentication in client and content transport in core. However if the library consumers manually populate protocol headers we allow them to pass any rubbish they please (with a few notable exceptions) .
>
> * We presently do not support content rangers at all. I am not sure we ought to mess with headers users populate manually
>
> * If still want to contribute this request interceptor, I suppose the client module should be a better home for it, not core
@ok2c, I appreciate your feedback. I'll investigate integrating this change-set into the client module while respecting the library's philosophy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] ok2c commented on pull request #430: HTTPCORE-756 - Implement 'If-Range' request validation as per RFC 9110
Posted by "ok2c (via GitHub)" <gi...@apache.org>.
ok2c commented on PR #430:
URL: https://github.com/apache/httpcomponents-core/pull/430#issuecomment-1722452313
@arturobernalg
1. This change-set is definitely useful, but it kind of goes counter to the overall philosophy of the library. Generally we provide higher level APIs for consumers to use and generate low level HTTP protocol headers based on request details or execution context. Consider our statement management and authentication in client and content transport in core. However if the library consumers manually populate protocol headers we allow them to pass any rubbish they please (with a few notable exceptions) .
2. We presently do not support content rangers at all. I am not sure we ought to mess with headers users populate manually
3. If still want to contribute this request interceptor, I suppose the client module should be a better home for it, not core.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org