You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "LuciferYang (via GitHub)" <gi...@apache.org> on 2026/06/23 06:31:39 UTC
[PR] [SPARK-57632][CORE] Remove unused method addVariantValueVariant in VariantShreddingWriter [spark]
LuciferYang opened a new pull request, #56695:
URL: https://github.com/apache/spark/pull/56695
### What changes were proposed in this pull request?
This PR removes `VariantShreddingWriter.addVariantValueVariant`, a `private static` method that has no callers. It is a one-line delegation to `ShreddedResult.addVariantValue`; the live shredding path already calls `result.addVariantValue(...)` directly.
### Why are the changes needed?
Dead code cleanup. The method has been unreferenced since it was first added in [SPARK-48898](https://issues.apache.org/jira/browse/SPARK-48898) (`Add Variant shredding functions`) - it never had a caller. Removing it keeps `VariantShreddingWriter` easier to read.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
No new tests are needed; this only removes unreachable code. Existing variant tests still pass.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-57632][SQL] Remove unused method addVariantValueVariant in VariantShreddingWriter [spark]
Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b closed pull request #56695: [SPARK-57632][SQL] Remove unused method addVariantValueVariant in VariantShreddingWriter
URL: https://github.com/apache/spark/pull/56695
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-57632][SQL] Remove unused method addVariantValueVariant in VariantShreddingWriter [spark]
Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b commented on PR #56695:
URL: https://github.com/apache/spark/pull/56695#issuecomment-4783534727
Thank you @LuciferYang and @dongjoon-hyun! Merging to master/4.x.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-57632][SQL] Remove unused method addVariantValueVariant in VariantShreddingWriter [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #56695:
URL: https://github.com/apache/spark/pull/56695#issuecomment-4786187829
Thanks @dongjoon-hyun and @uros-b
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org