You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "pmcarthur-apache (via GitHub)" <gi...@apache.org> on 2023/06/22 19:39:26 UTC
[GitHub] [solr] pmcarthur-apache opened a new pull request, #1718: SOLR-16848: fix race condition in DeleteReplicaTest
pmcarthur-apache opened a new pull request, #1718:
URL: https://github.com/apache/solr/pull/1718
https://issues.apache.org/jira/browse/SOLR-16848
<!--
_(If you are a project committer then you may remove some/all of the following template.)_
Before creating a pull request, please file an issue in the ASF Jira system for Solr:
* https://issues.apache.org/jira/projects/SOLR
For something minor (i.e. that wouldn't be worth putting in release notes), you can skip JIRA.
To create a Jira issue, you will need to create an account there first.
The title of the PR should reference the Jira issue number in the form:
* SOLR-####: <short description of problem or changes>
SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
# Description
`DeleteReplicaTest.raceConditionOnDeleteAndRegisterReplica` has a race condition in which test code that is injected to be executed before registering the core in ZK could make a call to a JettySolrRunner that is not yet fully initialized. This causes a NullPointerException when accessing the SolrDispatchFilter, and causes the test to fail intermittently.
# Solution
The injected test code waits for the JettySolrRunner to return true from it's `isRunning` method before using it.
# Tests
This is a test change. I have been able to reproduce this test failure consistently in a fork, allowing for this fix to be tested.
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `main` branch.
- [x] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] HoustonPutman commented on pull request #1718: SOLR-16848: fix race condition in DeleteReplicaTest
Posted by "HoustonPutman (via GitHub)" <gi...@apache.org>.
HoustonPutman commented on PR #1718:
URL: https://github.com/apache/solr/pull/1718#issuecomment-1611773365
Closed in lieu of https://github.com/apache/solr/pull/1727
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] HoustonPutman closed pull request #1718: SOLR-16848: fix race condition in DeleteReplicaTest
Posted by "HoustonPutman (via GitHub)" <gi...@apache.org>.
HoustonPutman closed pull request #1718: SOLR-16848: fix race condition in DeleteReplicaTest
URL: https://github.com/apache/solr/pull/1718
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dsmiley commented on pull request #1718: SOLR-16848: fix race condition in DeleteReplicaTest
Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley commented on PR #1718:
URL: https://github.com/apache/solr/pull/1718#issuecomment-1604628672
The precommit check failure is unrelated (Eric goof'ed usage of System.out and someone fixed it).
The test failure is:
```
gradlew :solr:core:test --tests "org.apache.solr.cli.TestSolrCLIRunExample.testInteractiveSolrCloudExample" -Ptests.jvms=96 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:+UseParallelGC -XX:ActiveProcessorCount=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=FE23B7243E1A03E6 -Ptests.file.encoding=ISO-8859-1
```
@epugh is that test failure familiar to you? When I think Solr CLI stuff lately, I think of you :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org