Re: [PR] fix(bloom): align builder parameters with java implementation (datasketches-rust)

["notfilippo (via GitHub)" <gi...@apache.org>]

notfilippo commented on PR #93:
URL: https://github.com/apache/datasketches-rust/pull/93#issuecomment-3901560401

   @tisonkun , I've broadened the PR a bit, first discovering that java does some word-clamping of the bits requested and then looking at some other params to match the limits.
   
   I think we are fairly aligned to the Java implementation now, as opposed to the C++ one which I was originally using as reference.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org