You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by jk...@apache.org on 2006/11/16 20:13:37 UTC
svn commit: r475880 -
/ant/core/trunk/src/tests/junit/org/apache/tools/ant/taskdefs/ManifestClassPathTest.java
Author: jkf
Date: Thu Nov 16 11:13:37 2006
New Revision: 475880
URL: http://svn.apache.org/viewvc?view=rev&rev=475880
Log:
Validated under windows only but jdk 1.3 doesn't support the international format classpaths in jar manifests.
(Test building the jars under jdk 1.3 and running them directly using java using jdk 1.5 works, but running
them using java form jkd 1.3 gives errors)
Modified:
ant/core/trunk/src/tests/junit/org/apache/tools/ant/taskdefs/ManifestClassPathTest.java
Modified: ant/core/trunk/src/tests/junit/org/apache/tools/ant/taskdefs/ManifestClassPathTest.java
URL: http://svn.apache.org/viewvc/ant/core/trunk/src/tests/junit/org/apache/tools/ant/taskdefs/ManifestClassPathTest.java?view=diff&rev=475880&r1=475879&r2=475880
==============================================================================
--- ant/core/trunk/src/tests/junit/org/apache/tools/ant/taskdefs/ManifestClassPathTest.java (original)
+++ ant/core/trunk/src/tests/junit/org/apache/tools/ant/taskdefs/ManifestClassPathTest.java Thu Nov 16 11:13:37 2006
@@ -133,10 +133,21 @@
"../../resources/dsp-void/");
}
public void testInternationalGerman() {
+ if (System.getProperty("java.vm.version").compareTo("1.4") < 0)
+ {
+ System.out.println("Test with international characters skipped under pre 1.4 jvm.");
+ return;
+ }
executeTarget("international-german");
expectLogContaining("run-two-jars", "beta alpha");
+
}
public void testInternationalHebrew() {
+ if (System.getProperty("java.vm.version").compareTo("1.4") < 0)
+ {
+ System.out.println("Test with international characters skipped under pre 1.4 jvm.");
+ return;
+ }
if (!Os.isFamily("windows")) {
executeTarget("international-hebrew");
expectLogContaining("run-two-jars", "beta alpha");
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: svn commit: r475880 - /ant/core/trunk/src/tests/junit/org/apache/tools/ant/taskdefs/ManifestClassPathTest.java
Posted by Stefan Bodewig <bo...@apache.org>.
On Thu, 16 Nov 2006, <jk...@apache.org> wrote:
> + if (System.getProperty("java.vm.version").compareTo("1.4") < 0)
should probably be something like
if (JavaEnvUtils.isJavaVersion(JavaEnvUtils.JAVA_1_2)
|| JavaEnvUtils.isJavaVersion(JavaEnvUtils.JAVA_1_3))
Stefan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org