You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@amoro.apache.org by "Aireed (via GitHub)" <gi...@apache.org> on 2026/07/02 02:44:56 UTC
[I] [Improvement]: use seperate threadpool with table.expireSnapshots() [amoro]
Aireed opened a new issue, #4264:
URL: https://github.com/apache/amoro/issues/4264
### Search before asking
- [x] I have searched in the [issues](https://github.com/apache/amoro/issues?q=is%3Aissue) and found no similar issues.
### What would you like to be improved?
issue:
some tables keep in committing status for long time
<img width="3796" height="3080" alt="Image" src="https://github.com/user-attachments/assets/811844ea-b7ed-4ca0-ad9a-70ea3e386b9f" />
i found async-optimizing-commit-executor is waiting for other future to be completed.
`
"async-optimizing-commit-executor-4" #207 prio=5 os_prio=0 tid=0x00007fec4c001000 nid=0x16cbfd sleeping[0x00007fec96cea000]
java.lang.Thread.State: TIMED_WAITING (sleeping)
at java.lang.Thread.sleep(Native Method)
at org.apache.iceberg.util.Tasks.waitFor(Tasks.java:522)
at org.apache.iceberg.util.Tasks.access$800(Tasks.java:42)
at org.apache.iceberg.util.Tasks$Builder.runParallel(Tasks.java:358)
at org.apache.iceberg.util.Tasks$Builder.run(Tasks.java:201)
at org.apache.iceberg.util.Tasks$Builder.run(Tasks.java:196)
at org.apache.iceberg.SnapshotProducer.writeManifests(SnapshotProducer.java:666)
at org.apache.iceberg.SnapshotProducer.writeDataManifests(SnapshotProducer.java:611)
at org.apache.iceberg.MergingSnapshotProducer.lambda$newDataFilesAsManifests$19(MergingSnapshotProducer.java:1058)
at org.apache.iceberg.MergingSnapshotProducer$$Lambda$1080/137728188.accept(Unknown Source)
at java.util.HashMap.forEach(HashMap.java:1289)
at org.apache.iceberg.MergingSnapshotProducer.newDataFilesAsManifests(MergingSnapshotProducer.java:1055)
at org.apache.iceberg.MergingSnapshotProducer.prepareNewDataManifests(MergingSnapshotProducer.java:1037)
at org.apache.iceberg.MergingSnapshotProducer.apply(MergingSnapshotProducer.java:940)
at org.apache.iceberg.SnapshotProducer.apply(SnapshotProducer.java:257)
at org.apache.iceberg.SnapshotProducer.lambda$commit$4(SnapshotProducer.java:434)
at org.apache.iceberg.SnapshotProducer$$Lambda$793/149360830.run(Unknown Source)
at org.apache.iceberg.util.Tasks$Builder.runTaskWithRetry(Tasks.java:413)
at org.apache.iceberg.util.Tasks$Builder.runSingleThreaded(Tasks.java:219)
at org.apache.iceberg.util.Tasks$Builder.run(Tasks.java:203)
at org.apache.iceberg.util.Tasks$Builder.run(Tasks.java:196)
at org.apache.iceberg.SnapshotProducer.commit(SnapshotProducer.java:432)
at org.apache.amoro.op.MixedUpdate.commit(MixedUpdate.java:143)
at org.apache.amoro.server.optimizing.UnKeyedTableCommit.rewriteFiles(UnKeyedTableCommit.java:283)
at org.apache.amoro.server.optimizing.UnKeyedTableCommit.commit(UnKeyedTableCommit.java:230)
at org.apache.amoro.server.optimizing.OptimizingQueue$TableOptimizingProcess.commit(OptimizingQueue.java:788)
at org.apache.amoro.server.table.executor.OptimizingCommitExecutor.execute(OptimizingCommitExecutor.java:53)
at org.apache.amoro.server.table.executor.BaseTableExecutor.executeTask(BaseTableExecutor.java:82)
at org.apache.amoro.server.table.executor.BaseTableExecutor.lambda$scheduleIfNecessary$2(BaseTableExecutor.java:93)
at org.apache.amoro.server.table.executor.BaseTableExecutor$$Lambda$665/1073662255.run(Unknown Source)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)
at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
Locked ownable synchronizers:
- <0x00000005c3a18998> (a java.util.concurrent.ThreadPoolExecutor$Worker)
- <0x00000006173222c8> (a java.util.concurrent.locks.ReentrantLock$NonfairSync)`
the futures is worked with iceberg-work-pool which is shared with expiresnapshots plan.
<img width="1724" height="886" alt="Image" src="https://github.com/user-attachments/assets/da511172-ae5a-4b93-ba8d-94ffc9b21580" />
<img width="1984" height="1726" alt="Image" src="https://github.com/user-attachments/assets/8018ee34-149b-469e-8197-deb8aa3ea0a1" />
<img width="1554" height="882" alt="Image" src="https://github.com/user-attachments/assets/05a7bb21-ee33-46c9-8291-9519eb3932fe" />
### How should we improve?
add planwith to set seperate thread pool, like IcebergThreadPools.getPlanningExecutor()
<img width="1856" height="1910" alt="Image" src="https://github.com/user-attachments/assets/7de1e814-a543-4a0e-8b67-483592ee227c" />
### Are you willing to submit PR?
- [x] Yes I am willing to submit a PR!
### Subtasks
_No response_
### Code of Conduct
- [x] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Improvement]: use seperate threadpool with table.expireSnapshots() [amoro]
Posted by "johntomcat7408-cmyk (via GitHub)" <gi...@apache.org>.
johntomcat7408-cmyk commented on issue #4264:
URL: https://github.com/apache/amoro/issues/4264#issuecomment-5224571431
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Improvement]: use seperate threadpool with table.expireSnapshots() [amoro]
Posted by "zhoujinsong (via GitHub)" <gi...@apache.org>.
zhoujinsong closed issue #4264: [Improvement]: use seperate threadpool with table.expireSnapshots()
URL: https://github.com/apache/amoro/issues/4264
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org