You are viewing a plain text version of this content. The canonical link for it is here.
Posted to devnull@infra.apache.org by "kristw (GitHub)" <gi...@apache.org> on 2018/08/27 22:30:36 UTC

[GitHub] [incubator-superset] kristw opened pull request #5746: [bugfix] BigNumber crash, Horizon indent and Myanmar geojson

- Fix `big_number_total` crashes because `formData.color_picker` is `undefined`.
- Fix invalid Myanmar geojson 
- Remove unintentional indent for horizon chart label for each row when in dashboard.

@williaster @graceguo-supercat @hughhhh 

[ Full content available at: https://github.com/apache/incubator-superset/pull/5746 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-superset] hughhhh commented on issue #5746: [bugfix] BigNumber crash, Horizon indent and Myanmar geojson

Posted by "hughhhh (GitHub)" <gi...@apache.org>.
Whoops thanks for the save @kristw , I'll merge with a green CI

[ Full content available at: https://github.com/apache/incubator-superset/pull/5746 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-superset] hughhhh commented on issue #5746: [bugfix] BigNumber crash, Horizon indent and Myanmar geojson

Posted by "hughhhh (GitHub)" <gi...@apache.org>.
Whoops thanks for the save @kristw 

[ Full content available at: https://github.com/apache/incubator-superset/pull/5746 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-superset] codecov-io commented on issue #5746: [bugfix] BigNumber crash, Horizon indent and Myanmar geojson

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5746?src=pr&el=h1) Report
> Merging [#5746](https://codecov.io/gh/apache/incubator-superset/pull/5746?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8d01c84c543a0905e55e9c4e4464249d1c382553?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `0%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/5746/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/5746?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master    #5746      +/-   ##
==========================================
- Coverage   63.45%   63.44%   -0.01%     
==========================================
  Files         362      362              
  Lines       22978    22980       +2     
  Branches     2554     2555       +1     
==========================================
  Hits        14580    14580              
- Misses       8383     8385       +2     
  Partials       15       15
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5746?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/assets/src/visualizations/BigNumber.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5746/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9CaWdOdW1iZXIuanN4) | `0% <0%> (ø)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5746?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5746?src=pr&el=footer). Last update [8d01c84...d7279a4](https://codecov.io/gh/apache/incubator-superset/pull/5746?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-superset/pull/5746 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-superset] codecov-io commented on issue #5746: [bugfix] BigNumber crash, Horizon indent and Myanmar geojson

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5746?src=pr&el=h1) Report
> Merging [#5746](https://codecov.io/gh/apache/incubator-superset/pull/5746?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8d01c84c543a0905e55e9c4e4464249d1c382553?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `0%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/5746/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/5746?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master    #5746      +/-   ##
==========================================
- Coverage   63.45%   63.44%   -0.01%     
==========================================
  Files         362      362              
  Lines       22978    22980       +2     
  Branches     2554     2555       +1     
==========================================
  Hits        14580    14580              
- Misses       8383     8385       +2     
  Partials       15       15
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5746?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/assets/src/visualizations/BigNumber.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5746/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9CaWdOdW1iZXIuanN4) | `0% <0%> (ø)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5746?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5746?src=pr&el=footer). Last update [8d01c84...d7279a4](https://codecov.io/gh/apache/incubator-superset/pull/5746?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-superset/pull/5746 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-superset] codecov-io commented on issue #5746: [bugfix] BigNumber crash, Horizon indent and Myanmar geojson

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5746?src=pr&el=h1) Report
> Merging [#5746](https://codecov.io/gh/apache/incubator-superset/pull/5746?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8d01c84c543a0905e55e9c4e4464249d1c382553?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `0%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/5746/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/5746?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master    #5746      +/-   ##
==========================================
- Coverage   63.45%   63.44%   -0.01%     
==========================================
  Files         362      362              
  Lines       22978    22980       +2     
  Branches     2554     2555       +1     
==========================================
  Hits        14580    14580              
- Misses       8383     8385       +2     
  Partials       15       15
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5746?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/assets/src/visualizations/BigNumber.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5746/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9CaWdOdW1iZXIuanN4) | `0% <0%> (ø)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5746?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5746?src=pr&el=footer). Last update [8d01c84...d7279a4](https://codecov.io/gh/apache/incubator-superset/pull/5746?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-superset/pull/5746 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-superset] hughhhh closed pull request #5746: [bugfix] BigNumber crash, Horizon indent and Myanmar geojson

Posted by "hughhhh (GitHub)" <gi...@apache.org>.
[ pull request closed by hughhhh ]

[ Full content available at: https://github.com/apache/incubator-superset/pull/5746 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org