You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/02/09 15:33:08 UTC
[GitHub] [hudi] xushiyan opened a new pull request #4777: [HUDI-2931] Add config to disable table services
xushiyan opened a new pull request #4777:
URL: https://github.com/apache/hudi/pull/4777
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4777: [HUDI-2931] Add config to disable table services
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4777:
URL: https://github.com/apache/hudi/pull/4777#issuecomment-1039517016
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5f793eb450d44568bbe7bb48b5cf203b5e1d01ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5846",
"triggerID" : "5f793eb450d44568bbe7bb48b5cf203b5e1d01ad",
"triggerType" : "PUSH"
}, {
"hash" : "7fd1d4ca2cea2daf1ca5e97854ce423d35a46f22",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5847",
"triggerID" : "7fd1d4ca2cea2daf1ca5e97854ce423d35a46f22",
"triggerType" : "PUSH"
}, {
"hash" : "35493ec99dae921fd5e0b922fe7af0b75706bc67",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5918",
"triggerID" : "35493ec99dae921fd5e0b922fe7af0b75706bc67",
"triggerType" : "PUSH"
}, {
"hash" : "9733bbc5dbb716c55a0155313b8913fd1bbf0a4a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9733bbc5dbb716c55a0155313b8913fd1bbf0a4a",
"triggerType" : "PUSH"
}, {
"hash" : "9c5bd374a7879598c2a9aaf3fc8bcf08ba2c2133",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5956",
"triggerID" : "9c5bd374a7879598c2a9aaf3fc8bcf08ba2c2133",
"triggerType" : "PUSH"
}, {
"hash" : "acc8019917fd8f85d874bb89c1bafba21933f9b2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "acc8019917fd8f85d874bb89c1bafba21933f9b2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9733bbc5dbb716c55a0155313b8913fd1bbf0a4a UNKNOWN
* 9c5bd374a7879598c2a9aaf3fc8bcf08ba2c2133 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5956)
* acc8019917fd8f85d874bb89c1bafba21933f9b2 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on a change in pull request #4777: [HUDI-2931] Add config to disable table services
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on a change in pull request #4777:
URL: https://github.com/apache/hudi/pull/4777#discussion_r806023345
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java
##########
@@ -1142,7 +1152,13 @@ protected boolean scheduleCleaningAtInstant(String instantTime, Option<Map<Strin
private Option<String> scheduleTableServiceInternal(String instantTime, Option<Map<String, String>> extraMetadata,
TableServiceType tableServiceType) {
+ if (!tableServicesEnabled(config)) {
+ return Option.empty();
+ }
switch (tableServiceType) {
+ case ARCHIVE:
+ LOG.info("Scheduling archiving is not supported. Skipping.");
Review comment:
why adding this? no one should be scheduling archiving. so, wondering if we should not add this and let it throw in default clause w/ unknown table service type ?
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/async/HoodieAsyncTableService.java
##########
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.hudi.async;
+
+import org.apache.hudi.client.RunsTableService;
+import org.apache.hudi.config.HoodieWriteConfig;
+
+import java.util.function.Function;
+
+public abstract class HoodieAsyncTableService extends HoodieAsyncService implements RunsTableService {
Review comment:
I see a reason to have RunsTableService, but whats the necessity to add HoodieAsyncService and then HoodieAsyncTableService. I feel we can drop HoodieAsyncService only. and HoodieAsyncTableService can directly implement RunsTableService.
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/async/HoodieAsyncTableService.java
##########
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.hudi.async;
+
+import org.apache.hudi.client.RunsTableService;
+import org.apache.hudi.config.HoodieWriteConfig;
+
+import java.util.function.Function;
+
+public abstract class HoodieAsyncTableService extends HoodieAsyncService implements RunsTableService {
+
+ protected HoodieWriteConfig writeConfig;
+
+ protected HoodieAsyncTableService() {
+ }
+
+ protected HoodieAsyncTableService(HoodieWriteConfig writeConfig) {
+ this.writeConfig = writeConfig;
+ }
+
+ protected HoodieAsyncTableService(HoodieWriteConfig writeConfig, boolean runInDaemonMode) {
+ super(runInDaemonMode);
+ this.writeConfig = writeConfig;
+ }
+
+ @Override
+ public void start(Function<Boolean, Boolean> onShutdownCallback) {
+ if (!tableServicesEnabled(writeConfig)) {
Review comment:
also, trying to understand where exactly this guard need to be added.
As per master, this is my understanding.
we check the configs and may not start the async service only.
for eg
```
if (writeClient.getConfig().isAutoClean() && writeClient.getConfig().isAsyncClean()) {
asyncCleanerService = new AsyncCleanerService(writeClient);
asyncCleanerService.start(null);
} else {
LOG.info("Async auto cleaning is not enabled. Not running cleaner now");
}
```
So, that the shutdown code looks as below.
```
if (asyncCleanerService != null) {
LOG.info("Waiting for async cleaner to finish");
try {
asyncCleanerService.waitForShutdown();
} catch (Exception e) {
throw new HoodieException("Error waiting for async cleaning to finish", e);
}
}
```
```
public static void forceShutdown(AsyncCleanerService asyncCleanerService) {
if (asyncCleanerService != null) {
LOG.info("Shutting down async cleaner");
asyncCleanerService.shutdown(true);
}
}
```
but now as per this patch, I feel this is an additional check we are adding which may not be invoked at all since the async service should not be instantiated at all if the config of interest is not enabled only.
Or how are we ensuring HoodieAsyncService.shutdown() and HoodieAsyncService.waitForShutdown accounts for tableServiceDisabled flow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4777: [HUDI-2931] Add config to disable table services
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4777:
URL: https://github.com/apache/hudi/pull/4777#issuecomment-1037679105
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5f793eb450d44568bbe7bb48b5cf203b5e1d01ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5846",
"triggerID" : "5f793eb450d44568bbe7bb48b5cf203b5e1d01ad",
"triggerType" : "PUSH"
}, {
"hash" : "7fd1d4ca2cea2daf1ca5e97854ce423d35a46f22",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5847",
"triggerID" : "7fd1d4ca2cea2daf1ca5e97854ce423d35a46f22",
"triggerType" : "PUSH"
}, {
"hash" : "35493ec99dae921fd5e0b922fe7af0b75706bc67",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5918",
"triggerID" : "35493ec99dae921fd5e0b922fe7af0b75706bc67",
"triggerType" : "PUSH"
}, {
"hash" : "9733bbc5dbb716c55a0155313b8913fd1bbf0a4a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9733bbc5dbb716c55a0155313b8913fd1bbf0a4a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 35493ec99dae921fd5e0b922fe7af0b75706bc67 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5918)
* 9733bbc5dbb716c55a0155313b8913fd1bbf0a4a UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4777: [HUDI-2931] Add config to disable table services
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4777:
URL: https://github.com/apache/hudi/pull/4777#issuecomment-1036346236
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5f793eb450d44568bbe7bb48b5cf203b5e1d01ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5846",
"triggerID" : "5f793eb450d44568bbe7bb48b5cf203b5e1d01ad",
"triggerType" : "PUSH"
}, {
"hash" : "7fd1d4ca2cea2daf1ca5e97854ce423d35a46f22",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5847",
"triggerID" : "7fd1d4ca2cea2daf1ca5e97854ce423d35a46f22",
"triggerType" : "PUSH"
}, {
"hash" : "35493ec99dae921fd5e0b922fe7af0b75706bc67",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5918",
"triggerID" : "35493ec99dae921fd5e0b922fe7af0b75706bc67",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7fd1d4ca2cea2daf1ca5e97854ce423d35a46f22 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5847)
* 35493ec99dae921fd5e0b922fe7af0b75706bc67 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5918)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4777: [HUDI-2931] Add config to disable table services
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4777:
URL: https://github.com/apache/hudi/pull/4777#issuecomment-1033905526
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5f793eb450d44568bbe7bb48b5cf203b5e1d01ad",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5846",
"triggerID" : "5f793eb450d44568bbe7bb48b5cf203b5e1d01ad",
"triggerType" : "PUSH"
}, {
"hash" : "7fd1d4ca2cea2daf1ca5e97854ce423d35a46f22",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7fd1d4ca2cea2daf1ca5e97854ce423d35a46f22",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5f793eb450d44568bbe7bb48b5cf203b5e1d01ad Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5846)
* 7fd1d4ca2cea2daf1ca5e97854ce423d35a46f22 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4777: [HUDI-2931] Add config to disable table services
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4777:
URL: https://github.com/apache/hudi/pull/4777#issuecomment-1033902056
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5f793eb450d44568bbe7bb48b5cf203b5e1d01ad",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5846",
"triggerID" : "5f793eb450d44568bbe7bb48b5cf203b5e1d01ad",
"triggerType" : "PUSH"
}, {
"hash" : "7fd1d4ca2cea2daf1ca5e97854ce423d35a46f22",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7fd1d4ca2cea2daf1ca5e97854ce423d35a46f22",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5f793eb450d44568bbe7bb48b5cf203b5e1d01ad Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5846)
* 7fd1d4ca2cea2daf1ca5e97854ce423d35a46f22 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4777: [HUDI-2931] Add config to disable table services
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4777:
URL: https://github.com/apache/hudi/pull/4777#issuecomment-1037718151
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5f793eb450d44568bbe7bb48b5cf203b5e1d01ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5846",
"triggerID" : "5f793eb450d44568bbe7bb48b5cf203b5e1d01ad",
"triggerType" : "PUSH"
}, {
"hash" : "7fd1d4ca2cea2daf1ca5e97854ce423d35a46f22",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5847",
"triggerID" : "7fd1d4ca2cea2daf1ca5e97854ce423d35a46f22",
"triggerType" : "PUSH"
}, {
"hash" : "35493ec99dae921fd5e0b922fe7af0b75706bc67",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5918",
"triggerID" : "35493ec99dae921fd5e0b922fe7af0b75706bc67",
"triggerType" : "PUSH"
}, {
"hash" : "9733bbc5dbb716c55a0155313b8913fd1bbf0a4a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9733bbc5dbb716c55a0155313b8913fd1bbf0a4a",
"triggerType" : "PUSH"
}, {
"hash" : "9c5bd374a7879598c2a9aaf3fc8bcf08ba2c2133",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5956",
"triggerID" : "9c5bd374a7879598c2a9aaf3fc8bcf08ba2c2133",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9733bbc5dbb716c55a0155313b8913fd1bbf0a4a UNKNOWN
* 9c5bd374a7879598c2a9aaf3fc8bcf08ba2c2133 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5956)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on a change in pull request #4777: [HUDI-2931] Add config to disable table services
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on a change in pull request #4777:
URL: https://github.com/apache/hudi/pull/4777#discussion_r806023345
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java
##########
@@ -1142,7 +1152,13 @@ protected boolean scheduleCleaningAtInstant(String instantTime, Option<Map<Strin
private Option<String> scheduleTableServiceInternal(String instantTime, Option<Map<String, String>> extraMetadata,
TableServiceType tableServiceType) {
+ if (!tableServicesEnabled(config)) {
+ return Option.empty();
+ }
switch (tableServiceType) {
+ case ARCHIVE:
+ LOG.info("Scheduling archiving is not supported. Skipping.");
Review comment:
why adding this? no one should be scheduling archiving. so, wondering if we should not add this and let it throw in default clause w/ unknown table service type ?
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/async/HoodieAsyncTableService.java
##########
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.hudi.async;
+
+import org.apache.hudi.client.RunsTableService;
+import org.apache.hudi.config.HoodieWriteConfig;
+
+import java.util.function.Function;
+
+public abstract class HoodieAsyncTableService extends HoodieAsyncService implements RunsTableService {
Review comment:
I see a reason to have RunsTableService, but whats the necessity to add HoodieAsyncService and then HoodieAsyncTableService. I feel we can drop HoodieAsyncService only. and HoodieAsyncTableService can directly implement RunsTableService.
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/async/HoodieAsyncTableService.java
##########
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.hudi.async;
+
+import org.apache.hudi.client.RunsTableService;
+import org.apache.hudi.config.HoodieWriteConfig;
+
+import java.util.function.Function;
+
+public abstract class HoodieAsyncTableService extends HoodieAsyncService implements RunsTableService {
+
+ protected HoodieWriteConfig writeConfig;
+
+ protected HoodieAsyncTableService() {
+ }
+
+ protected HoodieAsyncTableService(HoodieWriteConfig writeConfig) {
+ this.writeConfig = writeConfig;
+ }
+
+ protected HoodieAsyncTableService(HoodieWriteConfig writeConfig, boolean runInDaemonMode) {
+ super(runInDaemonMode);
+ this.writeConfig = writeConfig;
+ }
+
+ @Override
+ public void start(Function<Boolean, Boolean> onShutdownCallback) {
+ if (!tableServicesEnabled(writeConfig)) {
Review comment:
also, trying to understand where exactly this guard need to be added.
As per master, this is my understanding.
we check the configs and may not start the async service only.
for eg
```
if (writeClient.getConfig().isAutoClean() && writeClient.getConfig().isAsyncClean()) {
asyncCleanerService = new AsyncCleanerService(writeClient);
asyncCleanerService.start(null);
} else {
LOG.info("Async auto cleaning is not enabled. Not running cleaner now");
}
```
So, that the shutdown code looks as below.
```
if (asyncCleanerService != null) {
LOG.info("Waiting for async cleaner to finish");
try {
asyncCleanerService.waitForShutdown();
} catch (Exception e) {
throw new HoodieException("Error waiting for async cleaning to finish", e);
}
}
```
```
public static void forceShutdown(AsyncCleanerService asyncCleanerService) {
if (asyncCleanerService != null) {
LOG.info("Shutting down async cleaner");
asyncCleanerService.shutdown(true);
}
}
```
but now as per this patch, I feel this is an additional check we are adding which may not be invoked at all since the async service should not be instantiated at all if the config of interest is not enabled only.
Or how are we ensuring HoodieAsyncService.shutdown() and HoodieAsyncService.waitForShutdown accounts for tableServiceDisabled flow.
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/async/HoodieAsyncTableService.java
##########
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.hudi.async;
+
+import org.apache.hudi.client.RunsTableService;
+import org.apache.hudi.config.HoodieWriteConfig;
+
+import java.util.function.Function;
+
+public abstract class HoodieAsyncTableService extends HoodieAsyncService implements RunsTableService {
Review comment:
I see a reason to have RunsTableService, but whats the necessity to add HoodieAsyncService and then HoodieAsyncTableService. I feel we can drop HoodieAsyncService only. and HoodieAsyncTableService can directly implement RunsTableService. the functionality you intend to add to HoodieAsyncService, we can add it to HoodieAsyncTableService only. or if you can help explain the need, would be great.
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/RunsTableService.java
##########
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.client;
+
+import org.apache.hudi.config.HoodieWriteConfig;
+
+import org.apache.log4j.LogManager;
+import org.apache.log4j.Logger;
+
+public interface RunsTableService {
+
+ Logger LOG = LogManager.getLogger(RunsTableService.class);
+
+ default boolean tableServicesEnabled(HoodieWriteConfig config) {
+ boolean enabled = config.areTableServicesEnabled();
Review comment:
on second thought, wondering if we really need this class. this is just one line condition check and its just one config check. why not check it in place only.
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/async/HoodieAsyncTableService.java
##########
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.hudi.async;
+
+import org.apache.hudi.client.RunsTableService;
+import org.apache.hudi.config.HoodieWriteConfig;
+
+import java.util.function.Function;
+
+public abstract class HoodieAsyncTableService extends HoodieAsyncService implements RunsTableService {
+
+ protected HoodieWriteConfig writeConfig;
+
+ protected HoodieAsyncTableService() {
+ }
+
+ protected HoodieAsyncTableService(HoodieWriteConfig writeConfig) {
+ this.writeConfig = writeConfig;
+ }
+
+ protected HoodieAsyncTableService(HoodieWriteConfig writeConfig, boolean runInDaemonMode) {
+ super(runInDaemonMode);
+ this.writeConfig = writeConfig;
+ }
+
+ @Override
+ public void start(Function<Boolean, Boolean> onShutdownCallback) {
+ if (!tableServicesEnabled(writeConfig)) {
Review comment:
sounds good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4777: [HUDI-2931] Add config to disable table services
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4777:
URL: https://github.com/apache/hudi/pull/4777#issuecomment-1037682667
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5f793eb450d44568bbe7bb48b5cf203b5e1d01ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5846",
"triggerID" : "5f793eb450d44568bbe7bb48b5cf203b5e1d01ad",
"triggerType" : "PUSH"
}, {
"hash" : "7fd1d4ca2cea2daf1ca5e97854ce423d35a46f22",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5847",
"triggerID" : "7fd1d4ca2cea2daf1ca5e97854ce423d35a46f22",
"triggerType" : "PUSH"
}, {
"hash" : "35493ec99dae921fd5e0b922fe7af0b75706bc67",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5918",
"triggerID" : "35493ec99dae921fd5e0b922fe7af0b75706bc67",
"triggerType" : "PUSH"
}, {
"hash" : "9733bbc5dbb716c55a0155313b8913fd1bbf0a4a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9733bbc5dbb716c55a0155313b8913fd1bbf0a4a",
"triggerType" : "PUSH"
}, {
"hash" : "9c5bd374a7879598c2a9aaf3fc8bcf08ba2c2133",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5956",
"triggerID" : "9c5bd374a7879598c2a9aaf3fc8bcf08ba2c2133",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 35493ec99dae921fd5e0b922fe7af0b75706bc67 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5918)
* 9733bbc5dbb716c55a0155313b8913fd1bbf0a4a UNKNOWN
* 9c5bd374a7879598c2a9aaf3fc8bcf08ba2c2133 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5956)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4777: [HUDI-2931] Add config to disable table services
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4777:
URL: https://github.com/apache/hudi/pull/4777#issuecomment-1034072693
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5f793eb450d44568bbe7bb48b5cf203b5e1d01ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5846",
"triggerID" : "5f793eb450d44568bbe7bb48b5cf203b5e1d01ad",
"triggerType" : "PUSH"
}, {
"hash" : "7fd1d4ca2cea2daf1ca5e97854ce423d35a46f22",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5847",
"triggerID" : "7fd1d4ca2cea2daf1ca5e97854ce423d35a46f22",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7fd1d4ca2cea2daf1ca5e97854ce423d35a46f22 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5847)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4777: [HUDI-2931] Add config to disable table services
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4777:
URL: https://github.com/apache/hudi/pull/4777#issuecomment-1039780530
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5f793eb450d44568bbe7bb48b5cf203b5e1d01ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5846",
"triggerID" : "5f793eb450d44568bbe7bb48b5cf203b5e1d01ad",
"triggerType" : "PUSH"
}, {
"hash" : "7fd1d4ca2cea2daf1ca5e97854ce423d35a46f22",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5847",
"triggerID" : "7fd1d4ca2cea2daf1ca5e97854ce423d35a46f22",
"triggerType" : "PUSH"
}, {
"hash" : "35493ec99dae921fd5e0b922fe7af0b75706bc67",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5918",
"triggerID" : "35493ec99dae921fd5e0b922fe7af0b75706bc67",
"triggerType" : "PUSH"
}, {
"hash" : "9733bbc5dbb716c55a0155313b8913fd1bbf0a4a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9733bbc5dbb716c55a0155313b8913fd1bbf0a4a",
"triggerType" : "PUSH"
}, {
"hash" : "9c5bd374a7879598c2a9aaf3fc8bcf08ba2c2133",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5956",
"triggerID" : "9c5bd374a7879598c2a9aaf3fc8bcf08ba2c2133",
"triggerType" : "PUSH"
}, {
"hash" : "acc8019917fd8f85d874bb89c1bafba21933f9b2",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6001",
"triggerID" : "acc8019917fd8f85d874bb89c1bafba21933f9b2",
"triggerType" : "PUSH"
}, {
"hash" : "9c350835427bfdc586f0be3834ead1db6691cba3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9c350835427bfdc586f0be3834ead1db6691cba3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9733bbc5dbb716c55a0155313b8913fd1bbf0a4a UNKNOWN
* acc8019917fd8f85d874bb89c1bafba21933f9b2 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6001)
* 9c350835427bfdc586f0be3834ead1db6691cba3 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan commented on a change in pull request #4777: [HUDI-2931] Add config to disable table services
Posted by GitBox <gi...@apache.org>.
xushiyan commented on a change in pull request #4777:
URL: https://github.com/apache/hudi/pull/4777#discussion_r806171206
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/async/HoodieAsyncTableService.java
##########
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.hudi.async;
+
+import org.apache.hudi.client.RunsTableService;
+import org.apache.hudi.config.HoodieWriteConfig;
+
+import java.util.function.Function;
+
+public abstract class HoodieAsyncTableService extends HoodieAsyncService implements RunsTableService {
+
+ protected HoodieWriteConfig writeConfig;
+
+ protected HoodieAsyncTableService() {
+ }
+
+ protected HoodieAsyncTableService(HoodieWriteConfig writeConfig) {
+ this.writeConfig = writeConfig;
+ }
+
+ protected HoodieAsyncTableService(HoodieWriteConfig writeConfig, boolean runInDaemonMode) {
+ super(runInDaemonMode);
+ this.writeConfig = writeConfig;
+ }
+
+ @Override
+ public void start(Function<Boolean, Boolean> onShutdownCallback) {
+ if (!tableServicesEnabled(writeConfig)) {
Review comment:
the main idea is: we can't prevent an async service to be instantiated but we can prevent them from running by checking this in `start()`. It'd be some code smell if we always check configs before creating an async service; we better encapsulate the checking inside the services, hence this patch's approach. Since the start() will never create a future to run async, shutdown() or waitForShutdown() should just exit no-op. From the existing codebase, i see `shutdown()` null-check `executor` but `waitForShutdown()` does not null-check `future`. So I should add a null-check there as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan commented on a change in pull request #4777: [HUDI-2931] Add config to disable table services
Posted by GitBox <gi...@apache.org>.
xushiyan commented on a change in pull request #4777:
URL: https://github.com/apache/hudi/pull/4777#discussion_r806204484
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/async/HoodieAsyncTableService.java
##########
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.hudi.async;
+
+import org.apache.hudi.client.RunsTableService;
+import org.apache.hudi.config.HoodieWriteConfig;
+
+import java.util.function.Function;
+
+public abstract class HoodieAsyncTableService extends HoodieAsyncService implements RunsTableService {
Review comment:
@nsivabalan just recalled that `BaseHoodieWriteClient implements RunsTableService` as it needs to guard other sync APIs, so we'd need both `HoodieAsyncTableService` and `RunsTableService`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4777: [HUDI-2931] Add config to disable table services
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4777:
URL: https://github.com/apache/hudi/pull/4777#issuecomment-1033892143
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5f793eb450d44568bbe7bb48b5cf203b5e1d01ad",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5f793eb450d44568bbe7bb48b5cf203b5e1d01ad",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5f793eb450d44568bbe7bb48b5cf203b5e1d01ad UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4777: [HUDI-2931] Add config to disable table services
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4777:
URL: https://github.com/apache/hudi/pull/4777#issuecomment-1033905526
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5f793eb450d44568bbe7bb48b5cf203b5e1d01ad",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5846",
"triggerID" : "5f793eb450d44568bbe7bb48b5cf203b5e1d01ad",
"triggerType" : "PUSH"
}, {
"hash" : "7fd1d4ca2cea2daf1ca5e97854ce423d35a46f22",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7fd1d4ca2cea2daf1ca5e97854ce423d35a46f22",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5f793eb450d44568bbe7bb48b5cf203b5e1d01ad Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5846)
* 7fd1d4ca2cea2daf1ca5e97854ce423d35a46f22 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4777: [HUDI-2931] Add config to disable table services
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4777:
URL: https://github.com/apache/hudi/pull/4777#issuecomment-1036343274
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5f793eb450d44568bbe7bb48b5cf203b5e1d01ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5846",
"triggerID" : "5f793eb450d44568bbe7bb48b5cf203b5e1d01ad",
"triggerType" : "PUSH"
}, {
"hash" : "7fd1d4ca2cea2daf1ca5e97854ce423d35a46f22",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5847",
"triggerID" : "7fd1d4ca2cea2daf1ca5e97854ce423d35a46f22",
"triggerType" : "PUSH"
}, {
"hash" : "35493ec99dae921fd5e0b922fe7af0b75706bc67",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "35493ec99dae921fd5e0b922fe7af0b75706bc67",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7fd1d4ca2cea2daf1ca5e97854ce423d35a46f22 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5847)
* 35493ec99dae921fd5e0b922fe7af0b75706bc67 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4777: [HUDI-2931] Add config to disable table services
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4777:
URL: https://github.com/apache/hudi/pull/4777#issuecomment-1037682667
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5f793eb450d44568bbe7bb48b5cf203b5e1d01ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5846",
"triggerID" : "5f793eb450d44568bbe7bb48b5cf203b5e1d01ad",
"triggerType" : "PUSH"
}, {
"hash" : "7fd1d4ca2cea2daf1ca5e97854ce423d35a46f22",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5847",
"triggerID" : "7fd1d4ca2cea2daf1ca5e97854ce423d35a46f22",
"triggerType" : "PUSH"
}, {
"hash" : "35493ec99dae921fd5e0b922fe7af0b75706bc67",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5918",
"triggerID" : "35493ec99dae921fd5e0b922fe7af0b75706bc67",
"triggerType" : "PUSH"
}, {
"hash" : "9733bbc5dbb716c55a0155313b8913fd1bbf0a4a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9733bbc5dbb716c55a0155313b8913fd1bbf0a4a",
"triggerType" : "PUSH"
}, {
"hash" : "9c5bd374a7879598c2a9aaf3fc8bcf08ba2c2133",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5956",
"triggerID" : "9c5bd374a7879598c2a9aaf3fc8bcf08ba2c2133",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 35493ec99dae921fd5e0b922fe7af0b75706bc67 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5918)
* 9733bbc5dbb716c55a0155313b8913fd1bbf0a4a UNKNOWN
* 9c5bd374a7879598c2a9aaf3fc8bcf08ba2c2133 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5956)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4777: [HUDI-2931] Add config to disable table services
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4777:
URL: https://github.com/apache/hudi/pull/4777#issuecomment-1036441951
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5f793eb450d44568bbe7bb48b5cf203b5e1d01ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5846",
"triggerID" : "5f793eb450d44568bbe7bb48b5cf203b5e1d01ad",
"triggerType" : "PUSH"
}, {
"hash" : "7fd1d4ca2cea2daf1ca5e97854ce423d35a46f22",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5847",
"triggerID" : "7fd1d4ca2cea2daf1ca5e97854ce423d35a46f22",
"triggerType" : "PUSH"
}, {
"hash" : "35493ec99dae921fd5e0b922fe7af0b75706bc67",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5918",
"triggerID" : "35493ec99dae921fd5e0b922fe7af0b75706bc67",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 35493ec99dae921fd5e0b922fe7af0b75706bc67 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5918)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4777: [HUDI-2931] Add config to disable table services
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4777:
URL: https://github.com/apache/hudi/pull/4777#issuecomment-1033892143
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5f793eb450d44568bbe7bb48b5cf203b5e1d01ad",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5f793eb450d44568bbe7bb48b5cf203b5e1d01ad",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5f793eb450d44568bbe7bb48b5cf203b5e1d01ad UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4777: [HUDI-2931] Add config to disable table services
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4777:
URL: https://github.com/apache/hudi/pull/4777#issuecomment-1033965386
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5f793eb450d44568bbe7bb48b5cf203b5e1d01ad",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5846",
"triggerID" : "5f793eb450d44568bbe7bb48b5cf203b5e1d01ad",
"triggerType" : "PUSH"
}, {
"hash" : "7fd1d4ca2cea2daf1ca5e97854ce423d35a46f22",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5847",
"triggerID" : "7fd1d4ca2cea2daf1ca5e97854ce423d35a46f22",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5f793eb450d44568bbe7bb48b5cf203b5e1d01ad Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5846)
* 7fd1d4ca2cea2daf1ca5e97854ce423d35a46f22 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5847)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4777: [HUDI-2931] Add config to disable table services
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4777:
URL: https://github.com/apache/hudi/pull/4777#issuecomment-1037718151
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4777: [HUDI-2931] Add config to disable table services
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4777:
URL: https://github.com/apache/hudi/pull/4777#issuecomment-1039634924
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5f793eb450d44568bbe7bb48b5cf203b5e1d01ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5846",
"triggerID" : "5f793eb450d44568bbe7bb48b5cf203b5e1d01ad",
"triggerType" : "PUSH"
}, {
"hash" : "7fd1d4ca2cea2daf1ca5e97854ce423d35a46f22",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5847",
"triggerID" : "7fd1d4ca2cea2daf1ca5e97854ce423d35a46f22",
"triggerType" : "PUSH"
}, {
"hash" : "35493ec99dae921fd5e0b922fe7af0b75706bc67",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5918",
"triggerID" : "35493ec99dae921fd5e0b922fe7af0b75706bc67",
"triggerType" : "PUSH"
}, {
"hash" : "9733bbc5dbb716c55a0155313b8913fd1bbf0a4a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9733bbc5dbb716c55a0155313b8913fd1bbf0a4a",
"triggerType" : "PUSH"
}, {
"hash" : "9c5bd374a7879598c2a9aaf3fc8bcf08ba2c2133",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5956",
"triggerID" : "9c5bd374a7879598c2a9aaf3fc8bcf08ba2c2133",
"triggerType" : "PUSH"
}, {
"hash" : "acc8019917fd8f85d874bb89c1bafba21933f9b2",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6001",
"triggerID" : "acc8019917fd8f85d874bb89c1bafba21933f9b2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9733bbc5dbb716c55a0155313b8913fd1bbf0a4a UNKNOWN
* acc8019917fd8f85d874bb89c1bafba21933f9b2 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6001)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on a change in pull request #4777: [HUDI-2931] Add config to disable table services
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on a change in pull request #4777:
URL: https://github.com/apache/hudi/pull/4777#discussion_r806027043
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/async/HoodieAsyncTableService.java
##########
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.hudi.async;
+
+import org.apache.hudi.client.RunsTableService;
+import org.apache.hudi.config.HoodieWriteConfig;
+
+import java.util.function.Function;
+
+public abstract class HoodieAsyncTableService extends HoodieAsyncService implements RunsTableService {
Review comment:
I see a reason to have RunsTableService, but whats the necessity to add HoodieAsyncService and then HoodieAsyncTableService. I feel we can drop HoodieAsyncService only. and HoodieAsyncTableService can directly implement RunsTableService. the functionality you intend to add to HoodieAsyncService, we can add it to HoodieAsyncTableService only. or if you can help explain the need, would be great.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4777: [HUDI-2931] Add config to disable table services
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4777:
URL: https://github.com/apache/hudi/pull/4777#issuecomment-1039885425
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9c350835427bfdc586f0be3834ead1db6691cba3",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6015",
"triggerID" : "9c350835427bfdc586f0be3834ead1db6691cba3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9c350835427bfdc586f0be3834ead1db6691cba3 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6015)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4777: [HUDI-2931] Add config to disable table services
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4777:
URL: https://github.com/apache/hudi/pull/4777#issuecomment-1036343274
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5f793eb450d44568bbe7bb48b5cf203b5e1d01ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5846",
"triggerID" : "5f793eb450d44568bbe7bb48b5cf203b5e1d01ad",
"triggerType" : "PUSH"
}, {
"hash" : "7fd1d4ca2cea2daf1ca5e97854ce423d35a46f22",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5847",
"triggerID" : "7fd1d4ca2cea2daf1ca5e97854ce423d35a46f22",
"triggerType" : "PUSH"
}, {
"hash" : "35493ec99dae921fd5e0b922fe7af0b75706bc67",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "35493ec99dae921fd5e0b922fe7af0b75706bc67",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7fd1d4ca2cea2daf1ca5e97854ce423d35a46f22 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5847)
* 35493ec99dae921fd5e0b922fe7af0b75706bc67 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4777: [HUDI-2931] Add config to disable table services
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4777:
URL: https://github.com/apache/hudi/pull/4777#issuecomment-1039572914
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5f793eb450d44568bbe7bb48b5cf203b5e1d01ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5846",
"triggerID" : "5f793eb450d44568bbe7bb48b5cf203b5e1d01ad",
"triggerType" : "PUSH"
}, {
"hash" : "7fd1d4ca2cea2daf1ca5e97854ce423d35a46f22",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5847",
"triggerID" : "7fd1d4ca2cea2daf1ca5e97854ce423d35a46f22",
"triggerType" : "PUSH"
}, {
"hash" : "35493ec99dae921fd5e0b922fe7af0b75706bc67",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5918",
"triggerID" : "35493ec99dae921fd5e0b922fe7af0b75706bc67",
"triggerType" : "PUSH"
}, {
"hash" : "9733bbc5dbb716c55a0155313b8913fd1bbf0a4a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9733bbc5dbb716c55a0155313b8913fd1bbf0a4a",
"triggerType" : "PUSH"
}, {
"hash" : "9c5bd374a7879598c2a9aaf3fc8bcf08ba2c2133",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5956",
"triggerID" : "9c5bd374a7879598c2a9aaf3fc8bcf08ba2c2133",
"triggerType" : "PUSH"
}, {
"hash" : "acc8019917fd8f85d874bb89c1bafba21933f9b2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6001",
"triggerID" : "acc8019917fd8f85d874bb89c1bafba21933f9b2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9733bbc5dbb716c55a0155313b8913fd1bbf0a4a UNKNOWN
* 9c5bd374a7879598c2a9aaf3fc8bcf08ba2c2133 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5956)
* acc8019917fd8f85d874bb89c1bafba21933f9b2 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6001)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan merged pull request #4777: [HUDI-2931] Add config to disable table services
Posted by GitBox <gi...@apache.org>.
nsivabalan merged pull request #4777:
URL: https://github.com/apache/hudi/pull/4777
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4777: [HUDI-2931] Add config to disable table services
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4777:
URL: https://github.com/apache/hudi/pull/4777#issuecomment-1033895435
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5f793eb450d44568bbe7bb48b5cf203b5e1d01ad",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5846",
"triggerID" : "5f793eb450d44568bbe7bb48b5cf203b5e1d01ad",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5f793eb450d44568bbe7bb48b5cf203b5e1d01ad Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5846)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4777: [HUDI-2931] Add config to disable table services
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4777:
URL: https://github.com/apache/hudi/pull/4777#issuecomment-1033895435
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5f793eb450d44568bbe7bb48b5cf203b5e1d01ad",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5846",
"triggerID" : "5f793eb450d44568bbe7bb48b5cf203b5e1d01ad",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5f793eb450d44568bbe7bb48b5cf203b5e1d01ad Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5846)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4777: [HUDI-2931] Add config to disable table services
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4777:
URL: https://github.com/apache/hudi/pull/4777#issuecomment-1039780530
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5f793eb450d44568bbe7bb48b5cf203b5e1d01ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5846",
"triggerID" : "5f793eb450d44568bbe7bb48b5cf203b5e1d01ad",
"triggerType" : "PUSH"
}, {
"hash" : "7fd1d4ca2cea2daf1ca5e97854ce423d35a46f22",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5847",
"triggerID" : "7fd1d4ca2cea2daf1ca5e97854ce423d35a46f22",
"triggerType" : "PUSH"
}, {
"hash" : "35493ec99dae921fd5e0b922fe7af0b75706bc67",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5918",
"triggerID" : "35493ec99dae921fd5e0b922fe7af0b75706bc67",
"triggerType" : "PUSH"
}, {
"hash" : "9733bbc5dbb716c55a0155313b8913fd1bbf0a4a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9733bbc5dbb716c55a0155313b8913fd1bbf0a4a",
"triggerType" : "PUSH"
}, {
"hash" : "9c5bd374a7879598c2a9aaf3fc8bcf08ba2c2133",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5956",
"triggerID" : "9c5bd374a7879598c2a9aaf3fc8bcf08ba2c2133",
"triggerType" : "PUSH"
}, {
"hash" : "acc8019917fd8f85d874bb89c1bafba21933f9b2",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6001",
"triggerID" : "acc8019917fd8f85d874bb89c1bafba21933f9b2",
"triggerType" : "PUSH"
}, {
"hash" : "9c350835427bfdc586f0be3834ead1db6691cba3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9c350835427bfdc586f0be3834ead1db6691cba3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9733bbc5dbb716c55a0155313b8913fd1bbf0a4a UNKNOWN
* acc8019917fd8f85d874bb89c1bafba21933f9b2 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6001)
* 9c350835427bfdc586f0be3834ead1db6691cba3 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan commented on a change in pull request #4777: [HUDI-2931] Add config to disable table services
Posted by GitBox <gi...@apache.org>.
xushiyan commented on a change in pull request #4777:
URL: https://github.com/apache/hudi/pull/4777#discussion_r806159392
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java
##########
@@ -1142,7 +1152,13 @@ protected boolean scheduleCleaningAtInstant(String instantTime, Option<Map<Strin
private Option<String> scheduleTableServiceInternal(String instantTime, Option<Map<String, String>> extraMetadata,
TableServiceType tableServiceType) {
+ if (!tableServicesEnabled(config)) {
+ return Option.empty();
+ }
switch (tableServiceType) {
+ case ARCHIVE:
+ LOG.info("Scheduling archiving is not supported. Skipping.");
Review comment:
@nsivabalan it's because `org.apache.hudi.common.model.TableServiceType` was updated to include ARCHIVE, so the switch should enumerate the list for completeness.
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/async/HoodieAsyncTableService.java
##########
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.hudi.async;
+
+import org.apache.hudi.client.RunsTableService;
+import org.apache.hudi.config.HoodieWriteConfig;
+
+import java.util.function.Function;
+
+public abstract class HoodieAsyncTableService extends HoodieAsyncService implements RunsTableService {
Review comment:
@nsivabalan i don't think we can drop `HoodieAsyncService` since the async services for clean, archive, compact and cluster all inherit from `HoodieAsyncService`. The `HoodieAsyncTableService` is to hold the common logic like this switch. Besides, when there is `HoodieAsyncService`, then it's a natural pattern to extend from it to make `HoodieAsyncTableService`. The opposite would look odd: why wouldn't `HoodieAsyncTableService` extend `HoodieAsyncService`
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/async/HoodieAsyncTableService.java
##########
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.hudi.async;
+
+import org.apache.hudi.client.RunsTableService;
+import org.apache.hudi.config.HoodieWriteConfig;
+
+import java.util.function.Function;
+
+public abstract class HoodieAsyncTableService extends HoodieAsyncService implements RunsTableService {
+
+ protected HoodieWriteConfig writeConfig;
+
+ protected HoodieAsyncTableService() {
+ }
+
+ protected HoodieAsyncTableService(HoodieWriteConfig writeConfig) {
+ this.writeConfig = writeConfig;
+ }
+
+ protected HoodieAsyncTableService(HoodieWriteConfig writeConfig, boolean runInDaemonMode) {
+ super(runInDaemonMode);
+ this.writeConfig = writeConfig;
+ }
+
+ @Override
+ public void start(Function<Boolean, Boolean> onShutdownCallback) {
+ if (!tableServicesEnabled(writeConfig)) {
Review comment:
the main idea is: we can't prevent an async service to be instantiated but we can prevent them from running by checking this in `start()`. It'd be some code smell if we always check configs before creating an async service; we better encapsulate the checking inside the services, hence this patch's approach. Since the start() will never create a future to run async, shutdown() or waitForShutdown() should just exit no-op. From the existing codebase, i see `shutdown()` null-check `executor` but `waitForShutdown()` does not null-check `future`. So I should add a null-check there as well.
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/async/HoodieAsyncTableService.java
##########
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.hudi.async;
+
+import org.apache.hudi.client.RunsTableService;
+import org.apache.hudi.config.HoodieWriteConfig;
+
+import java.util.function.Function;
+
+public abstract class HoodieAsyncTableService extends HoodieAsyncService implements RunsTableService {
Review comment:
@nsivabalan just recalled that `BaseHoodieWriteClient implements RunsTableService` as it needs to guard other sync APIs, so we'd need both `HoodieAsyncTableService` and `RunsTableService`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4777: [HUDI-2931] Add config to disable table services
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4777:
URL: https://github.com/apache/hudi/pull/4777#issuecomment-1039784186
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9c350835427bfdc586f0be3834ead1db6691cba3",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6015",
"triggerID" : "9c350835427bfdc586f0be3834ead1db6691cba3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9c350835427bfdc586f0be3834ead1db6691cba3 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6015)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4777: [HUDI-2931] Add config to disable table services
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4777:
URL: https://github.com/apache/hudi/pull/4777#issuecomment-1037679105
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4777: [HUDI-2931] Add config to disable table services
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4777:
URL: https://github.com/apache/hudi/pull/4777#issuecomment-1039517016
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan commented on a change in pull request #4777: [HUDI-2931] Add config to disable table services
Posted by GitBox <gi...@apache.org>.
xushiyan commented on a change in pull request #4777:
URL: https://github.com/apache/hudi/pull/4777#discussion_r806159392
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java
##########
@@ -1142,7 +1152,13 @@ protected boolean scheduleCleaningAtInstant(String instantTime, Option<Map<Strin
private Option<String> scheduleTableServiceInternal(String instantTime, Option<Map<String, String>> extraMetadata,
TableServiceType tableServiceType) {
+ if (!tableServicesEnabled(config)) {
+ return Option.empty();
+ }
switch (tableServiceType) {
+ case ARCHIVE:
+ LOG.info("Scheduling archiving is not supported. Skipping.");
Review comment:
@nsivabalan it's because `org.apache.hudi.common.model.TableServiceType` was updated to include ARCHIVE, so the switch should enumerate the list for completeness.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4777: [HUDI-2931] Add config to disable table services
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4777:
URL: https://github.com/apache/hudi/pull/4777#issuecomment-1039572914
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5f793eb450d44568bbe7bb48b5cf203b5e1d01ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5846",
"triggerID" : "5f793eb450d44568bbe7bb48b5cf203b5e1d01ad",
"triggerType" : "PUSH"
}, {
"hash" : "7fd1d4ca2cea2daf1ca5e97854ce423d35a46f22",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5847",
"triggerID" : "7fd1d4ca2cea2daf1ca5e97854ce423d35a46f22",
"triggerType" : "PUSH"
}, {
"hash" : "35493ec99dae921fd5e0b922fe7af0b75706bc67",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5918",
"triggerID" : "35493ec99dae921fd5e0b922fe7af0b75706bc67",
"triggerType" : "PUSH"
}, {
"hash" : "9733bbc5dbb716c55a0155313b8913fd1bbf0a4a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9733bbc5dbb716c55a0155313b8913fd1bbf0a4a",
"triggerType" : "PUSH"
}, {
"hash" : "9c5bd374a7879598c2a9aaf3fc8bcf08ba2c2133",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5956",
"triggerID" : "9c5bd374a7879598c2a9aaf3fc8bcf08ba2c2133",
"triggerType" : "PUSH"
}, {
"hash" : "acc8019917fd8f85d874bb89c1bafba21933f9b2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6001",
"triggerID" : "acc8019917fd8f85d874bb89c1bafba21933f9b2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9733bbc5dbb716c55a0155313b8913fd1bbf0a4a UNKNOWN
* 9c5bd374a7879598c2a9aaf3fc8bcf08ba2c2133 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5956)
* acc8019917fd8f85d874bb89c1bafba21933f9b2 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6001)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4777: [HUDI-2931] Add config to disable table services
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4777:
URL: https://github.com/apache/hudi/pull/4777#issuecomment-1039784186
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9c350835427bfdc586f0be3834ead1db6691cba3",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6015",
"triggerID" : "9c350835427bfdc586f0be3834ead1db6691cba3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9c350835427bfdc586f0be3834ead1db6691cba3 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6015)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4777: [HUDI-2931] Add config to disable table services
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4777:
URL: https://github.com/apache/hudi/pull/4777#issuecomment-1039782486
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9c350835427bfdc586f0be3834ead1db6691cba3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9c350835427bfdc586f0be3834ead1db6691cba3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9c350835427bfdc586f0be3834ead1db6691cba3 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4777: [HUDI-2931] Add config to disable table services
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4777:
URL: https://github.com/apache/hudi/pull/4777#issuecomment-1036346236
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5f793eb450d44568bbe7bb48b5cf203b5e1d01ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5846",
"triggerID" : "5f793eb450d44568bbe7bb48b5cf203b5e1d01ad",
"triggerType" : "PUSH"
}, {
"hash" : "7fd1d4ca2cea2daf1ca5e97854ce423d35a46f22",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5847",
"triggerID" : "7fd1d4ca2cea2daf1ca5e97854ce423d35a46f22",
"triggerType" : "PUSH"
}, {
"hash" : "35493ec99dae921fd5e0b922fe7af0b75706bc67",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5918",
"triggerID" : "35493ec99dae921fd5e0b922fe7af0b75706bc67",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7fd1d4ca2cea2daf1ca5e97854ce423d35a46f22 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5847)
* 35493ec99dae921fd5e0b922fe7af0b75706bc67 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5918)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4777: [HUDI-2931] Add config to disable table services
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4777:
URL: https://github.com/apache/hudi/pull/4777#issuecomment-1037680916
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5f793eb450d44568bbe7bb48b5cf203b5e1d01ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5846",
"triggerID" : "5f793eb450d44568bbe7bb48b5cf203b5e1d01ad",
"triggerType" : "PUSH"
}, {
"hash" : "7fd1d4ca2cea2daf1ca5e97854ce423d35a46f22",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5847",
"triggerID" : "7fd1d4ca2cea2daf1ca5e97854ce423d35a46f22",
"triggerType" : "PUSH"
}, {
"hash" : "35493ec99dae921fd5e0b922fe7af0b75706bc67",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5918",
"triggerID" : "35493ec99dae921fd5e0b922fe7af0b75706bc67",
"triggerType" : "PUSH"
}, {
"hash" : "9733bbc5dbb716c55a0155313b8913fd1bbf0a4a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9733bbc5dbb716c55a0155313b8913fd1bbf0a4a",
"triggerType" : "PUSH"
}, {
"hash" : "9c5bd374a7879598c2a9aaf3fc8bcf08ba2c2133",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9c5bd374a7879598c2a9aaf3fc8bcf08ba2c2133",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 35493ec99dae921fd5e0b922fe7af0b75706bc67 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5918)
* 9733bbc5dbb716c55a0155313b8913fd1bbf0a4a UNKNOWN
* 9c5bd374a7879598c2a9aaf3fc8bcf08ba2c2133 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4777: [HUDI-2931] Add config to disable table services
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4777:
URL: https://github.com/apache/hudi/pull/4777#issuecomment-1034072693
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5f793eb450d44568bbe7bb48b5cf203b5e1d01ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5846",
"triggerID" : "5f793eb450d44568bbe7bb48b5cf203b5e1d01ad",
"triggerType" : "PUSH"
}, {
"hash" : "7fd1d4ca2cea2daf1ca5e97854ce423d35a46f22",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5847",
"triggerID" : "7fd1d4ca2cea2daf1ca5e97854ce423d35a46f22",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7fd1d4ca2cea2daf1ca5e97854ce423d35a46f22 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5847)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4777: [HUDI-2931] Add config to disable table services
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4777:
URL: https://github.com/apache/hudi/pull/4777#issuecomment-1033965386
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5f793eb450d44568bbe7bb48b5cf203b5e1d01ad",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5846",
"triggerID" : "5f793eb450d44568bbe7bb48b5cf203b5e1d01ad",
"triggerType" : "PUSH"
}, {
"hash" : "7fd1d4ca2cea2daf1ca5e97854ce423d35a46f22",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5847",
"triggerID" : "7fd1d4ca2cea2daf1ca5e97854ce423d35a46f22",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5f793eb450d44568bbe7bb48b5cf203b5e1d01ad Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5846)
* 7fd1d4ca2cea2daf1ca5e97854ce423d35a46f22 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5847)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4777: [HUDI-2931] Add config to disable table services
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4777:
URL: https://github.com/apache/hudi/pull/4777#issuecomment-1033902056
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5f793eb450d44568bbe7bb48b5cf203b5e1d01ad",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5846",
"triggerID" : "5f793eb450d44568bbe7bb48b5cf203b5e1d01ad",
"triggerType" : "PUSH"
}, {
"hash" : "7fd1d4ca2cea2daf1ca5e97854ce423d35a46f22",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7fd1d4ca2cea2daf1ca5e97854ce423d35a46f22",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5f793eb450d44568bbe7bb48b5cf203b5e1d01ad Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5846)
* 7fd1d4ca2cea2daf1ca5e97854ce423d35a46f22 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4777: [HUDI-2931] Add config to disable table services
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4777:
URL: https://github.com/apache/hudi/pull/4777#issuecomment-1037680916
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5f793eb450d44568bbe7bb48b5cf203b5e1d01ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5846",
"triggerID" : "5f793eb450d44568bbe7bb48b5cf203b5e1d01ad",
"triggerType" : "PUSH"
}, {
"hash" : "7fd1d4ca2cea2daf1ca5e97854ce423d35a46f22",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5847",
"triggerID" : "7fd1d4ca2cea2daf1ca5e97854ce423d35a46f22",
"triggerType" : "PUSH"
}, {
"hash" : "35493ec99dae921fd5e0b922fe7af0b75706bc67",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5918",
"triggerID" : "35493ec99dae921fd5e0b922fe7af0b75706bc67",
"triggerType" : "PUSH"
}, {
"hash" : "9733bbc5dbb716c55a0155313b8913fd1bbf0a4a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9733bbc5dbb716c55a0155313b8913fd1bbf0a4a",
"triggerType" : "PUSH"
}, {
"hash" : "9c5bd374a7879598c2a9aaf3fc8bcf08ba2c2133",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9c5bd374a7879598c2a9aaf3fc8bcf08ba2c2133",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 35493ec99dae921fd5e0b922fe7af0b75706bc67 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5918)
* 9733bbc5dbb716c55a0155313b8913fd1bbf0a4a UNKNOWN
* 9c5bd374a7879598c2a9aaf3fc8bcf08ba2c2133 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on a change in pull request #4777: [HUDI-2931] Add config to disable table services
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on a change in pull request #4777:
URL: https://github.com/apache/hudi/pull/4777#discussion_r806395518
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/RunsTableService.java
##########
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.client;
+
+import org.apache.hudi.config.HoodieWriteConfig;
+
+import org.apache.log4j.LogManager;
+import org.apache.log4j.Logger;
+
+public interface RunsTableService {
+
+ Logger LOG = LogManager.getLogger(RunsTableService.class);
+
+ default boolean tableServicesEnabled(HoodieWriteConfig config) {
+ boolean enabled = config.areTableServicesEnabled();
Review comment:
on second thought, wondering if we really need this class. this is just one line condition check and its just one config check. why not check it in place only.
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/async/HoodieAsyncTableService.java
##########
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.hudi.async;
+
+import org.apache.hudi.client.RunsTableService;
+import org.apache.hudi.config.HoodieWriteConfig;
+
+import java.util.function.Function;
+
+public abstract class HoodieAsyncTableService extends HoodieAsyncService implements RunsTableService {
+
+ protected HoodieWriteConfig writeConfig;
+
+ protected HoodieAsyncTableService() {
+ }
+
+ protected HoodieAsyncTableService(HoodieWriteConfig writeConfig) {
+ this.writeConfig = writeConfig;
+ }
+
+ protected HoodieAsyncTableService(HoodieWriteConfig writeConfig, boolean runInDaemonMode) {
+ super(runInDaemonMode);
+ this.writeConfig = writeConfig;
+ }
+
+ @Override
+ public void start(Function<Boolean, Boolean> onShutdownCallback) {
+ if (!tableServicesEnabled(writeConfig)) {
Review comment:
sounds good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan commented on a change in pull request #4777: [HUDI-2931] Add config to disable table services
Posted by GitBox <gi...@apache.org>.
xushiyan commented on a change in pull request #4777:
URL: https://github.com/apache/hudi/pull/4777#discussion_r806162929
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/async/HoodieAsyncTableService.java
##########
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.hudi.async;
+
+import org.apache.hudi.client.RunsTableService;
+import org.apache.hudi.config.HoodieWriteConfig;
+
+import java.util.function.Function;
+
+public abstract class HoodieAsyncTableService extends HoodieAsyncService implements RunsTableService {
Review comment:
@nsivabalan i don't think we can drop `HoodieAsyncService` since the async services for clean, archive, compact and cluster all inherit from `HoodieAsyncService`. The `HoodieAsyncTableService` is to hold the common logic like this switch. Besides, when there is `HoodieAsyncService`, then it's a natural pattern to extend from it to make `HoodieAsyncTableService`. The opposite would look odd: why wouldn't `HoodieAsyncTableService` extend `HoodieAsyncService`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4777: [HUDI-2931] Add config to disable table services
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4777:
URL: https://github.com/apache/hudi/pull/4777#issuecomment-1037718151
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5f793eb450d44568bbe7bb48b5cf203b5e1d01ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5846",
"triggerID" : "5f793eb450d44568bbe7bb48b5cf203b5e1d01ad",
"triggerType" : "PUSH"
}, {
"hash" : "7fd1d4ca2cea2daf1ca5e97854ce423d35a46f22",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5847",
"triggerID" : "7fd1d4ca2cea2daf1ca5e97854ce423d35a46f22",
"triggerType" : "PUSH"
}, {
"hash" : "35493ec99dae921fd5e0b922fe7af0b75706bc67",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5918",
"triggerID" : "35493ec99dae921fd5e0b922fe7af0b75706bc67",
"triggerType" : "PUSH"
}, {
"hash" : "9733bbc5dbb716c55a0155313b8913fd1bbf0a4a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9733bbc5dbb716c55a0155313b8913fd1bbf0a4a",
"triggerType" : "PUSH"
}, {
"hash" : "9c5bd374a7879598c2a9aaf3fc8bcf08ba2c2133",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5956",
"triggerID" : "9c5bd374a7879598c2a9aaf3fc8bcf08ba2c2133",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9733bbc5dbb716c55a0155313b8913fd1bbf0a4a UNKNOWN
* 9c5bd374a7879598c2a9aaf3fc8bcf08ba2c2133 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5956)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4777: [HUDI-2931] Add config to disable table services
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4777:
URL: https://github.com/apache/hudi/pull/4777#issuecomment-1036441951
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5f793eb450d44568bbe7bb48b5cf203b5e1d01ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5846",
"triggerID" : "5f793eb450d44568bbe7bb48b5cf203b5e1d01ad",
"triggerType" : "PUSH"
}, {
"hash" : "7fd1d4ca2cea2daf1ca5e97854ce423d35a46f22",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5847",
"triggerID" : "7fd1d4ca2cea2daf1ca5e97854ce423d35a46f22",
"triggerType" : "PUSH"
}, {
"hash" : "35493ec99dae921fd5e0b922fe7af0b75706bc67",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5918",
"triggerID" : "35493ec99dae921fd5e0b922fe7af0b75706bc67",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 35493ec99dae921fd5e0b922fe7af0b75706bc67 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5918)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4777: [HUDI-2931] Add config to disable table services
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4777:
URL: https://github.com/apache/hudi/pull/4777#issuecomment-1037679105
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5f793eb450d44568bbe7bb48b5cf203b5e1d01ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5846",
"triggerID" : "5f793eb450d44568bbe7bb48b5cf203b5e1d01ad",
"triggerType" : "PUSH"
}, {
"hash" : "7fd1d4ca2cea2daf1ca5e97854ce423d35a46f22",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5847",
"triggerID" : "7fd1d4ca2cea2daf1ca5e97854ce423d35a46f22",
"triggerType" : "PUSH"
}, {
"hash" : "35493ec99dae921fd5e0b922fe7af0b75706bc67",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5918",
"triggerID" : "35493ec99dae921fd5e0b922fe7af0b75706bc67",
"triggerType" : "PUSH"
}, {
"hash" : "9733bbc5dbb716c55a0155313b8913fd1bbf0a4a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9733bbc5dbb716c55a0155313b8913fd1bbf0a4a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 35493ec99dae921fd5e0b922fe7af0b75706bc67 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5918)
* 9733bbc5dbb716c55a0155313b8913fd1bbf0a4a UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4777: [HUDI-2931] Add config to disable table services
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4777:
URL: https://github.com/apache/hudi/pull/4777#issuecomment-1036441951
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4777: [HUDI-2931] Add config to disable table services
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4777:
URL: https://github.com/apache/hudi/pull/4777#issuecomment-1039517016
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5f793eb450d44568bbe7bb48b5cf203b5e1d01ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5846",
"triggerID" : "5f793eb450d44568bbe7bb48b5cf203b5e1d01ad",
"triggerType" : "PUSH"
}, {
"hash" : "7fd1d4ca2cea2daf1ca5e97854ce423d35a46f22",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5847",
"triggerID" : "7fd1d4ca2cea2daf1ca5e97854ce423d35a46f22",
"triggerType" : "PUSH"
}, {
"hash" : "35493ec99dae921fd5e0b922fe7af0b75706bc67",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5918",
"triggerID" : "35493ec99dae921fd5e0b922fe7af0b75706bc67",
"triggerType" : "PUSH"
}, {
"hash" : "9733bbc5dbb716c55a0155313b8913fd1bbf0a4a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9733bbc5dbb716c55a0155313b8913fd1bbf0a4a",
"triggerType" : "PUSH"
}, {
"hash" : "9c5bd374a7879598c2a9aaf3fc8bcf08ba2c2133",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5956",
"triggerID" : "9c5bd374a7879598c2a9aaf3fc8bcf08ba2c2133",
"triggerType" : "PUSH"
}, {
"hash" : "acc8019917fd8f85d874bb89c1bafba21933f9b2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "acc8019917fd8f85d874bb89c1bafba21933f9b2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9733bbc5dbb716c55a0155313b8913fd1bbf0a4a UNKNOWN
* 9c5bd374a7879598c2a9aaf3fc8bcf08ba2c2133 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5956)
* acc8019917fd8f85d874bb89c1bafba21933f9b2 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4777: [HUDI-2931] Add config to disable table services
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4777:
URL: https://github.com/apache/hudi/pull/4777#issuecomment-1039634924
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5f793eb450d44568bbe7bb48b5cf203b5e1d01ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5846",
"triggerID" : "5f793eb450d44568bbe7bb48b5cf203b5e1d01ad",
"triggerType" : "PUSH"
}, {
"hash" : "7fd1d4ca2cea2daf1ca5e97854ce423d35a46f22",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5847",
"triggerID" : "7fd1d4ca2cea2daf1ca5e97854ce423d35a46f22",
"triggerType" : "PUSH"
}, {
"hash" : "35493ec99dae921fd5e0b922fe7af0b75706bc67",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5918",
"triggerID" : "35493ec99dae921fd5e0b922fe7af0b75706bc67",
"triggerType" : "PUSH"
}, {
"hash" : "9733bbc5dbb716c55a0155313b8913fd1bbf0a4a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9733bbc5dbb716c55a0155313b8913fd1bbf0a4a",
"triggerType" : "PUSH"
}, {
"hash" : "9c5bd374a7879598c2a9aaf3fc8bcf08ba2c2133",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5956",
"triggerID" : "9c5bd374a7879598c2a9aaf3fc8bcf08ba2c2133",
"triggerType" : "PUSH"
}, {
"hash" : "acc8019917fd8f85d874bb89c1bafba21933f9b2",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6001",
"triggerID" : "acc8019917fd8f85d874bb89c1bafba21933f9b2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9733bbc5dbb716c55a0155313b8913fd1bbf0a4a UNKNOWN
* acc8019917fd8f85d874bb89c1bafba21933f9b2 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6001)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4777: [HUDI-2931] Add config to disable table services
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4777:
URL: https://github.com/apache/hudi/pull/4777#issuecomment-1039782486
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9c350835427bfdc586f0be3834ead1db6691cba3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9c350835427bfdc586f0be3834ead1db6691cba3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9c350835427bfdc586f0be3834ead1db6691cba3 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan merged pull request #4777: [HUDI-2931] Add config to disable table services
Posted by GitBox <gi...@apache.org>.
nsivabalan merged pull request #4777:
URL: https://github.com/apache/hudi/pull/4777
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org