[GitHub] lebeg opened a new pull request #9727: Refactored storage handling

[GitBox <gi...@apache.org>]

lebeg opened a new pull request #9727: Refactored storage handling
URL: https://github.com/apache/incubator-mxnet/pull/9727
 
 
   ## Description ##
   
   Made Storage::Handle objects and the memory they are handling be reference counted.
   
   ## Checklist ##
   ### Essentials ###
   - [x] Passed code style checking (`make lint`)
   - [x] Changes are complete (i.e. I finished coding on this PR)
   - [x] All changes have test coverage:
     - Unit tests are added
     - Added a functional test
   - [x] Code is well-documented: 
     - Existing docs improved
     - New methods documented
   - [x] To the my best knowledge, examples are not affected by this change
   
   ### Changes ###
   - Ensured that access to memory pointed by storage::Handles is protected by reference counting
   - Introduced a common interface to public Storage class and the underlying internal StorageManagers
   - Changed referencing of shared memory to a string key
   - Separated platform specific CPUSharedStorageManager implementations
   - Introduced a functional C++ test
   
   - Moved NDArray::Chunk implementation to .cc file for compile time and dependendencies reduction
   
   ## Comments ##
   - The change has grown significantly due to a lot of usages in the code.
   
   ## Still to be done in next iterations ##
   - Add Android implementation of CPUSharedStorageManager
   - Introduce locking for shared memory
   - Add coverage and more edge cases to Storage unit testing
   - Add functional test to automation

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services