You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "lilykuang (via GitHub)" <gi...@apache.org> on 2023/09/29 22:55:01 UTC
[GitHub] [superset] lilykuang commented on a diff in pull request #25403: fix: Tags Page Polish
lilykuang commented on code in PR #25403:
URL: https://github.com/apache/superset/pull/25403#discussion_r1341845768
##########
superset-frontend/src/features/allEntities/AllEntitiesTable.tsx:
##########
@@ -99,27 +131,69 @@ export default function AllEntitiesTable({
columns={[
{
accessor: type,
- Header: type.charAt(0).toUpperCase() + type.slice(1),
+ Header: 'Title',
+ },
+ {
+ Cell: ({
+ row: {
+ original: { tags = [] },
+ },
+ }: {
+ row: {
+ original: {
+ tags: Tag[];
+ };
+ };
+ }) => (
+ // Only show custom type tags
+ <TagsList
+ tags={tags.filter(
+ (tag: Tag) =>
+ tag.type === 'TagTypes.custom' || tag.type === 1,
+ )}
+ maxTags={3}
Review Comment:
Can this number be a constant on top of the file?
##########
superset-frontend/src/features/allEntities/AllEntitiesTable.tsx:
##########
@@ -22,18 +22,31 @@ import { t, styled, logging } from '@superset-ui/core';
import TableView, { EmptyWrapperType } from 'src/components/TableView';
import { addDangerToast } from 'src/components/MessageToasts/actions';
import Loading from 'src/components/Loading';
+import { TagsList } from 'src/components/Tags';
+import FacePile from 'src/components/FacePile';
+import Tag from 'src/types/TagType';
+import Owner from 'src/types/Owner';
+import { EmptyStateBig } from 'src/components/EmptyState';
import { fetchObjects } from '../tags/tags';
const AllEntitiesTableContainer = styled.div`
text-align: left;
border-radius: ${({ theme }) => theme.gridUnit * 1}px 0;
- margin: 0 ${({ theme }) => theme.gridUnit * 4}px;
.table {
table-layout: fixed;
}
.td {
width: 33%;
}
+ .entity-title {
+ font-family: Inter;
+ font-size: 14px;
+ font-weight: 500;
Review Comment:
```suggestion
font-size: ${({ theme }) => theme.typography.sizes.m}px;
font-weight: ${({ theme }) => theme.typography.weights.medium};
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org