You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jmeter-dev@jakarta.apache.org by bu...@apache.org on 2007/05/14 11:33:29 UTC

DO NOT REPLY [Bug 42405] New: - LdapExtSampler.sample use StringBuilder instead of String1 + String2

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42405>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42405

           Summary: LdapExtSampler.sample use StringBuilder instead of
                    String1 + String2
           Product: JMeter
           Version: unspecified
          Platform: All
        OS/Version: All
            Status: NEW
          Keywords: PatchAvailable
          Severity: enhancement
          Priority: P3
         Component: Main
        AssignedTo: jmeter-dev@jakarta.apache.org
        ReportedBy: Fabian.Bieker@netzwert.ag


LdapExtSampler.sample(...) uses a lot of "String1" + "String2" to generate a
message for the SamplerResult's responseData.
Imho using a StringBuilder is faster and less memory intensive.

I wrote a patch to make LdapExtSampler.sample(...) use a StringBuilder.
Running JMeter in a profiler shows that the patched LdapExtSampler performs
better. The performance increase is not that big, but I think it is worth it.

The functionalty of the sampler is not changed, imho.

The patch is against revision 537585 of the jmeter svn trunk. If there is a
problem with the patch or the patch format feel free to contact me.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org

DO NOT REPLY [Bug 42405] - LdapExtSampler.sample use StringBuilder instead of String1 + String2

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42405>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42405





------- Additional Comments From sebb@apache.org  2007-06-05 04:17 -------
Done

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org

DO NOT REPLY [Bug 42405] - LdapExtSampler.sample use StringBuilder instead of String1 + String2

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42405>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42405





------- Additional Comments From Fabian.Bieker@netzwert.ag  2007-05-14 07:20 -------
No Problem, did not spend much time to create the patch...

But maybe you should update http://jakarta.apache.org/site/cvsindex.html
wich points to http://svn.apache.org/repos/asf/jakarta/jmeter/trunk/ .

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org

DO NOT REPLY [Bug 42405] - LdapExtSampler.sample use StringBuilder instead of String1 + String2

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42405>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42405





------- Additional Comments From Fabian.Bieker@netzwert.ag  2007-05-14 02:35 -------
Created an attachment (id=20189)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=20189&action=view)
makes LdapExtSampler.sample use a StringBuilder


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org

DO NOT REPLY [Bug 42405] - LdapExtSampler.sample use StringBuilder instead of String1 + String2

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42405>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42405


sebb@apache.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




------- Additional Comments From sebb@apache.org  2007-05-14 05:12 -------
Thanks, but I think this has already been addressed in the current code.

Note that JMeter trunk is rather old (and was not used to create the current 
version 2.2) - see the STATUS file.

Current development is taking place in the rel-2-2 branch.

Sorry if you have wasted any time on this.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org