[GitHub] [iotdb] HTHou commented on a change in pull request #3660: [IOTDB-1541] Change sequence of wal and memtable in insert

[GitBox <gi...@apache.org>]

HTHou commented on a change in pull request #3660:
URL: https://github.com/apache/iotdb/pull/3660#discussion_r680640440



##########
File path: server/src/main/java/org/apache/iotdb/db/engine/storagegroup/TsFileProcessor.java
##########
@@ -213,8 +213,6 @@ public void insert(InsertRowPlan insertRowPlan) throws WriteProcessException {
       checkMemCostAndAddToTspInfo(insertRowPlan);
     }
 
-    workMemTable.insert(insertRowPlan);
-
     if (IoTDBDescriptor.getInstance().getConfig().isEnableWal()) {
       try {
         getLogNode().write(insertRowPlan);

Review comment:
       Move the wal to the front of the memCost check?

##########
File path: server/src/main/java/org/apache/iotdb/db/engine/storagegroup/TsFileProcessor.java
##########
@@ -272,12 +272,12 @@ public void insertTablet(
       throw new WriteProcessException(e);
     }
     try {
-      workMemTable.insertTablet(insertTabletPlan, start, end);
       if (IoTDBDescriptor.getInstance().getConfig().isEnableWal()) {
         insertTabletPlan.setStart(start);
         insertTabletPlan.setEnd(end);
         getLogNode().write(insertTabletPlan);
       }
+      workMemTable.insertTablet(insertTabletPlan, start, end);

Review comment:
       Same as above




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org