You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/12/15 14:30:32 UTC
[GitHub] [cloudstack] GabrielBrascher opened a new issue #4545: Fail to change Service offering from local <> shared storage
GabrielBrascher opened a new issue #4545:
URL: https://github.com/apache/cloudstack/issues/4545
<!--
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release and master branch are affected too.
Always add information AFTER of these HTML comments, but no need to delete the comments.
-->
##### ISSUE TYPE
<!-- Pick one below and delete the rest -->
* Bug Report
##### COMPONENT NAME
<!--
Categorize the issue, e.g. API, VR, VPN, UI, etc.
-->
~~~
API
~~~
##### CLOUDSTACK VERSION
<!--
New line separated list of affected versions, commit ID for issues on master branch.
-->
~~~
it's there for a long time (+9 years)
~~~
##### CONFIGURATION
<!--
Information about the configuration if relevant, e.g. basic network, advanced networking, etc. N/A otherwise
-->
Cluster with local and shared storage pools
##### OS / ENVIRONMENT
<!--
Information about the environment if relevant, N/A otherwise
-->
##### SUMMARY
Migrated a volume from local to shared storage pool; however, it fails to scale the offering from local to shared.
Error: "Unable to upgrade virtual machine VM [User|i-2-345-VM], cannot switch between local storage and shared storage service offerings. Current offering useLocalStorage=true, target offering useLocalStorage=false"
Caused due to code at: https://github.com/apache/cloudstack/blob/58a0a7b1a3408240757279a95543ce6304cd2a62/engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java#L3647
~~~
// Check that the service offering being upgraded to has the same storage pool preference as the VM's current service
// offering
if (currentServiceOffering.isUseLocalStorage() != newServiceOffering.isUseLocalStorage()) {
throw new InvalidParameterValueException("Unable to upgrade virtual machine " + vmInstance.toString() +
", cannot switch between local storage and shared storage service offerings. Current offering " + "useLocalStorage=" +
currentServiceOffering.isUseLocalStorage() + ", target offering useLocalStorage=" + newServiceOffering.isUseLocalStorage());
}
~~~
##### STEPS TO REPRODUCE
<!--
For bugs, show exactly how to reproduce the problem, using a minimal test-case. Use Screenshots if accurate.
For new features, show how the feature would be used.
-->
<!-- Paste example playbooks or commands between quotes below -->
~~~
1. Stop VM
2. Migrate VM's volume from local to shared primary storage
3. Update service offering
4. Start VM
~~~
<!-- You can also paste gist.github.com links for larger files -->
##### EXPECTED RESULTS
<!-- What did you expect to happen when running the steps above? -->
~~~
VM gets migrated from local to shared storage
~~~
##### ACTUAL RESULTS
<!-- What actually happened? -->
<!-- Paste verbatim command output between quotes below -->
~~~
Fail to update service offering from local to shared storage; therefore, it fails to start the VM with the migrated volume
~~~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on issue #4545: Fail to change Service offering from local <> shared storage
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #4545:
URL: https://github.com/apache/cloudstack/issues/4545#issuecomment-770833588
@GabrielBrascher by the looks of the line in your description this is very intentional. Do you plane to propose to change it?
And do you want to implement the possibility two way?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on issue #4545: Fail to change Service offering from local <> shared storage
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on issue #4545:
URL: https://github.com/apache/cloudstack/issues/4545#issuecomment-816431978
@DaanHoogland I think that the validation was intentional indeed, but it does not consider that it is possible to migrate Volumes between local <> shared storage pools.
The conditional checks the previous offering, which works really well if the volume has not been migrated; however, if the volume has been moved to a storage pool with different scope (e.g. HOST or Cluster) than the offering (e.g. local or shared) then this can be a problem.
To bring some context, here is an example.
1. for now, it is possible to migrate a VM's Root disk from a shared storage pool to local storage;
2. however, it is not possible to upgrade its offering to an offering that matches the new storage pool that fits the new pool because the validation offering upgrade command does not allow to do it so.
In my opinion, there should not exist such a limitation as the migration is perfectly doable; and also very necessary in some cases while managing Volumes across storage pools for maintenance or other purposes.
For now, the only way of doing it without a fix is by changing the Volume and VM's offerings on DB.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland edited a comment on issue #4545: Fail to change Service offering from local <> shared storage
Posted by GitBox <gi...@apache.org>.
DaanHoogland edited a comment on issue #4545:
URL: https://github.com/apache/cloudstack/issues/4545#issuecomment-770833588
@GabrielBrascher by the looks of the line in your description this is very intentional. Do you plan to propose to change it?
And do you want to implement the possibility two way?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on issue #4545: Fail to change Service offering from local <> shared storage
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #4545:
URL: https://github.com/apache/cloudstack/issues/4545#issuecomment-829873301
Fixed in https://github.com/apache/cloudstack/pull/4915
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on issue #4545: Fail to change Service offering from local <> shared storage
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on issue #4545:
URL: https://github.com/apache/cloudstack/issues/4545#issuecomment-817892690
Update: working to fix this issue via PR #4915
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd closed issue #4545: Fail to change Service offering from local <> shared storage
Posted by GitBox <gi...@apache.org>.
rhtyd closed issue #4545:
URL: https://github.com/apache/cloudstack/issues/4545
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] aleskxyz commented on issue #4545: Fail to change Service offering from local <> shared storage
Posted by GitBox <gi...@apache.org>.
aleskxyz commented on issue #4545:
URL: https://github.com/apache/cloudstack/issues/4545#issuecomment-746367604
@GabrielBrascher
Is it possible to extend this issue to changing disk offering for different tags?
For example I want to migrate a disk from HDD to SSD.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on issue #4545: Fail to change Service offering from local <> shared storage
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on issue #4545:
URL: https://github.com/apache/cloudstack/issues/4545#issuecomment-746419200
@aleskxyz I think that PR https://github.com/apache/cloudstack/pull/4283 already does what you are looking for.
Initially, PR https://github.com/apache/cloudstack/pull/2636 (Merged) had it implemented but later this was changed; PR #4283 (Open) proposes a code to get that functionality back.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org