You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Raghu Angadi (JIRA)" <ji...@apache.org> on 2009/05/14 20:58:45 UTC
[jira] Created: (HADOOP-5838) Remove a few javac warnings under
hdfs
Remove a few javac warnings under hdfs
--------------------------------------
Key: HADOOP-5838
URL: https://issues.apache.org/jira/browse/HADOOP-5838
Project: Hadoop Core
Issue Type: Improvement
Components: dfs
Reporter: Raghu Angadi
Assignee: Raghu Angadi
Fix For: 0.21.0
Fix a few javac warnings under hdfs.
I will list the files affected in jira i the following comment.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HADOOP-5838) Remove a few javac warnings under
hdfs
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Raghu Angadi resolved HADOOP-5838.
----------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
I just committed this.
> Remove a few javac warnings under hdfs
> --------------------------------------
>
> Key: HADOOP-5838
> URL: https://issues.apache.org/jira/browse/HADOOP-5838
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Raghu Angadi
> Assignee: Raghu Angadi
> Fix For: 0.21.0
>
> Attachments: HADOOP-5838.patch, HADOOP-5838.patch
>
>
> Fix a few javac warnings under hdfs.
> I will list the files affected in jira i the following comment.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5838) Remove a few javac warnings under
hdfs
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709647#action_12709647 ]
Jakob Homan commented on HADOOP-5838:
-------------------------------------
Looks good. On line 104, can we get rid of the assert statement and just use the newly thrown exception?
Amazingly tiny nit: DeprecatedUTF8 has a couple misspellings in comment (in stead => instead, SupressWarning => SuppressWarning).
Other than that, +1.
> Remove a few javac warnings under hdfs
> --------------------------------------
>
> Key: HADOOP-5838
> URL: https://issues.apache.org/jira/browse/HADOOP-5838
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Raghu Angadi
> Assignee: Raghu Angadi
> Fix For: 0.21.0
>
> Attachments: HADOOP-5838.patch
>
>
> Fix a few javac warnings under hdfs.
> I will list the files affected in jira i the following comment.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5838) Remove a few javac warnings under
hdfs
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Raghu Angadi updated HADOOP-5838:
---------------------------------
Attachment: HADOOP-5838.patch
Thanks Jakob. Updated patch has the suggested changes. Both are good changes.
> Remove a few javac warnings under hdfs
> --------------------------------------
>
> Key: HADOOP-5838
> URL: https://issues.apache.org/jira/browse/HADOOP-5838
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Raghu Angadi
> Assignee: Raghu Angadi
> Fix For: 0.21.0
>
> Attachments: HADOOP-5838.patch, HADOOP-5838.patch
>
>
> Fix a few javac warnings under hdfs.
> I will list the files affected in jira i the following comment.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5838) Remove a few javac warnings under
hdfs
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709891#action_12709891 ]
Raghu Angadi commented on HADOOP-5838:
--------------------------------------
ant test-patch :
{noformat}
[exec]
[exec] +1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 3 new or modified tests.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
[exec]
[exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
[exec]
{noformat}
> Remove a few javac warnings under hdfs
> --------------------------------------
>
> Key: HADOOP-5838
> URL: https://issues.apache.org/jira/browse/HADOOP-5838
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Raghu Angadi
> Assignee: Raghu Angadi
> Fix For: 0.21.0
>
> Attachments: HADOOP-5838.patch, HADOOP-5838.patch
>
>
> Fix a few javac warnings under hdfs.
> I will list the files affected in jira i the following comment.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5838) Remove a few javac warnings under
hdfs
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Raghu Angadi updated HADOOP-5838:
---------------------------------
Attachment: HADOOP-5838.patch
File fixed :
* protocol/DatanodeID.java
* protocol/NamespaceInfo.java
* namenode/FSImage.java
* namenode/DatanodeDescriptor.java
* namenode/TransferFsImage.java
* DistributedFileSystem.java
* protocol/AlreadyBeingCreatedException.java
* balancer/Balancer.java
* protocol/NamespaceInfo.java
* common/Storage.java
* namenode/TestCheckpoint.java
* DeprecatedUTF8.java
* DFSUtil.java
Most of the changes are trivial. Notable ones are :
* Moved {{ErrorSimulator}} from deprecated {{SecondaryNamenode }}to {{DFSUtil}}
* Added two wrappers in DeprecatedUTF8.java for the most commonly used methods. This is not required for javac, but ecplipse is more happier with them.
> Remove a few javac warnings under hdfs
> --------------------------------------
>
> Key: HADOOP-5838
> URL: https://issues.apache.org/jira/browse/HADOOP-5838
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Raghu Angadi
> Assignee: Raghu Angadi
> Fix For: 0.21.0
>
> Attachments: HADOOP-5838.patch
>
>
> Fix a few javac warnings under hdfs.
> I will list the files affected in jira i the following comment.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5838) Remove a few javac warnings under
hdfs
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709557#action_12709557 ]
Jakob Homan commented on HADOOP-5838:
-------------------------------------
Nice. I'll review it shortly.
> Remove a few javac warnings under hdfs
> --------------------------------------
>
> Key: HADOOP-5838
> URL: https://issues.apache.org/jira/browse/HADOOP-5838
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Raghu Angadi
> Assignee: Raghu Angadi
> Fix For: 0.21.0
>
> Attachments: HADOOP-5838.patch
>
>
> Fix a few javac warnings under hdfs.
> I will list the files affected in jira i the following comment.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.