[jira] [Commented] (FLINK-7647) Port JobManagerConfigHandler to new REST endpoint

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-7647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173526#comment-16173526 ] 

ASF GitHub Bot commented on FLINK-7647:
---------------------------------------

GitHub user tzulitai opened a pull request:

    https://github.com/apache/flink/pull/4691

    [FLINK-7647] [flip6] Port JobManagerConfigHandler to new REST endpoint

    ## What is the purpose of the change
    
    This PR ports the existing `JobManagerConfigHandler` to the new REST endpoint. This includes introducing the `ClusterConfiguration` response and `ClusterConfigurationHeaders`. The `DispatcherRestEndpoint` now registers the `JobManagerConfigHandler`.
    
    Additionally, this PR also contains other cosmetic changes, such as properly renaming the `JobManagerConfigHandler` to `ClusterConfigHandler`, and refactoring common test logic for marshalling / unmarshalling of REST responses.
    
    ## Brief change log
    
    - Let `JobManagerConfigHandler` implement `LegacyRestEHandler`
    - Register `JobManagerConfigHandler` at `DispatcherRestEndpoint`
    - Rename `JobManagerConfigHandler` to `ClusterConfigHandler`
    - Introduce `RestResponseMarshallingTestBase`
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup.
    Only additional test is `ClusterConfigurationTest` for the marshalling of the `ClusterConfiguration`.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): no
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
      - The serializers: no
      - The runtime per-record code paths (performance sensitive): no
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: yes
    
    ## Documentation
    
      - Does this pull request introduce a new feature? no
      - If yes, how is the feature documented? not applicable
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tzulitai/flink portJobManagerConfigHandler

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4691.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4691
    
----
commit bcfdd1ed3f3b9d4cd29e694c65d30a6711ee9d58
Author: Till Rohrmann <tr...@apache.org>
Date:   2017-08-21T13:11:08Z

    [FLINK-7535] Port DashboardConfigHandler to new REST endpoint
    
    Lets DashboardConfigHandler implement the LegacyRestHandler. Moreover, this
    commit defines the appropriate DashboardConfigurationHeaders.
    
    The DispatcherRestEndpoint registers the DashboardConfigHandler.
    
    This closes #4604.

commit ade082fbb27419a8e1a18d0086be267a3721e598
Author: Tzu-Li (Gordon) Tai <tz...@apache.org>
Date:   2017-09-20T16:25:28Z

    [FLINK-7647] [flip6] Port JobManagerConfigHandler to new REST endpoint
    
    This commit lets the JobManagerConfigHandler implement the
    LegacyRestHandler interface in order to be ported to the new REST
    endpoint. This includes the introduction of ClusterConfiguration
    response body and ClusterConfigurationHeaders.
    
    The DispatcherRestEndpoint now also registers the
    JobManagerConfigHandler.

commit 890faba271194a49fe9e5efea81917b236fc3b0a
Author: Tzu-Li (Gordon) Tai <tz...@apache.org>
Date:   2017-09-20T16:51:27Z

    [FLINK-7647] [flip6] Rename JobManagerConfigHandler to ClusterConfigHandler
    
    The original naming wouldn't make sense for the FLIP-6 redesign, since
    we would have multiple per-job JobManagers for each cluster, which
    shares the same configuration.
    
    The REST path is still left untouched and not part of this commit, as
    that would involve more changes in flink-runtime-web.

commit 16902cc8775b03f79770a998873dc0786b73264f
Author: Tzu-Li (Gordon) Tai <tz...@apache.org>
Date:   2017-09-20T17:07:11Z

    [FLINK-7647] [flip6] Introduce test base for REST response marshalling
    
    Introduces a common test base that for all REST responses, a subclass
    should be implemented to verify that the response can be correctly
    marshalled and unmarshalled.

----


> Port JobManagerConfigHandler to new REST endpoint
> -------------------------------------------------
>
>                 Key: FLINK-7647
>                 URL: https://issues.apache.org/jira/browse/FLINK-7647
>             Project: Flink
>          Issue Type: Sub-task
>          Components: REST, Webfrontend
>            Reporter: Tzu-Li (Gordon) Tai
>            Assignee: Tzu-Li (Gordon) Tai
>              Labels: flip-6
>             Fix For: 1.4.0
>
>
> Port existing {{JobManagerConfigHandler}} to new REST endpoint



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)