You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/09/27 09:54:33 UTC
[GitHub] [iceberg] lvyanquan opened a new pull request, #5866: Doc: Update output of expire_snapshots procedure
lvyanquan opened a new pull request, #5866:
URL: https://github.com/apache/iceberg/pull/5866
https://github.com/apache/iceberg/pull/4629 is already merged, but the the document hasn't been update.
The execution output is inconsistent with the [documentation](https://iceberg.apache.org/docs/latest/spark-procedures/#output-4), which will lead to confuse, this pr will fix it.
```
CALL spark_catalog.system.expire_snapshots('test_table');
0 0 0 0 1
Time taken: 7.254 seconds, Fetched 1 row(s)
22/09/27 17:32:43 INFO SparkSQLCLIDriver: Time taken: 7.254 seconds, Fetched 1 row(s)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] ajantha-bhat commented on a diff in pull request #5866: Doc: Update output of expire_snapshots procedure
Posted by GitBox <gi...@apache.org>.
ajantha-bhat commented on code in PR #5866:
URL: https://github.com/apache/iceberg/pull/5866#discussion_r981089623
##########
docs/spark-procedures.md:
##########
@@ -214,6 +214,8 @@ If `older_than` and `retain_last` are omitted, the table's [expiration propertie
| Output Name | Type | Description |
| ------------|------|-------------|
| `deleted_data_files_count` | long | Number of data files deleted by this operation |
+| `deleted_position_delete_files_count` | long | Number of position delete data files deleted by this operation |
Review Comment:
```suggestion
| `deleted_position_delete_files_count` | long | Number of position delete files deleted by this operation |
```
##########
docs/spark-procedures.md:
##########
@@ -214,6 +214,8 @@ If `older_than` and `retain_last` are omitted, the table's [expiration propertie
| Output Name | Type | Description |
| ------------|------|-------------|
| `deleted_data_files_count` | long | Number of data files deleted by this operation |
+| `deleted_position_delete_files_count` | long | Number of position delete data files deleted by this operation |
+| `deleted_equality_delete_files_count` | long | Number of equality delete data files deleted by this operation |
Review Comment:
```suggestion
| `deleted_equality_delete_files_count` | long | Number of equality delete files deleted by this operation |
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] szehon-ho merged pull request #5866: Doc: Update output of expire_snapshots procedure
Posted by GitBox <gi...@apache.org>.
szehon-ho merged PR #5866:
URL: https://github.com/apache/iceberg/pull/5866
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] lvyanquan commented on a diff in pull request #5866: Doc: Update output of expire_snapshots procedure
Posted by GitBox <gi...@apache.org>.
lvyanquan commented on code in PR #5866:
URL: https://github.com/apache/iceberg/pull/5866#discussion_r981103909
##########
docs/spark-procedures.md:
##########
@@ -214,6 +214,8 @@ If `older_than` and `retain_last` are omitted, the table's [expiration propertie
| Output Name | Type | Description |
| ------------|------|-------------|
| `deleted_data_files_count` | long | Number of data files deleted by this operation |
+| `deleted_position_delete_files_count` | long | Number of position delete data files deleted by this operation |
+| `deleted_equality_delete_files_count` | long | Number of equality delete data files deleted by this operation |
Review Comment:
address it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] szehon-ho commented on pull request #5866: Doc: Update output of expire_snapshots procedure
Posted by GitBox <gi...@apache.org>.
szehon-ho commented on PR #5866:
URL: https://github.com/apache/iceberg/pull/5866#issuecomment-1259810312
Thanks @lvyanquan , and @ajantha-bhat for review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org