You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "shenyu0127 (via GitHub)" <gi...@apache.org> on 2023/06/16 22:38:59 UTC
[GitHub] [pinot] shenyu0127 opened a new pull request, #10940: Fix an integer overflow bug.
shenyu0127 opened a new pull request, #10940:
URL: https://github.com/apache/pinot/pull/10940
Currently the when the `_limit` is `Integer.MAX_VALUE`, the assertion will fail because of the integer overflow. This bug makes the `MultiStageEngineCustomTenantIntegrationTest` flaky.
Tested by rerunning a generated test which previously failed:
```
Error: org.apache.pinot.integration.tests.MultiStageEngineCustomTenantIntegrationTest.testGeneratedQueries Time elapsed: 41.272 s <<< FAILURE!
java.lang.AssertionError:
Caught exception while testing query!
Pinot query: SELECT "CRSDepTime" FROM mytable WHERE "LateAircraftDelay" BETWEEN 291 AND 372 OR "DestState" >= 'ME' GROUP BY "CRSDepTime" LIMIT 10000
H2 query: SELECT `CRSDepTime` FROM mytable WHERE `LateAircraftDelay` BETWEEN 291 AND 372 OR `DestState` >= 'ME' GROUP BY `CRSDepTime` LIMIT 10000
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter commented on pull request #10940: Fix an integer overflow bug.
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #10940:
URL: https://github.com/apache/pinot/pull/10940#issuecomment-1595471106
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/10940?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#10940](https://app.codecov.io/gh/apache/pinot/pull/10940?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (262bc03) into [master](https://app.codecov.io/gh/apache/pinot/commit/85bb1fab54d44e847195e35e3e0b117022985d36?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (85bb1fa) will **increase** coverage by `0.00%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #10940 +/- ##
=========================================
Coverage 0.11% 0.11%
=========================================
Files 2188 2134 -54
Lines 117754 115249 -2505
Branches 17791 17493 -298
=========================================
Hits 137 137
+ Misses 117597 115092 -2505
Partials 20 20
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1temurin17 | `?` | |
| integration1temurin20 | `?` | |
| integration2temurin11 | `?` | |
| integration2temurin17 | `?` | |
| integration2temurin20 | `?` | |
| unittests1temurin17 | `?` | |
| unittests1temurin20 | `?` | |
| unittests2temurin11 | `0.11% <0.00%> (ø)` | |
| unittests2temurin17 | `?` | |
| unittests2temurin20 | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/pinot/pull/10940?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...raw/BaseRawDoubleSingleColumnDistinctExecutor.java](https://app.codecov.io/gh/apache/pinot/pull/10940?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9kaXN0aW5jdC9yYXcvQmFzZVJhd0RvdWJsZVNpbmdsZUNvbHVtbkRpc3RpbmN0RXhlY3V0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../raw/BaseRawFloatSingleColumnDistinctExecutor.java](https://app.codecov.io/gh/apache/pinot/pull/10940?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9kaXN0aW5jdC9yYXcvQmFzZVJhd0Zsb2F0U2luZ2xlQ29sdW1uRGlzdGluY3RFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ct/raw/BaseRawIntSingleColumnDistinctExecutor.java](https://app.codecov.io/gh/apache/pinot/pull/10940?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9kaXN0aW5jdC9yYXcvQmFzZVJhd0ludFNpbmdsZUNvbHVtbkRpc3RpbmN0RXhlY3V0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...t/raw/BaseRawLongSingleColumnDistinctExecutor.java](https://app.codecov.io/gh/apache/pinot/pull/10940?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9kaXN0aW5jdC9yYXcvQmFzZVJhd0xvbmdTaW5nbGVDb2x1bW5EaXN0aW5jdEV4ZWN1dG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
... and [56 files with indirect coverage changes](https://app.codecov.io/gh/apache/pinot/pull/10940/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] walterddr commented on pull request #10940: Fix an integer overflow bug.
Posted by "walterddr (via GitHub)" <gi...@apache.org>.
walterddr commented on PR #10940:
URL: https://github.com/apache/pinot/pull/10940#issuecomment-1595408871
related to #10834
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang merged pull request #10940: Fix an integer overflow bug.
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang merged PR #10940:
URL: https://github.com/apache/pinot/pull/10940
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org