[GitHub] [netbeans] JaroslavTulach commented on pull request #2192: Netbeans project proxy configuration

[GitBox <gi...@apache.org>]

JaroslavTulach commented on pull request #2192:
URL: https://github.com/apache/netbeans/pull/2192#issuecomment-653391775


   > @JaroslavTulach Could we set the proxy configuration as an optional? 
   
   If I read correctly your changes, then running with `ant -Dproxy.host+port=manual` would disable the `configureproxy` task in `default.xml`, right?
   
   > a lot of requests to the apache infra when the build script tries to configure it in every submodule.
   
   The other idea would be to compute `configureproxy` only once per build. Maybe enhance `ConfigureProxy` task with a property:
   ```java
   public void skipWhenConfigured(boolean skip) {
   }
   ```
   which would check values of 
   ```
                   sysprops.get(ProxySetup.HTTP_PROXY_HOST);
                   sysprops.get(ProxySetup.HTTP_PROXY_PORT);
                   sysprops.get(ProxySetup.HTTPS_PROXY_HOST);
                   sysprops.get(ProxySetup.HTTPS_PROXY_PORT);
   ```
   and if one of them is set do nothing? The Ant XML would then be more simple and the proxy configuration would be done just once per JVM. 
   
   One more idea is to call `SetProxy` task directly from `ConfigureProxy` - at the end that's what we do: use `configureproxy` to set some properties and then call `setproxy`.
   
   The final idea: Once we get `configureproxy` working fine - maybe we should donate the changes to Ant's `SetProxy` task - I have a feeling many Ant users would welcome that...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists