[GitHub] [tvm] Lunderberg opened a new pull request, #15127: [LLVM] Remove the "ret_void" argument of AddFunction

["Lunderberg (via GitHub)" <gi...@apache.org>]

Lunderberg opened a new pull request, #15127:
URL: https://github.com/apache/tvm/pull/15127

   Prior to this commit, the `"ret_void"` argument needed to be explicitly provided to `CodeGenLLVM::AddFunction` and `CodeGenLLVM::DeclareFunction`.  If this was inconsistent with the `builtin::ret()` usage within the `PrimFunc`, this could cause the incorrect return type in the generated LLVM-IR, resulting in LLVM IR verification failures.
   
   This commit removes the `"ret_void"` argument, instead using the type annotation in `PrimFunc::ret_type`, removing this opportunity for inconsistency.
   
   This PR is intended to fix a ROCm regression reported in https://github.com/apache/tvm/pull/14901#issuecomment-1598863567.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tvm-bot commented on pull request #15127: [LLVM] Remove the "ret_void" argument of AddFunction

["tvm-bot (via GitHub)" <gi...@apache.org>]

tvm-bot commented on PR #15127:
URL: https://github.com/apache/tvm/pull/15127#issuecomment-1599152646

   <!---bot-comment-->
   
   Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
   
   <!--bot-comment-ccs-start-->
    * No users to tag found in teams: `llvm` <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
   
   <sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tqchen merged pull request #15127: [LLVM] Remove the "ret_void" argument of AddFunction

["tqchen (via GitHub)" <gi...@apache.org>]

tqchen merged PR #15127:
URL: https://github.com/apache/tvm/pull/15127


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org