You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/08/23 21:29:18 UTC

[GitHub] [airflow] potiuk commented on a diff in pull request #25802: Added a note about MySQLToS3Operator backward incompatible changes

potiuk commented on code in PR #25802:
URL: https://github.com/apache/airflow/pull/25802#discussion_r953125046


##########
RELEASE_NOTES.rst:
##########
@@ -502,6 +502,12 @@ Airflow 2.3.0 restores the original meaning to the parameter. If you set it to "
 can be embedded in an iframe (no header is added), but when you set it to "false" the header is added
 and Airflow cannot be embedded in an iframe.
 
+``MySQLToS3Operator`` argument `pd_csv_kwargs` has beed replaced with `pd_kwargs` (#20807)
+""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""
+
+Although the old one (``pd_csv_kwargs``) is still accepted but no longer taken into account. Considering
+``MySQLToS3Operator`` deprecation it is recommeded to switch to ``SqlToS3Operator``. Doing this keep in mind
+that ``index`` and ``header`` arguments should be moved into ``pd_kwargs`` dict.

Review Comment:
   @jbmeerkat - but if you have an idea where to update it, you are absolutely free to do so. You are the best person in the world to make such PR- because a) you just had this problem b) now you know c) you know where you would look for it d) you can write it in the way that other users like you would search for it. 
   
   So if you want to make a PR to add such a notice  you are most welcome. And it is super easy - just open the right page in the doc and click "Suggest a change on this page" and you will be able to edit it straight in the UI of GitHub. And you are most welcome to do it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org