You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by ka...@apache.org on 2015/03/25 15:53:53 UTC
cordova-lib git commit: CB-8737 Available platforms list includes
extraneous values
Repository: cordova-lib
Updated Branches:
refs/heads/master 379422cbf -> 6ba6db365
CB-8737 Available platforms list includes extraneous values
Using the latest sources, if you list available platforms the output includes
two extraneous values ('getPlatformProject' and 'PlatformProjectAdapter').
These are methods added to the platforms object. Fix is to make them non-
enumerable. The output looks like this:
$ cordova platform
Installed platforms: windows
Available platforms: PlatformProjectAdapter, amazon-fireos, android,
blackberry10, browser, firefoxos, getPlatformProject, windows8, wp8
GitGub: close 190
Project: http://git-wip-us.apache.org/repos/asf/cordova-lib/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-lib/commit/6ba6db36
Tree: http://git-wip-us.apache.org/repos/asf/cordova-lib/tree/6ba6db36
Diff: http://git-wip-us.apache.org/repos/asf/cordova-lib/diff/6ba6db36
Branch: refs/heads/master
Commit: 6ba6db3653b3feb3954205260abb0228f6642050
Parents: 379422c
Author: Tim Barham <ti...@microsoft.com>
Authored: Tue Mar 24 15:08:41 2015 +1000
Committer: Mark Koudritsky <ka...@gmail.com>
Committed: Wed Mar 25 10:47:12 2015 -0400
----------------------------------------------------------------------
cordova-lib/src/platforms/platforms.js | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cordova-lib/blob/6ba6db36/cordova-lib/src/platforms/platforms.js
----------------------------------------------------------------------
diff --git a/cordova-lib/src/platforms/platforms.js b/cordova-lib/src/platforms/platforms.js
index 95ed705..01bb7cf 100644
--- a/cordova-lib/src/platforms/platforms.js
+++ b/cordova-lib/src/platforms/platforms.js
@@ -102,5 +102,10 @@ function getPlatformProject(platform, platformRootDir) {
}
module.exports = platforms;
-module.exports.getPlatformProject = getPlatformProject;
-module.exports.PlatformProjectAdapter = PlatformProjectAdapter;
+
+// We don't want these methods to be enumerable on the platforms object, because we expect enumerable properties of the
+// platforms object to be platforms.
+Object.defineProperties(module.exports, {
+ 'getPlatformProject': {value: getPlatformProject, configurable: true, writable: true},
+ 'PlatformProjectAdapter': {value: PlatformProjectAdapter, configurable: true, writable: true}
+});
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org