You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Aman Sinha <as...@maprtech.com> on 2015/05/06 18:55:25 UTC

Review Request 33898: DRILL-2962: Scalar subquery related fixes

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33898/
-----------------------------------------------------------

Review request for drill and Jinfeng Ni.


Bugs: DRILL-2962
    https://issues.apache.org/jira/browse/DRILL-2962


Repository: drill-git


Description
-------

Enhance scalar check to recurse below single-input rels. 
Bump up Calcite version to 1.1.0-drill-r3. 
Enable TPCH q11 and remove the q11_1 version.
Add new test class for correlated subqueries (more tests will be added later).


Diffs
-----

  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinUtils.java 5ed5d27 
  exec/java-exec/src/test/java/org/apache/drill/TestCorrelation.java PRE-CREATION 
  exec/java-exec/src/test/java/org/apache/drill/TestTpchDistributed.java 5d2a1c6 
  exec/java-exec/src/test/resources/queries/tpch/11_1.sql 6eb08fe 
  pom.xml f0f4bc5 

Diff: https://reviews.apache.org/r/33898/diff/


Testing
-------

Unit tests.  Functional and TPCH-100 tests in progress.


Thanks,

Aman Sinha


Re: Review Request 33898: DRILL-2962: Scalar subquery related fixes

Posted by Jinfeng Ni <jn...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33898/#review82696
-----------------------------------------------------------

Ship it!


Ship It!

- Jinfeng Ni


On May 6, 2015, 9:55 a.m., Aman Sinha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33898/
> -----------------------------------------------------------
> 
> (Updated May 6, 2015, 9:55 a.m.)
> 
> 
> Review request for drill and Jinfeng Ni.
> 
> 
> Bugs: DRILL-2962
>     https://issues.apache.org/jira/browse/DRILL-2962
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> Enhance scalar check to recurse below single-input rels. 
> Bump up Calcite version to 1.1.0-drill-r3. 
> Enable TPCH q11 and remove the q11_1 version.
> Add new test class for correlated subqueries (more tests will be added later).
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinUtils.java 5ed5d27 
>   exec/java-exec/src/test/java/org/apache/drill/TestCorrelation.java PRE-CREATION 
>   exec/java-exec/src/test/java/org/apache/drill/TestTpchDistributed.java 5d2a1c6 
>   exec/java-exec/src/test/resources/queries/tpch/11_1.sql 6eb08fe 
>   pom.xml f0f4bc5 
> 
> Diff: https://reviews.apache.org/r/33898/diff/
> 
> 
> Testing
> -------
> 
> Unit tests.  Functional and TPCH-100 tests in progress.
> 
> 
> Thanks,
> 
> Aman Sinha
> 
>