[GitHub] [accumulo] ctubbsii commented on a change in pull request #1871: Updates shell scripts and logs to use manager

[GitBox <gi...@apache.org>]

ctubbsii commented on a change in pull request #1871:
URL: https://github.com/apache/accumulo/pull/1871#discussion_r561013853



##########
File path: assemble/bin/accumulo-cluster
##########
@@ -340,10 +340,16 @@ function main() {
   accumulo_cmd="${bin}/accumulo"
   SSH='ssh -qnf -o ConnectTimeout=2'
 
+  manager_file="managers"
+  if [ ! -f "$conf/$manager_file" -a -f "$conf/masters" ]; then

Review comment:
       Prefer bash double square brackets for consistency and to avoid use (or apparent use) of external process `/usr/bin/\[`.
   
   ```suggestion
     if [[ ! -f "$conf/$manager_file" -a -f "$conf/masters" ]]; then
   ```

##########
File path: assemble/bin/accumulo-service
##########
@@ -137,9 +138,15 @@ function main() {
     host=$(ip addr | grep 'state UP' -A2 | tail -n1 | awk '{print $2}' | cut -f1  -d'/')
   fi 
   service="$1"
+
+  if [[ $service == "master" ]]; then
+    echo "WARN : Use of master service name is deprecated, use manager instead."

Review comment:
       ```suggestion
       echo "WARN : Use of 'master' service name is deprecated; use 'manager' instead."
   ```

##########
File path: assemble/bin/accumulo-cluster
##########
@@ -340,10 +340,16 @@ function main() {
   accumulo_cmd="${bin}/accumulo"
   SSH='ssh -qnf -o ConnectTimeout=2'
 
+  manager_file="managers"
+  if [ ! -f "$conf/$manager_file" -a -f "$conf/masters" ]; then
+    echo "WARN : Use of masters files is deprecated.  Use managers files instead"

Review comment:
       ```suggestion
       echo "WARN : Use of 'masters' file is deprecated; use 'managers' file instead."
   ```

##########
File path: assemble/bin/accumulo-service
##########
@@ -25,7 +25,8 @@ Usage: accumulo-service <service> <command>
 Services:
   gc          Accumulo garbage collector
   monitor     Accumulo monitor
-  master      Accumulo master
+  manager     Accumulo manager
+  master      Accumulo master (Deprecated)

Review comment:
       This isn't related to your change, but: should this list be organized alphabetically? It's roughly, but not quite, alphabetical.

##########
File path: server/manager/src/main/java/org/apache/accumulo/master/ManagerExecutable.java
##########
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.accumulo.master;
+
+import org.apache.accumulo.start.spi.KeywordExecutable;
+
+import com.google.auto.service.AutoService;
+
+@AutoService(KeywordExecutable.class)
+public class ManagerExecutable implements KeywordExecutable {

Review comment:
       I would expect that `KeywordStartIT.testExpectedClasses` should be failing with this change, until it is added. I believe that's the only test that should be updated.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org