You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@allura.apache.org by Dave Brondsema <br...@users.sf.net> on 2014/01/06 21:57:54 UTC
[allura:tickets] #7027 Cache /nf/tool_icon_css better
---
** [tickets:#7027] Cache /nf/tool_icon_css better**
**Status:** open
**Labels:** performance
**Created:** Mon Jan 06, 2014 08:57 PM UTC by Dave Brondsema
**Last Updated:** Mon Jan 06, 2014 08:57 PM UTC
**Owner:** nobody
/nf/tool_icon_css is a dynamically created CSS file. It is currently cached via etag headers, but that means a request still goes to the server and it has to respond with a 304. So this is a lot of extra requests (on sf.net, ~35% of /nf/tool_icon_css requests are 304s)
We should set a future expires header, and then do cache-busting with a unique URL by appending `?{{config.build_key}}` (build_key is already used for this purpose for all our other static resources)
---
Sent from sourceforge.net because allura-dev@incubator.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #7027 Cache /nf/tool_icon_css better
Posted by Tim Van Steenburgh <va...@users.sf.net>.
- **Milestone**: forge-backlog --> forge-jul-11
---
** [tickets:#7027] Cache /nf/tool_icon_css better**
**Status:** code-review
**Milestone:** forge-jul-11
**Labels:** performance bitesize
**Created:** Mon Jan 06, 2014 08:57 PM UTC by Dave Brondsema
**Last Updated:** Sat Jun 28, 2014 07:53 PM UTC
**Owner:** Tim Van Steenburgh
/nf/tool_icon_css is a dynamically created CSS file. It is currently cached via etag headers, but that means a request still goes to the server and it has to respond with a 304. So this is a lot of extra requests (on sf.net, ~35% of /nf/tool_icon_css requests are 304s)
We should set a future expires header, and then do cache-busting with a unique URL by appending `?{{config.build_key}}` (build_key is already used for this purpose for all our other static resources)
---
Sent from sourceforge.net because dev@allura.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #7027 Cache /nf/tool_icon_css better
Posted by Tim Van Steenburgh <va...@users.sf.net>.
- **status**: open --> in-progress
- **assigned_to**: Tim Van Steenburgh
- **Size**: 1 --> 1
---
** [tickets:#7027] Cache /nf/tool_icon_css better**
**Status:** in-progress
**Milestone:** forge-backlog
**Labels:** performance bitesize
**Created:** Mon Jan 06, 2014 08:57 PM UTC by Dave Brondsema
**Last Updated:** Tue Jan 28, 2014 03:54 PM UTC
**Owner:** Tim Van Steenburgh
/nf/tool_icon_css is a dynamically created CSS file. It is currently cached via etag headers, but that means a request still goes to the server and it has to respond with a 304. So this is a lot of extra requests (on sf.net, ~35% of /nf/tool_icon_css requests are 304s)
We should set a future expires header, and then do cache-busting with a unique URL by appending `?{{config.build_key}}` (build_key is already used for this purpose for all our other static resources)
---
Sent from sourceforge.net because dev@allura.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #7027 Cache /nf/tool_icon_css better
Posted by Dave Brondsema <br...@users.sf.net>.
Updated key name. Also set it to a lower default value since it affects user & project icons, attachments, etc.
---
** [tickets:#7027] Cache /nf/tool_icon_css better**
**Status:** closed
**Milestone:** forge-jul-11
**Labels:** performance bitesize
**Created:** Mon Jan 06, 2014 08:57 PM UTC by Dave Brondsema
**Last Updated:** Thu Jul 10, 2014 03:49 PM UTC
**Owner:** Tim Van Steenburgh
/nf/tool_icon_css is a dynamically created CSS file. It is currently cached via etag headers, but that means a request still goes to the server and it has to respond with a 304. So this is a lot of extra requests (on sf.net, ~35% of /nf/tool_icon_css requests are 304s)
We should set a future expires header, and then do cache-busting with a unique URL by appending `?{{config.build_key}}` (build_key is already used for this purpose for all our other static resources)
---
Sent from sourceforge.net because dev@allura.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #7027 Cache /nf/tool_icon_css better
Posted by Dave Brondsema <br...@users.sf.net>.
- **status**: in-progress --> closed
- **QA**: Dave Brondsema
---
** [tickets:#7027] Cache /nf/tool_icon_css better**
**Status:** closed
**Milestone:** forge-jul-11
**Labels:** performance bitesize
**Created:** Mon Jan 06, 2014 08:57 PM UTC by Dave Brondsema
**Last Updated:** Thu Jul 10, 2014 03:12 PM UTC
**Owner:** Tim Van Steenburgh
/nf/tool_icon_css is a dynamically created CSS file. It is currently cached via etag headers, but that means a request still goes to the server and it has to respond with a 304. So this is a lot of extra requests (on sf.net, ~35% of /nf/tool_icon_css requests are 304s)
We should set a future expires header, and then do cache-busting with a unique URL by appending `?{{config.build_key}}` (build_key is already used for this purpose for all our other static resources)
---
Sent from sourceforge.net because dev@allura.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #7027 Cache /nf/tool_icon_css better
Posted by Tim Van Steenburgh <va...@users.sf.net>.
- **status**: in-progress --> code-review
---
** [tickets:#7027] Cache /nf/tool_icon_css better**
**Status:** code-review
**Milestone:** forge-backlog
**Labels:** performance bitesize
**Created:** Mon Jan 06, 2014 08:57 PM UTC by Dave Brondsema
**Last Updated:** Sat Jun 28, 2014 06:43 PM UTC
**Owner:** Tim Van Steenburgh
/nf/tool_icon_css is a dynamically created CSS file. It is currently cached via etag headers, but that means a request still goes to the server and it has to respond with a 304. So this is a lot of extra requests (on sf.net, ~35% of /nf/tool_icon_css requests are 304s)
We should set a future expires header, and then do cache-busting with a unique URL by appending `?{{config.build_key}}` (build_key is already used for this purpose for all our other static resources)
---
Sent from sourceforge.net because dev@allura.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #7027 Cache /nf/tool_icon_css better
Posted by Dave Brondsema <br...@users.sf.net>.
Nevermind, just saw your comment and looking at `serve_file()` I see the config is called "file**s**_expires_header_secs"
---
** [tickets:#7027] Cache /nf/tool_icon_css better**
**Status:** in-progress
**Milestone:** forge-jul-11
**Labels:** performance bitesize
**Created:** Mon Jan 06, 2014 08:57 PM UTC by Dave Brondsema
**Last Updated:** Thu Jul 10, 2014 03:10 PM UTC
**Owner:** Tim Van Steenburgh
/nf/tool_icon_css is a dynamically created CSS file. It is currently cached via etag headers, but that means a request still goes to the server and it has to respond with a 304. So this is a lot of extra requests (on sf.net, ~35% of /nf/tool_icon_css requests are 304s)
We should set a future expires header, and then do cache-busting with a unique URL by appending `?{{config.build_key}}` (build_key is already used for this purpose for all our other static resources)
---
Sent from sourceforge.net because dev@allura.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #7027 Cache /nf/tool_icon_css better
Posted by Dave Brondsema <br...@users.sf.net>.
- **status**: code-review --> in-progress
- **Comment**:
Is there some missing code related to the new `file_expires_header_secs` config? I'm not seeing anything that uses that to set the `Expires` value header further out.
---
** [tickets:#7027] Cache /nf/tool_icon_css better**
**Status:** in-progress
**Milestone:** forge-jul-11
**Labels:** performance bitesize
**Created:** Mon Jan 06, 2014 08:57 PM UTC by Dave Brondsema
**Last Updated:** Sun Jun 29, 2014 02:59 AM UTC
**Owner:** Tim Van Steenburgh
/nf/tool_icon_css is a dynamically created CSS file. It is currently cached via etag headers, but that means a request still goes to the server and it has to respond with a 304. So this is a lot of extra requests (on sf.net, ~35% of /nf/tool_icon_css requests are 304s)
We should set a future expires header, and then do cache-busting with a unique URL by appending `?{{config.build_key}}` (build_key is already used for this purpose for all our other static resources)
---
Sent from sourceforge.net because dev@allura.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.