You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "bryancall (via GitHub)" <gi...@apache.org> on 2023/11/22 17:39:50 UTC
[PR] Coverity 1497421: Uninitialized scalar variable in ESI plugin [trafficserver]
bryancall opened a new pull request, #10834:
URL: https://github.com/apache/trafficserver/pull/10834
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Coverity 1497421: Uninitialized scalar variable in ESI plugin [trafficserver]
Posted by "bryancall (via GitHub)" <gi...@apache.org>.
bryancall commented on PR #10834:
URL: https://github.com/apache/trafficserver/pull/10834#issuecomment-1823692835
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Coverity 1497421: Uninitialized scalar variable in ESI plugin [trafficserver]
Posted by "masaori335 (via GitHub)" <gi...@apache.org>.
masaori335 commented on PR #10834:
URL: https://github.com/apache/trafficserver/pull/10834#issuecomment-1826995291
The esi AuTest is failing, is this related to this change?
```
Running Test esi:......E Exception
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Coverity 1497421: Uninitialized scalar variable in ESI plugin [trafficserver]
Posted by "masaori335 (via GitHub)" <gi...@apache.org>.
masaori335 commented on PR #10834:
URL: https://github.com/apache/trafficserver/pull/10834#issuecomment-1826995364
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Coverity 1497421: Uninitialized scalar variable in ESI plugin [trafficserver]
Posted by "serrislew (via GitHub)" <gi...@apache.org>.
serrislew commented on code in PR #10834:
URL: https://github.com/apache/trafficserver/pull/10834#discussion_r1406889231
##########
plugins/esi/common/gzip.cc:
##########
@@ -79,9 +79,12 @@ EsiLib::gzip(const ByteBlockList &blocks, std::string &cdata)
{
cdata.assign(GZIP_HEADER_SIZE, 0); // reserving space for the header
z_stream zstrm;
- zstrm.zalloc = Z_NULL;
- zstrm.zfree = Z_NULL;
- zstrm.opaque = Z_NULL;
+ zstrm.zalloc = Z_NULL;
+ zstrm.zfree = Z_NULL;
+ zstrm.opaque = Z_NULL;
+ zstrm.total_in = 0;
Review Comment:
should this be `zstrm.avail_in`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Coverity 1497421: Uninitialized scalar variable in ESI plugin [trafficserver]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10834:
URL: https://github.com/apache/trafficserver/pull/10834#issuecomment-1963179824
This pull request has been automatically marked as stale because it has not had recent activity. Marking it stale to flag it for further consideration by the community.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Coverity 1497421: Uninitialized scalar variable in ESI plugin [trafficserver]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #10834: Coverity 1497421: Uninitialized scalar variable in ESI plugin
URL: https://github.com/apache/trafficserver/pull/10834
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Coverity 1497421: Uninitialized scalar variable in ESI plugin [trafficserver]
Posted by "bryancall (via GitHub)" <gi...@apache.org>.
bryancall commented on PR #10834:
URL: https://github.com/apache/trafficserver/pull/10834#issuecomment-1823619079
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org