You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by khawkins <gi...@git.apache.org> on 2017/02/15 19:07:06 UTC

[GitHub] cordova-ios pull request #289: CB-12384 ios: Add Cocoa Touch Framework targe...

GitHub user khawkins opened a pull request:

    https://github.com/apache/cordova-ios/pull/289

    CB-12384 ios: Add Cocoa Touch Framework target for CordovaLib functionality

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    
    iOS
    
    ### What does this PR do?
    
    Adds a Cocoa Touch Framework target to the CordovaLib project, in anticipation of support for tools like Carthage (parent issue: [CB-12050](https://issues.apache.org/jira/browse/CB-12050)).
    
    ### What testing has been done on this change?
    
    In the cordova-ios Xcode workspace under tests/, An app target was added to consume the framework target as part of the unit testing process.  All tests are verified as passing in both targets.
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/khawkins/cordova-ios CB-12384

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-ios/pull/289.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #289
    
----

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-ios issue #289: CB-12384 ios: Add Cocoa Touch Framework target for C...

Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the issue:

    https://github.com/apache/cordova-ios/pull/289
  
    Thanks Kevin - this is a good building block anyways, in a bigger puzzle -- we'll punt that problem off for later. I'll pull this in after I get some time to review it further.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-ios issue #289: CB-12384 ios: Add Cocoa Touch Framework target for C...

Posted by khawkins <gi...@git.apache.org>.
Github user khawkins commented on the issue:

    https://github.com/apache/cordova-ios/pull/289
  
    @shazron Is this something you could take a look at, and/or mention anyone else who might be interested?  Cc: @sgoldberg-sfdc @bhariharan


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-ios issue #289: CB-12384 ios: Add Cocoa Touch Framework target for C...

Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the issue:

    https://github.com/apache/cordova-ios/pull/289
  
    Thanks @khawkins  - unfortunately when I pulled other PRs in, this has caused some conflicts. Can you rebase and resolve? Sorry about this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-ios pull request #289: CB-12384 ios: Add Cocoa Touch Framework targe...

Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on a diff in the pull request:

    https://github.com/apache/cordova-ios/pull/289#discussion_r104048113
  
    --- Diff: CordovaLib/CordovaLib.xcodeproj/project.pbxproj ---
    @@ -499,6 +637,105 @@
     			};
     			name = Release;
     		};
    +		C0C01EB71E3911D50056E6CB /* Debug */ = {
    +			isa = XCBuildConfiguration;
    +			buildSettings = {
    +				ALWAYS_SEARCH_USER_PATHS = NO;
    +				ARCHS = "$(ARCHS_STANDARD)";
    +				CLANG_ANALYZER_NONNULL = YES;
    +				CLANG_CXX_LANGUAGE_STANDARD = "gnu++0x";
    +				CLANG_CXX_LIBRARY = "libc++";
    +				CLANG_ENABLE_MODULES = YES;
    +				CLANG_ENABLE_OBJC_ARC = YES;
    +				CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR;
    +				CLANG_WARN_DOCUMENTATION_COMMENTS = YES;
    +				CLANG_WARN_INFINITE_RECURSION = YES;
    +				CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
    +				CLANG_WARN_SUSPICIOUS_MOVE = YES;
    +				CLANG_WARN_UNREACHABLE_CODE = YES;
    +				CODE_SIGN_IDENTITY = "";
    +				"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer";
    +				COPY_PHASE_STRIP = NO;
    +				CURRENT_PROJECT_VERSION = 1;
    +				DEBUG_INFORMATION_FORMAT = dwarf;
    +				DEFINES_MODULE = YES;
    +				DYLIB_COMPATIBILITY_VERSION = 1;
    +				DYLIB_CURRENT_VERSION = 1;
    +				DYLIB_INSTALL_NAME_BASE = "@rpath";
    +				ENABLE_STRICT_OBJC_MSGSEND = YES;
    +				GCC_C_LANGUAGE_STANDARD = gnu99;
    +				GCC_DYNAMIC_NO_PIC = NO;
    +				GCC_NO_COMMON_BLOCKS = YES;
    +				GCC_PREPROCESSOR_DEFINITIONS = (
    +					"DEBUG=1",
    +					"$(inherited)",
    +				);
    +				GCC_WARN_64_TO_32_BIT_CONVERSION = YES;
    +				GCC_WARN_ABOUT_RETURN_TYPE = YES_ERROR;
    +				GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
    +				INFOPLIST_FILE = Cordova/Info.plist;
    +				INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
    +				IPHONEOS_DEPLOYMENT_TARGET = 8.0;
    +				LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
    +				MTL_ENABLE_DEBUG_INFO = YES;
    +				OTHER_LDFLAGS = "-all_load";
    +				PRODUCT_BUNDLE_IDENTIFIER = com.apache.cordova.Cordova;
    +				PRODUCT_NAME = "$(TARGET_NAME)";
    +				PUBLIC_HEADERS_FOLDER_PATH = "$(CONTENTS_FOLDER_PATH)/Headers";
    +				SKIP_INSTALL = YES;
    +				VERSIONING_SYSTEM = "apple-generic";
    +				VERSION_INFO_PREFIX = "";
    +			};
    +			name = Debug;
    +		};
    +		C0C01EB81E3911D50056E6CB /* Release */ = {
    +			isa = XCBuildConfiguration;
    +			buildSettings = {
    +				ALWAYS_SEARCH_USER_PATHS = NO;
    +				ARCHS = "$(ARCHS_STANDARD)";
    +				CLANG_ANALYZER_NONNULL = YES;
    +				CLANG_CXX_LANGUAGE_STANDARD = "gnu++0x";
    +				CLANG_CXX_LIBRARY = "libc++";
    +				CLANG_ENABLE_MODULES = YES;
    +				CLANG_ENABLE_OBJC_ARC = YES;
    +				CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR;
    +				CLANG_WARN_DOCUMENTATION_COMMENTS = YES;
    +				CLANG_WARN_INFINITE_RECURSION = YES;
    +				CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
    +				CLANG_WARN_SUSPICIOUS_MOVE = YES;
    +				CLANG_WARN_UNREACHABLE_CODE = YES;
    +				CODE_SIGN_IDENTITY = "";
    +				"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer";
    +				COPY_PHASE_STRIP = NO;
    +				CURRENT_PROJECT_VERSION = 1;
    +				DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
    +				DEFINES_MODULE = YES;
    +				DYLIB_COMPATIBILITY_VERSION = 1;
    +				DYLIB_CURRENT_VERSION = 1;
    +				DYLIB_INSTALL_NAME_BASE = "@rpath";
    +				ENABLE_NS_ASSERTIONS = NO;
    +				ENABLE_STRICT_OBJC_MSGSEND = YES;
    +				GCC_C_LANGUAGE_STANDARD = gnu99;
    +				GCC_NO_COMMON_BLOCKS = YES;
    +				GCC_WARN_64_TO_32_BIT_CONVERSION = YES;
    +				GCC_WARN_ABOUT_RETURN_TYPE = YES_ERROR;
    +				GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
    +				INFOPLIST_FILE = Cordova/Info.plist;
    +				INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
    +				IPHONEOS_DEPLOYMENT_TARGET = 8.0;
    +				LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
    +				MTL_ENABLE_DEBUG_INFO = NO;
    +				OTHER_LDFLAGS = "-all_load";
    +				PRODUCT_BUNDLE_IDENTIFIER = com.apache.cordova.Cordova;
    --- End diff --
    
    use `org.apache.cordova.Cordova` instead


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-ios issue #289: CB-12384 ios: Add Cocoa Touch Framework target for C...

Posted by khawkins <gi...@git.apache.org>.
Github user khawkins commented on the issue:

    https://github.com/apache/cordova-ios/pull/289
  
    No worries @shazron !  Question: I see that 2a323fad2156a434e928eb570e7f272921b75d6a moved the iOS deployment target up to 9.0.  I presume I should amend the framework target to do the same?  It's currently set to 8.0 (before this change came in).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-ios pull request #289: CB-12384 ios: Add Cocoa Touch Framework targe...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cordova-ios/pull/289


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-ios issue #289: CB-12384 ios: Add Cocoa Touch Framework target for C...

Posted by khawkins <gi...@git.apache.org>.
Github user khawkins commented on the issue:

    https://github.com/apache/cordova-ios/pull/289
  
    Thanks for the review, @shazron .  I've made your suggested changes, and all tests are passing through `npm test`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-ios issue #289: CB-12384 ios: Add Cocoa Touch Framework target for C...

Posted by khawkins <gi...@git.apache.org>.
Github user khawkins commented on the issue:

    https://github.com/apache/cordova-ios/pull/289
  
    Okay @shazron , I've rebased and updated the deployment target of the framework to 9.0.  All tests are passing.  Let me know if you'd like me to squash these review commits down.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-ios issue #289: CB-12384 ios: Add Cocoa Touch Framework target for C...

Posted by khawkins <gi...@git.apache.org>.
Github user khawkins commented on the issue:

    https://github.com/apache/cordova-ios/pull/289
  
    You are correct: the support added here would only enable the consumption of the Cordova iOS dependency itself from Carthage, at this point.  Or maybe more accurately, it's the first step in enabling that support\u2014we haven't yet verified if Carthage support will have additional requirements.
    
    With regards to an "add Cordova plugins easily" requirement, it seems like the native side of those plugins would probably be best delivered through the dependency manager in play.  I.e. have a CocoaPods configuration for your plugin, or Carthage, or both.
    
    Seems like the challenge would come in with the non-native pieces of the plugin, such as JS, and configuration.  This could possibly be streamlined to a degree with post-install script(s) referenced in the Podfile, with CocoaPods.  But Carthage is pretty bare bones\u2014to my knowledge, it only supports the download and build of dependencies in a strictly Xcode-based paradigm.  Seems like that could be a lot more challenging to wrangle post-build configuration against the app that's installing the dependency.
    
    To me, it seems like it all points to needing an amended CLI that understands/interrogates the nuances of an existing app project/workspace, whereas the current CLI is very much about orchestrating that workspace itself.  But that of course has ramifications on other platforms, etc.  Anyway, just some thoughts out loud\u2014it's definitely a challenging problem to consider.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-ios pull request #289: CB-12384 ios: Add Cocoa Touch Framework targe...

Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on a diff in the pull request:

    https://github.com/apache/cordova-ios/pull/289#discussion_r104047971
  
    --- Diff: tests/CordovaLibTests/CordovaLibTests.xcodeproj/project.pbxproj ---
    @@ -39,8 +63,29 @@
     			remoteGlobalIDString = 303A4067152124BB00182201;
     			remoteInfo = CordovaLibApp;
     		};
    +		C0FA7CCC1E4BBD870077B045 /* PBXContainerItemProxy */ = {
    +			isa = PBXContainerItemProxy;
    +			containerPortal = 0867D690FE84028FC02AAC07 /* Project object */;
    +			proxyType = 1;
    +			remoteGlobalIDString = C0FA7C991E4BB6420077B045;
    +			remoteInfo = CordovaFrameworkApp;
    +		};
     /* End PBXContainerItemProxy section */
     
    +/* Begin PBXCopyFilesBuildPhase section */
    +		C0FA7CDE1E4BC5020077B045 /* Embed Frameworks */ = {
    +			isa = PBXCopyFilesBuildPhase;
    +			buildActionMask = 2147483647;
    +			dstPath = "";
    +			dstSubfolderSpec = 10;
    +			files = (
    +				C0FA7CDD1E4BC5020077B045 /* Cordova.framework in Embed Frameworks */,
    +			);
    +			name = "Embed Frameworks";
    +			runOnlyForDeploymentPostprocessing = 0;
    --- End diff --
    
    This value should be 1.
    This corresponds to the "Copy only when installing" checkbox in the Embed Frameworks section for the Cordova framework target in the CordovaLib project.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-ios issue #289: CB-12384 ios: Add Cocoa Touch Framework target for C...

Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the issue:

    https://github.com/apache/cordova-ios/pull/289
  
    Thanks @khawkins ! I'll let the CI run, then merge these in. No worries, I can squash on my end


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-ios issue #289: CB-12384 ios: Add Cocoa Touch Framework target for C...

Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the issue:

    https://github.com/apache/cordova-ios/pull/289
  
    This all seems sound (and seems parallel to any existing code) but I have a few clarifying questions:
    1) The current CocoaPods support is for integrating CocoaPods libraries into an existing Cordova project. This PR does *not* provide the same functionality, correct? - i.e. add support for integrating Carthage libraries into an existing Cordova project.
    2) I think the answer to question (1) is "Yes, it does not provide the same functionality" based on inspection of the code. So, if Cordova.framework is to be imported into an existing iOS app, how are you resolving the problem of adding Cordova plugins?
    
    I ask about (2) since we at Adobe are trying to get an `Embedded Cordova Webview` workflow (adding Cordova to an existing iOS app) as well: https://github.com/phonegap/phonegap-webview-ios but we haven't solved the "adding Cordova plugins easily" question yet -- we just add all the core plugins.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-ios pull request #289: CB-12384 ios: Add Cocoa Touch Framework targe...

Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on a diff in the pull request:

    https://github.com/apache/cordova-ios/pull/289#discussion_r104048130
  
    --- Diff: CordovaLib/CordovaLib.xcodeproj/project.pbxproj ---
    @@ -499,6 +637,105 @@
     			};
     			name = Release;
     		};
    +		C0C01EB71E3911D50056E6CB /* Debug */ = {
    +			isa = XCBuildConfiguration;
    +			buildSettings = {
    +				ALWAYS_SEARCH_USER_PATHS = NO;
    +				ARCHS = "$(ARCHS_STANDARD)";
    +				CLANG_ANALYZER_NONNULL = YES;
    +				CLANG_CXX_LANGUAGE_STANDARD = "gnu++0x";
    +				CLANG_CXX_LIBRARY = "libc++";
    +				CLANG_ENABLE_MODULES = YES;
    +				CLANG_ENABLE_OBJC_ARC = YES;
    +				CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR;
    +				CLANG_WARN_DOCUMENTATION_COMMENTS = YES;
    +				CLANG_WARN_INFINITE_RECURSION = YES;
    +				CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
    +				CLANG_WARN_SUSPICIOUS_MOVE = YES;
    +				CLANG_WARN_UNREACHABLE_CODE = YES;
    +				CODE_SIGN_IDENTITY = "";
    +				"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer";
    +				COPY_PHASE_STRIP = NO;
    +				CURRENT_PROJECT_VERSION = 1;
    +				DEBUG_INFORMATION_FORMAT = dwarf;
    +				DEFINES_MODULE = YES;
    +				DYLIB_COMPATIBILITY_VERSION = 1;
    +				DYLIB_CURRENT_VERSION = 1;
    +				DYLIB_INSTALL_NAME_BASE = "@rpath";
    +				ENABLE_STRICT_OBJC_MSGSEND = YES;
    +				GCC_C_LANGUAGE_STANDARD = gnu99;
    +				GCC_DYNAMIC_NO_PIC = NO;
    +				GCC_NO_COMMON_BLOCKS = YES;
    +				GCC_PREPROCESSOR_DEFINITIONS = (
    +					"DEBUG=1",
    +					"$(inherited)",
    +				);
    +				GCC_WARN_64_TO_32_BIT_CONVERSION = YES;
    +				GCC_WARN_ABOUT_RETURN_TYPE = YES_ERROR;
    +				GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
    +				INFOPLIST_FILE = Cordova/Info.plist;
    +				INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
    +				IPHONEOS_DEPLOYMENT_TARGET = 8.0;
    +				LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
    +				MTL_ENABLE_DEBUG_INFO = YES;
    +				OTHER_LDFLAGS = "-all_load";
    +				PRODUCT_BUNDLE_IDENTIFIER = com.apache.cordova.Cordova;
    --- End diff --
    
    use `org.apache.cordova.Cordova` instead


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-ios issue #289: CB-12384 ios: Add Cocoa Touch Framework target for C...

Posted by khawkins <gi...@git.apache.org>.
Github user khawkins commented on the issue:

    https://github.com/apache/cordova-ios/pull/289
  
    Actually, I end up seeing a ton of warnings now complaining about the fact that I didn't otherwise do that, so that probably answers my question. \U0001f609  I'll have the update pushed shortly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org