You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/01/23 03:40:26 UTC

[GitHub] [rocketmq] suntianji123 opened a new issue #2620: rocketmq4.5.2 ScheduleMessageService中有一个bug 比较消息到期时间和当前时间

suntianji123 opened a new issue #2620:
URL: https://github.com/apache/rocketmq/issues/2620


     /**
            * 正确的到期时间
            * @param now 当前时间
            * @param deliverTimestamp 延时消息的截止时间
            * @return
            */
           private long correctDeliverTimestamp(final long now, final long deliverTimestamp) {
               //延时消息的截止时间
               long result = deliverTimestamp;
   
               long maxTimestamp = now + ScheduleMessageService.this.delayLevelTable.get(this.delayLevel);
               if (deliverTimestamp > maxTimestamp) {//这里应该改为maxTimestamp > deliverTimestamp
                   result = now;
               }
   
               return result;
           }


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] RongtongJin commented on issue #2620: A question about Rocketmq4.5.2 ScheduleMessageService

Posted by GitBox <gi...@apache.org>.
RongtongJin commented on issue #2620:
URL: https://github.com/apache/rocketmq/issues/2620#issuecomment-768304625


   这应该不是一个bug，我认为deliverTimestamp > maxTimestamp是合理的


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] RongtongJin closed issue #2620: A question about Rocketmq4.5.2 ScheduleMessageService

Posted by GitBox <gi...@apache.org>.
RongtongJin closed issue #2620:
URL: https://github.com/apache/rocketmq/issues/2620


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org