You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "zy-kkk (via GitHub)" <gi...@apache.org> on 2025/11/25 09:46:26 UTC

[PR] [fix](test connection) Fix the check when only the bucket root directory is present. [doris]

zy-kkk opened a new pull request, #58359:
URL: https://github.com/apache/doris/pull/58359

   1. Add a virtual directory named `.connectivity_test` after the `warehouse` directory and within the bucket root directory for resolution purposes. This directory will not be actually created; it is only used for local resolution of bucket names.
   
   2. Convert `s3a://` and `s3n://` to `s3://`, which is recognizable by BE.
   
   3. Extract some common methods from Iceberg's warehouse processing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](test connection) Fix the check when only the bucket root directory is present. [doris]

Posted by "zy-kkk (via GitHub)" <gi...@apache.org>.
zy-kkk commented on PR #58359:
URL: https://github.com/apache/doris/pull/58359#issuecomment-3574725308

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](test connection) Fix the check when only the bucket root directory is present. [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #58359:
URL: https://github.com/apache/doris/pull/58359#issuecomment-3574868187

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 34073 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 874918306d894522eed592c65221a61a0b285be8, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17606	5097	4890	4890
   q2	2065	310	204	204
   q3	10268	1293	708	708
   q4	10232	907	382	382
   q5	7551	2295	2396	2295
   q6	184	166	138	138
   q7	923	794	637	637
   q8	9360	1320	1090	1090
   q9	6974	5248	5294	5248
   q10	6833	2224	1819	1819
   q11	490	302	290	290
   q12	338	360	231	231
   q13	17777	3672	3055	3055
   q14	230	244	221	221
   q15	579	517	504	504
   q16	1058	1024	958	958
   q17	577	870	370	370
   q18	7542	7177	6980	6980
   q19	1233	969	537	537
   q20	371	342	232	232
   q21	3645	3296	2322	2322
   q22	1022	1037	962	962
   Total cold run time: 106858 ms
   Total hot run time: 34073 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	4948	4958	4951	4951
   q2	329	409	338	338
   q3	2197	2680	2308	2308
   q4	1338	1751	1350	1350
   q5	4268	4422	4536	4422
   q6	229	175	128	128
   q7	2175	1973	1824	1824
   q8	2686	2559	2607	2559
   q9	7487	7435	7469	7435
   q10	3049	3222	2857	2857
   q11	591	513	519	513
   q12	701	780	617	617
   q13	3603	3889	3324	3324
   q14	305	299	276	276
   q15	550	519	522	519
   q16	1122	1169	1088	1088
   q17	1135	1559	1405	1405
   q18	8073	7685	7681	7681
   q19	819	835	910	835
   q20	1985	2126	1977	1977
   q21	5178	4360	4370	4360
   q22	1093	1059	1001	1001
   Total cold run time: 53861 ms
   Total hot run time: 51768 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](test connection) Fix the check when only the bucket root directory is present. [doris]

Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #58359:
URL: https://github.com/apache/doris/pull/58359#issuecomment-3574725061

   
   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
   
   Please clearly describe your PR:
   1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
   2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
   3. What features were added. Why was this function added?
   4. Which code was refactored and why was this part of the code refactored?
   5. Which functions were optimized and what is the difference before and after the optimization?
       


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](test connection) Fix the check when only the bucket root directory is present. [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #58359:
URL: https://github.com/apache/doris/pull/58359#issuecomment-3578605674

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](test connection) Fix the check when only the bucket root directory is present. [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #58359:
URL: https://github.com/apache/doris/pull/58359#issuecomment-3574925845

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 184505 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 874918306d894522eed592c65221a61a0b285be8, data reload: false
   
   query1	1029	423	401	401
   query2	6575	1602	1608	1602
   query3	6774	227	223	223
   query4	25797	22892	22930	22892
   query5	4916	635	489	489
   query6	358	256	260	256
   query7	4660	527	304	304
   query8	318	258	260	258
   query9	8681	2596	2571	2571
   query10	556	373	316	316
   query11	15100	15026	14602	14602
   query12	177	115	111	111
   query13	1685	575	454	454
   query14	10819	8918	8964	8918
   query15	214	204	188	188
   query16	7761	701	551	551
   query17	1224	770	651	651
   query18	2053	446	350	350
   query19	220	212	184	184
   query20	136	128	125	125
   query21	223	139	121	121
   query22	3888	4105	3887	3887
   query23	32971	32104	31835	31835
   query24	8599	2505	2422	2422
   query25	585	521	452	452
   query26	1228	276	161	161
   query27	2733	505	362	362
   query28	4461	2156	2144	2144
   query29	781	627	501	501
   query30	313	243	206	206
   query31	852	700	625	625
   query32	82	78	76	76
   query33	601	391	324	324
   query34	779	863	543	543
   query35	789	865	737	737
   query36	928	938	861	861
   query37	130	121	93	93
   query38	3302	3254	3305	3254
   query39	1507	1414	1413	1413
   query40	228	134	122	122
   query41	72	63	62	62
   query42	128	113	111	111
   query43	465	471	452	452
   query44	1249	753	755	753
   query45	202	189	186	186
   query46	893	1023	641	641
   query47	1698	1696	1637	1637
   query48	398	443	318	318
   query49	775	493	429	429
   query50	653	670	400	400
   query51	3898	3877	3869	3869
   query52	110	117	105	105
   query53	244	279	201	201
   query54	316	303	294	294
   query55	89	97	84	84
   query56	346	318	328	318
   query57	1145	1171	1091	1091
   query58	277	271	269	269
   query59	2514	2480	2493	2480
   query60	373	350	352	350
   query61	160	159	168	159
   query62	791	713	649	649
   query63	221	188	189	188
   query64	4408	1208	926	926
   query65	4108	3975	3983	3975
   query66	1104	451	334	334
   query67	15154	14943	14747	14747
   query68	8393	914	626	626
   query69	520	339	301	301
   query70	1314	1270	1144	1144
   query71	514	339	316	316
   query72	5848	4942	4979	4942
   query73	733	664	376	376
   query74	8779	9001	8635	8635
   query75	3943	3329	2818	2818
   query76	3805	1134	727	727
   query77	821	421	308	308
   query78	9584	9978	8788	8788
   query79	2396	835	606	606
   query80	687	586	506	506
   query81	520	268	250	250
   query82	221	161	127	127
   query83	268	271	256	256
   query84	264	119	102	102
   query85	894	499	455	455
   query86	389	306	295	295
   query87	3560	3528	3338	3338
   query88	3822	2245	2269	2245
   query89	394	328	303	303
   query90	1999	228	223	223
   query91	172	166	148	148
   query92	86	70	66	66
   query93	2198	993	657	657
   query94	693	436	345	345
   query95	505	418	397	397
   query96	508	579	280	280
   query97	2871	2982	2824	2824
   query98	249	210	210	210
   query99	1322	1412	1278	1278
   Total cold run time: 274096 ms
   Total hot run time: 184505 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](test connection) Fix the check when only the bucket root directory is present. [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #58359:
URL: https://github.com/apache/doris/pull/58359#issuecomment-3575473957

   # FE Regression Coverage Report
   Increment line coverage `  63.64% (7/11)` :tada:
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/58359_874918306d894522eed592c65221a61a0b285be8_merge_fe/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/58359_874918306d894522eed592c65221a61a0b285be8_merge_fe/report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](test connection) Fix the check when only the bucket root directory is present. [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #58359:
URL: https://github.com/apache/doris/pull/58359#issuecomment-3574947604

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 27.37 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 874918306d894522eed592c65221a61a0b285be8, data reload: false
   
   query1	0.05	0.06	0.05
   query2	0.09	0.05	0.05
   query3	0.26	0.07	0.09
   query4	1.61	0.11	0.10
   query5	0.27	0.25	0.25
   query6	1.18	0.66	0.63
   query7	0.03	0.02	0.02
   query8	0.06	0.04	0.04
   query9	0.59	0.52	0.52
   query10	0.58	0.57	0.57
   query11	0.15	0.11	0.12
   query12	0.15	0.12	0.11
   query13	0.63	0.61	0.60
   query14	1.01	1.02	1.00
   query15	0.85	0.82	0.84
   query16	0.38	0.39	0.41
   query17	0.99	1.06	1.00
   query18	0.22	0.20	0.19
   query19	1.94	1.78	1.84
   query20	0.02	0.02	0.02
   query21	15.49	0.19	0.12
   query22	5.04	0.07	0.05
   query23	15.66	0.25	0.10
   query24	2.74	0.71	0.34
   query25	0.07	0.06	0.07
   query26	0.14	0.13	0.14
   query27	0.07	0.06	0.05
   query28	3.40	1.16	0.94
   query29	12.54	4.00	3.30
   query30	0.28	0.13	0.12
   query31	2.83	0.59	0.39
   query32	3.23	0.57	0.47
   query33	3.01	3.08	3.08
   query34	15.81	5.16	4.53
   query35	4.58	4.52	4.63
   query36	0.67	0.50	0.48
   query37	0.10	0.06	0.06
   query38	0.06	0.05	0.04
   query39	0.04	0.03	0.04
   query40	0.18	0.15	0.14
   query41	0.09	0.03	0.04
   query42	0.04	0.04	0.03
   query43	0.05	0.04	0.04
   Total cold run time: 97.18 s
   Total hot run time: 27.37 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](test connection) Fix the check when only the bucket root directory is present. [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #58359:
URL: https://github.com/apache/doris/pull/58359#issuecomment-3578605878

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](test connection) Fix the check when only the bucket root directory is present. [doris]

Posted by "zy-kkk (via GitHub)" <gi...@apache.org>.
zy-kkk merged PR #58359:
URL: https://github.com/apache/doris/pull/58359


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org