You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "lohit vijayarenu (JIRA)" <ji...@apache.org> on 2008/05/16 21:39:55 UTC

[jira] Created: (HADOOP-3408) Change FSNamesytem status metrics to IntValue

Change FSNamesytem status metrics to IntValue
---------------------------------------------

                 Key: HADOOP-3408
                 URL: https://issues.apache.org/jira/browse/HADOOP-3408
             Project: Hadoop Core
          Issue Type: Bug
          Components: metrics
    Affects Versions: 0.18.0
         Environment: Seen while working with Simon
            Reporter: lohit vijayarenu


HADOOP-3058 introduced new FSNamesystem status metrics. Most of them were LongValue, but there might be cases where LongValues are not properly  handled by metrics collectors. For now, we should change it to IntValue.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-3408) Change FSNamesytem status metrics to IntValue

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12598766#action_12598766 ] 

Hadoop QA commented on HADOOP-3408:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12382346/HADOOP-3408-1.patch
  against trunk revision 658704.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2508/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2508/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2508/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2508/console

This message is automatically generated.

> Change FSNamesytem status metrics to IntValue
> ---------------------------------------------
>
>                 Key: HADOOP-3408
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3408
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: metrics
>    Affects Versions: 0.18.0
>         Environment: Seen while working with Simon
>            Reporter: lohit vijayarenu
>            Assignee: lohit vijayarenu
>             Fix For: 0.18.0
>
>         Attachments: HADOOP-3408-1.patch
>
>
> HADOOP-3058 introduced new FSNamesystem status metrics. Most of them were LongValue, but there might be cases where LongValues are not properly  handled by metrics collectors. For now, we should change it to IntValue.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3408) Change FSNamesytem status metrics to IntValue

Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Douglas updated HADOOP-3408:
----------------------------------

      Resolution: Fixed
    Hadoop Flags: [Reviewed]
          Status: Resolved  (was: Patch Available)

I just committed this. Thanks, Lohit

> Change FSNamesytem status metrics to IntValue
> ---------------------------------------------
>
>                 Key: HADOOP-3408
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3408
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: metrics
>    Affects Versions: 0.18.0
>         Environment: Seen while working with Simon
>            Reporter: lohit vijayarenu
>            Assignee: lohit vijayarenu
>             Fix For: 0.18.0
>
>         Attachments: HADOOP-3408-1.patch
>
>
> HADOOP-3058 introduced new FSNamesystem status metrics. Most of them were LongValue, but there might be cases where LongValues are not properly  handled by metrics collectors. For now, we should change it to IntValue.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-3408) Change FSNamesytem status metrics to IntValue

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12599000#action_12599000 ] 

Hudson commented on HADOOP-3408:
--------------------------------

Integrated in Hadoop-trunk #499 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/499/])

> Change FSNamesytem status metrics to IntValue
> ---------------------------------------------
>
>                 Key: HADOOP-3408
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3408
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: metrics
>    Affects Versions: 0.18.0
>         Environment: Seen while working with Simon
>            Reporter: lohit vijayarenu
>            Assignee: lohit vijayarenu
>             Fix For: 0.18.0
>
>         Attachments: HADOOP-3408-1.patch
>
>
> HADOOP-3058 introduced new FSNamesystem status metrics. Most of them were LongValue, but there might be cases where LongValues are not properly  handled by metrics collectors. For now, we should change it to IntValue.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3408) Change FSNamesytem status metrics to IntValue

Posted by "lohit vijayarenu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

lohit vijayarenu updated HADOOP-3408:
-------------------------------------

    Attachment: HADOOP-3408-1.patch

Attached patch uses IntValue instead of LongValue. Changes DFS capacity to convert it to GB to fit in Int. This changes only metrics, JMX and jsp pages remain same. 

> Change FSNamesytem status metrics to IntValue
> ---------------------------------------------
>
>                 Key: HADOOP-3408
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3408
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: metrics
>    Affects Versions: 0.18.0
>         Environment: Seen while working with Simon
>            Reporter: lohit vijayarenu
>         Attachments: HADOOP-3408-1.patch
>
>
> HADOOP-3058 introduced new FSNamesystem status metrics. Most of them were LongValue, but there might be cases where LongValues are not properly  handled by metrics collectors. For now, we should change it to IntValue.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HADOOP-3408) Change FSNamesytem status metrics to IntValue

Posted by "lohit vijayarenu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

lohit vijayarenu reassigned HADOOP-3408:
----------------------------------------

    Assignee: lohit vijayarenu

> Change FSNamesytem status metrics to IntValue
> ---------------------------------------------
>
>                 Key: HADOOP-3408
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3408
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: metrics
>    Affects Versions: 0.18.0
>         Environment: Seen while working with Simon
>            Reporter: lohit vijayarenu
>            Assignee: lohit vijayarenu
>             Fix For: 0.18.0
>
>         Attachments: HADOOP-3408-1.patch
>
>
> HADOOP-3058 introduced new FSNamesystem status metrics. Most of them were LongValue, but there might be cases where LongValues are not properly  handled by metrics collectors. For now, we should change it to IntValue.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3408) Change FSNamesytem status metrics to IntValue

Posted by "lohit vijayarenu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

lohit vijayarenu updated HADOOP-3408:
-------------------------------------

    Fix Version/s: 0.18.0
           Status: Patch Available  (was: Open)

Tested with Simon to make sure we get the metrics as expected.

> Change FSNamesytem status metrics to IntValue
> ---------------------------------------------
>
>                 Key: HADOOP-3408
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3408
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: metrics
>    Affects Versions: 0.18.0
>         Environment: Seen while working with Simon
>            Reporter: lohit vijayarenu
>             Fix For: 0.18.0
>
>         Attachments: HADOOP-3408-1.patch
>
>
> HADOOP-3058 introduced new FSNamesystem status metrics. Most of them were LongValue, but there might be cases where LongValues are not properly  handled by metrics collectors. For now, we should change it to IntValue.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (HADOOP-3408) Change FSNamesytem status metrics to IntValue

Posted by "lohit vijayarenu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12598176#action_12598176 ] 

lohit edited comment on HADOOP-3408 at 5/19/08 10:16 PM:
--------------------------------------------------------------------

Thanks to Eric Yang, who tested with Simon to make sure we get the metrics as expected.

      was (Author: lohit):
    Tested with Simon to make sure we get the metrics as expected.
  
> Change FSNamesytem status metrics to IntValue
> ---------------------------------------------
>
>                 Key: HADOOP-3408
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3408
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: metrics
>    Affects Versions: 0.18.0
>         Environment: Seen while working with Simon
>            Reporter: lohit vijayarenu
>             Fix For: 0.18.0
>
>         Attachments: HADOOP-3408-1.patch
>
>
> HADOOP-3058 introduced new FSNamesystem status metrics. Most of them were LongValue, but there might be cases where LongValues are not properly  handled by metrics collectors. For now, we should change it to IntValue.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-3408) Change FSNamesytem status metrics to IntValue

Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12598497#action_12598497 ] 

Raghu Angadi commented on HADOOP-3408:
--------------------------------------

+1. Looks fine.

> Change FSNamesytem status metrics to IntValue
> ---------------------------------------------
>
>                 Key: HADOOP-3408
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3408
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: metrics
>    Affects Versions: 0.18.0
>         Environment: Seen while working with Simon
>            Reporter: lohit vijayarenu
>             Fix For: 0.18.0
>
>         Attachments: HADOOP-3408-1.patch
>
>
> HADOOP-3058 introduced new FSNamesystem status metrics. Most of them were LongValue, but there might be cases where LongValues are not properly  handled by metrics collectors. For now, we should change it to IntValue.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.