You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Alan Conway <ac...@redhat.com> on 2013/10/01 15:40:54 UTC
Re: Review Request 14361: QPID-5197: Remove obsolete
--cluster-durable/persistLastNode options in java code.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14361/
-----------------------------------------------------------
(Updated Oct. 1, 2013, 1:40 p.m.)
Review request for qpid and rajith attapattu.
Changes
-------
Replaced incorrect diff.
Summary (updated)
-----------------
QPID-5197: Remove obsolete --cluster-durable/persistLastNode options in java code.
Bugs: QPID-5197
https://issues.apache.org/jira/browse/QPID-5197
Repository: qpid
Description (updated)
-------
QPID-5197: Remove obsolete --cluster-durable/persistLastNode options in java code.
QPID-5197: Remove obsolete --cluster-durable/persistLastNode options in C++ and python.
Diffs (updated)
-----
/trunk/qpid/cpp/src/qpid/client/QueueOptions.h 1528082
/trunk/qpid/cpp/src/qpid/client/QueueOptions.cpp 1528082
/trunk/qpid/cpp/src/tests/QueueOptionsTest.cpp 1528082
/trunk/qpid/doc/book/src/cpp-broker/Cheat-Sheet-for-configuring-Queue-Options.xml 1528082
/trunk/qpid/doc/book/src/cpp-broker/Managing-CPP-Broker.xml 1528082
/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/messaging/address/QpidQueueOptions.java 1528082
/trunk/qpid/tools/src/java/bin/qpid-web/web/qmf-ui/scripts/qmf-ui.js 1528082
/trunk/qpid/tools/src/java/bin/qpid-web/web/ui/qmf.html 1528082
/trunk/qpid/tools/src/java/src/main/java/org/apache/qpid/qmf2/tools/QpidConfig.java 1528082
/trunk/qpid/tools/src/java/src/main/java/org/apache/qpid/qmf2/util/GetOpt.java 1528082
/trunk/qpid/tools/src/py/qpid-config 1528082
Diff: https://reviews.apache.org/r/14361/diff/
Testing
-------
Thanks,
Alan Conway
Re: Review Request 14361: QPID-5197: Remove obsolete
--cluster-durable/persistLastNode options in java code.
Posted by Fraser Adams <fr...@blueyonder.co.uk>.
> On Oct. 1, 2013, 6:47 p.m., Fraser Adams wrote:
> > Ship It!
Hi Alan, I've been tied up for ages on a bunch of other things so I probably won't get a change to "fire it up" until the weekend to actually kick it, however I have had a look through the diffs and it all looks fine to me.
I have to say that I'm impressed by how thorough you've been. I did a double take when I saw the GetOpt helper mentioned cause I couldn't recall it having any such dependencies - but you've even tidied up references that were just mentioned as comments - nice one!
As long as you've fired up the GUI and checked the other bits of "durable" still behave (and from the diff I can't see any reason why they wouldn't) then I'm cool, but it'd definitely be good to double check - that expansion animation was a little fiddly :-) Visually though it looks fine to me.
- Fraser
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14361/#review26572
-----------------------------------------------------------
On Oct. 1, 2013, 2:04 p.m., Alan Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14361/
> -----------------------------------------------------------
>
> (Updated Oct. 1, 2013, 2:04 p.m.)
>
>
> Review request for qpid, Fraser Adams and rajith attapattu.
>
>
> Bugs: QPID-5197
> https://issues.apache.org/jira/browse/QPID-5197
>
>
> Repository: qpid
>
>
> Description
> -------
>
> QPID-5197: Remove obsolete --cluster-durable/persistLastNode options in java code.
> QPID-5197: Remove obsolete --cluster-durable/persistLastNode options in C++ and python.
>
> Fraser, can you look at the Java part of this and see if it is correct?
>
>
> Diffs
> -----
>
> /trunk/qpid/cpp/src/qpid/client/QueueOptions.h 1528082
> /trunk/qpid/cpp/src/qpid/client/QueueOptions.cpp 1528082
> /trunk/qpid/cpp/src/tests/QueueOptionsTest.cpp 1528082
> /trunk/qpid/doc/book/src/cpp-broker/Cheat-Sheet-for-configuring-Queue-Options.xml 1528082
> /trunk/qpid/doc/book/src/cpp-broker/Managing-CPP-Broker.xml 1528082
> /trunk/qpid/java/client/src/main/java/org/apache/qpid/client/messaging/address/QpidQueueOptions.java 1528082
> /trunk/qpid/tools/src/java/bin/qpid-web/web/qmf-ui/scripts/qmf-ui.js 1528082
> /trunk/qpid/tools/src/java/bin/qpid-web/web/ui/qmf.html 1528082
> /trunk/qpid/tools/src/java/src/main/java/org/apache/qpid/qmf2/tools/QpidConfig.java 1528082
> /trunk/qpid/tools/src/java/src/main/java/org/apache/qpid/qmf2/util/GetOpt.java 1528082
> /trunk/qpid/tools/src/py/qpid-config 1528082
>
> Diff: https://reviews.apache.org/r/14361/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alan Conway
>
>
Re: Review Request 14361: QPID-5197: Remove obsolete --cluster-durable/persistLastNode
options
Posted by Gordon Sim <gs...@redhat.com>.
On 10/05/2013 11:37 AM, Fraser Adams wrote:
> One very minor thing struck me the other evening after I'd thought about
> this change - it's not all that uncommon for people to be running
> systems that may contain a "mixed economy" of broker versions. It's
> clearly not a huge deal as the versions of the tools deployed with the
> earlier instances with work with those and 0.25+ but the opposite isn't
> true for the case of cluster-durable and that might cause some confusion.
>
> I only note this as I've got entertaining memories of the time when I
> has a mixture of 0.8 and 0.18 in a very large federated topology.
> Between those versions things had been updated to use pure QMF method
> invocation for adding/deleting things so the 0.18 tools failed miserably
> on the 0.8 brokers but the 0.8 tools still worked with the 0.18 brokers
> - thank goodness :-D . Fortunately I'm pretty familiar with QMF ;-) so I
> clocked the issue pretty much much immediately (when I found out about
> it!) but the poor sod who's job was actually to manage the system was
> tearing his hair out for ages until he thought to mention his pain to me.
The bigger problem is usually when the schema or management protocol
itself changes (particularly when things are removed). In this case it
would just be an option on a tool that is no longer available. So
hopefully its caught a little earlier and more obviously.
> I guess It's a challenge trying to keep things abreast (and tidy) with
> improvements whilst also keeping older/mixed systems running and I don't
> have any good answers myself (just saying "upgrade" doesn't cut it in an
> Enterprise environment). Documenting the change *might* work, but in
> this case where on earth would one put it where someone who may get
> bitten by this change would find it?
The much bigger change here is the removal of the old cluster module.
That was discussed a fair bit and was I believe release noted in 0.20.
This is really just a tidying up of the code around that.
I guess you could change the tool to print an explicit error when a
'removed' option is requested. That's probably worth it in some cases.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
Re: Review Request 14361: QPID-5197: Remove obsolete --cluster-durable/persistLastNode
options
Posted by Gordon Sim <gs...@redhat.com>.
On 10/07/2013 02:30 PM, Alan Conway wrote:
> My thinking was that since the feature is now gone on the broker, it is
> confusing to keep it in the tools.
I tend to agree, especially in this particular case.
> However you have a point about new
> tools against old brokers.
>
> Do you think we should keep the old features in the tools and put a
> deprecation in the release notes, then take them out next cycle?
This is another reason why I don't like the special handling for
arguments to queues, exchanges etc. It unnecessarily couples the tool to
a particular broker version. The more generic the tool is the better.
Note, that the modified qpid-config can still be used to request the
feature against an older broker using the generic --argument option.
That doesn't address Fraser's point of course, but if users had been
using that option to begin with then this would not have been an issue.
Having the broker warn or fail on unrecognised options *is* important
and as yet not completely done. (Need to have a way for plugins such as
the store to register the options they recognise).
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
Re: Review Request 14361: QPID-5197: Remove obsolete --cluster-durable/persistLastNode
options
Posted by Fraser Adams <fr...@blueyonder.co.uk>.
On 07/10/13 14:30, Alan Conway wrote:
> Hi Fraser,
>
> It's always a bit of a juggling act isn't it?
Yeah isn't it just :-)
>
> My thinking was that since the feature is now gone on the broker, it
> is confusing to keep it in the tools. However you have a point about
> new tools against old brokers.
Yeah Gordon made a good point about the change to clustering being by
far the bigger change. This comment was as much a reflection/food for
thought as anything. As I say I got bitten on another change that would
probably have caused a lot more issues had I not been so familiar with
QMF, so it's probably a bit fresh in my mind.
>
> Do you think we should keep the old features in the tools and put a
> deprecation in the release notes, then take them out next cycle? That
> would mean that we have to test that new tools do actually work with
> old brokers, which is something we haven't done so far (but probably
> should)
I guess that I probably wouldn't push the issue for this change (though
perhaps a note in the documentation for clustering to the effect that
0.25+ tools can't control the legacy clustering on older brokers won't
hurt). But on your general point about a "deprecation strategy" that
sounds a good call. There's probably a line to be drawn somewhere but
equally helping users avoid the need for big bang upgrades is the
friendly thing to do.
Thinking about it, for this particular case I *think* that it might be
possible to use qpid-config, there's the key/value options
--argument=<NAME=VALUE>
Specify a key-value pair to add to queue arguments
So I think someone who actually knew the correct property name could
still set it, but that doesn't help anyone who may have scripted a
control mechanism, and if someone has the experience to know to use this
approach they're probably well sorted anyway :-)
Frase
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
Re: Review Request 14361: QPID-5197: Remove obsolete --cluster-durable/persistLastNode
options
Posted by Alan Conway <ac...@redhat.com>.
Hi Fraser,
It's always a bit of a juggling act isn't it?
My thinking was that since the feature is now gone on the broker, it is
confusing to keep it in the tools. However you have a point about new tools
against old brokers.
Do you think we should keep the old features in the tools and put a deprecation
in the release notes, then take them out next cycle? That would mean that we
have to test that new tools do actually work with old brokers, which is
something we haven't done so far (but probably should)
Cheers,
Alan.
On 10/05/2013 06:37 AM, Fraser Adams wrote:
> Hey Alan,
> I finally got round to playing with this - I noticed it was part of the mammoth
> svn update I did this morning. It all looks fine to me. As I say thanks for
> being so thorough about tidying up everything that refers to this.
>
>
> One very minor thing struck me the other evening after I'd thought about this
> change - it's not all that uncommon for people to be running systems that may
> contain a "mixed economy" of broker versions. It's clearly not a huge deal as
> the versions of the tools deployed with the earlier instances with work with
> those and 0.25+ but the opposite isn't true for the case of cluster-durable and
> that might cause some confusion.
>
> I only note this as I've got entertaining memories of the time when I has a
> mixture of 0.8 and 0.18 in a very large federated topology. Between those
> versions things had been updated to use pure QMF method invocation for
> adding/deleting things so the 0.18 tools failed miserably on the 0.8 brokers but
> the 0.8 tools still worked with the 0.18 brokers - thank goodness :-D .
> Fortunately I'm pretty familiar with QMF ;-) so I clocked the issue pretty much
> much immediately (when I found out about it!) but the poor sod who's job was
> actually to manage the system was tearing his hair out for ages until he thought
> to mention his pain to me.
>
>
> I guess It's a challenge trying to keep things abreast (and tidy) with
> improvements whilst also keeping older/mixed systems running and I don't have
> any good answers myself (just saying "upgrade" doesn't cut it in an Enterprise
> environment). Documenting the change *might* work, but in this case where on
> earth would one put it where someone who may get bitten by this change would
> find it?
>
>
> I've got no real issues myself, but thought it was worth mentioning it as a bit
> of food for thought in case someone has any bright ideas how to manage this sort
> of scenario (it's bound to crop up again).
>
> Cheers,
> Frase
>
>
> On 01/10/13 22:43, Alan Conway wrote:
>
> On October 1st, 2013, 6:47 p.m. UTC, *Fraser Adams* wrote:
>
> Ship It!
>
> On October 1st, 2013, 6:55 p.m. UTC, *Fraser Adams* wrote:
>
> Hi Alan, I've been tied up for ages on a bunch of other things so I
> probably won't get a change to "fire it up" until the weekend to actually kick
> it, however I have had a look through the diffs and it all looks fine to me.
>
> I have to say that I'm impressed by how thorough you've been. I did a
> double take when I saw the GetOpt helper mentioned cause I couldn't recall it
> having any such dependencies - but you've even tidied up references that were
> just mentioned as comments - nice one!
>
> As long as you've fired up the GUI and checked the other bits of
> "durable" still behave (and from the diff I can't see any reason why they
> wouldn't) then I'm cool, but it'd definitely be good to double check - that
> expansion animation was a little fiddly :-) Visually though it looks fine to me.
>
> Great. I will try to figure out how to fire up the GUI myself, if you don't get
> to it first.
>
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
Re: Review Request 14361: QPID-5197: Remove obsolete --cluster-durable/persistLastNode
options
Posted by Fraser Adams <fr...@blueyonder.co.uk>.
Hey Alan,
I finally got round to playing with this - I noticed it was part of the
mammoth svn update I did this morning. It all looks fine to me. As I say
thanks for being so thorough about tidying up everything that refers to
this.
One very minor thing struck me the other evening after I'd thought about
this change - it's not all that uncommon for people to be running
systems that may contain a "mixed economy" of broker versions. It's
clearly not a huge deal as the versions of the tools deployed with the
earlier instances with work with those and 0.25+ but the opposite isn't
true for the case of cluster-durable and that might cause some confusion.
I only note this as I've got entertaining memories of the time when I
has a mixture of 0.8 and 0.18 in a very large federated topology.
Between those versions things had been updated to use pure QMF method
invocation for adding/deleting things so the 0.18 tools failed miserably
on the 0.8 brokers but the 0.8 tools still worked with the 0.18 brokers
- thank goodness :-D . Fortunately I'm pretty familiar with QMF ;-) so I
clocked the issue pretty much much immediately (when I found out about
it!) but the poor sod who's job was actually to manage the system was
tearing his hair out for ages until he thought to mention his pain to me.
I guess It's a challenge trying to keep things abreast (and tidy) with
improvements whilst also keeping older/mixed systems running and I don't
have any good answers myself (just saying "upgrade" doesn't cut it in an
Enterprise environment). Documenting the change *might* work, but in
this case where on earth would one put it where someone who may get
bitten by this change would find it?
I've got no real issues myself, but thought it was worth mentioning it
as a bit of food for thought in case someone has any bright ideas how to
manage this sort of scenario (it's bound to crop up again).
Cheers,
Frase
On 01/10/13 22:43, Alan Conway wrote:
On October 1st, 2013, 6:47 p.m. UTC, *Fraser Adams* wrote:
Ship It!
On October 1st, 2013, 6:55 p.m. UTC, *Fraser Adams* wrote:
Hi Alan, I've been tied up for ages on a bunch of other things so I probably won't get a change to "fire it up" until the weekend to actually kick it, however I have had a look through the diffs and it all looks fine to me.
I have to say that I'm impressed by how thorough you've been. I did a double take when I saw the GetOpt helper mentioned cause I couldn't recall it having any such dependencies - but you've even tidied up references that were just mentioned as comments - nice one!
As long as you've fired up the GUI and checked the other bits of "durable" still behave (and from the diff I can't see any reason why they wouldn't) then I'm cool, but it'd definitely be good to double check - that expansion animation was a little fiddly :-) Visually though it looks fine to me.
Great. I will try to figure out how to fire up the GUI myself, if you don't get to it first.
Re: Review Request 14361: QPID-5197: Remove obsolete
--cluster-durable/persistLastNode options
Posted by Alan Conway <ac...@redhat.com>.
> On Oct. 1, 2013, 6:47 p.m., Fraser Adams wrote:
> > Ship It!
>
> Fraser Adams wrote:
> Hi Alan, I've been tied up for ages on a bunch of other things so I probably won't get a change to "fire it up" until the weekend to actually kick it, however I have had a look through the diffs and it all looks fine to me.
>
> I have to say that I'm impressed by how thorough you've been. I did a double take when I saw the GetOpt helper mentioned cause I couldn't recall it having any such dependencies - but you've even tidied up references that were just mentioned as comments - nice one!
>
> As long as you've fired up the GUI and checked the other bits of "durable" still behave (and from the diff I can't see any reason why they wouldn't) then I'm cool, but it'd definitely be good to double check - that expansion animation was a little fiddly :-) Visually though it looks fine to me.
>
>
Great. I will try to figure out how to fire up the GUI myself, if you don't get to it first.
- Alan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14361/#review26572
-----------------------------------------------------------
On Oct. 1, 2013, 7:46 p.m., Alan Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14361/
> -----------------------------------------------------------
>
> (Updated Oct. 1, 2013, 7:46 p.m.)
>
>
> Review request for qpid, Fraser Adams and rajith attapattu.
>
>
> Bugs: QPID-5197
> https://issues.apache.org/jira/browse/QPID-5197
>
>
> Repository: qpid
>
>
> Description
> -------
>
> QPID-5197: Remove obsolete --cluster-durable/persistLastNode options in java code.
> QPID-5197: Remove obsolete --cluster-durable/persistLastNode options in C++ and python.
>
> Fraser, can you look at the Java part of this and see if it is correct?
>
>
> Diffs
> -----
>
> /trunk/qpid/cpp/src/qpid/client/QueueOptions.h 1528082
> /trunk/qpid/cpp/src/qpid/client/QueueOptions.cpp 1528082
> /trunk/qpid/cpp/src/tests/QueueOptionsTest.cpp 1528082
> /trunk/qpid/doc/book/src/cpp-broker/Cheat-Sheet-for-configuring-Queue-Options.xml 1528082
> /trunk/qpid/doc/book/src/cpp-broker/Managing-CPP-Broker.xml 1528082
> /trunk/qpid/java/client/src/main/java/org/apache/qpid/client/messaging/address/QpidQueueOptions.java 1528082
> /trunk/qpid/tools/src/java/bin/qpid-web/web/qmf-ui/scripts/qmf-ui.js 1528082
> /trunk/qpid/tools/src/java/bin/qpid-web/web/ui/qmf.html 1528082
> /trunk/qpid/tools/src/java/src/main/java/org/apache/qpid/qmf2/tools/QpidConfig.java 1528082
> /trunk/qpid/tools/src/java/src/main/java/org/apache/qpid/qmf2/util/GetOpt.java 1528082
> /trunk/qpid/tools/src/py/qpid-config 1528082
>
> Diff: https://reviews.apache.org/r/14361/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alan Conway
>
>
Re: Review Request 14361: QPID-5197: Remove obsolete
--cluster-durable/persistLastNode options in java code.
Posted by Fraser Adams <fr...@blueyonder.co.uk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14361/#review26572
-----------------------------------------------------------
Ship it!
Ship It!
- Fraser Adams
On Oct. 1, 2013, 2:04 p.m., Alan Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14361/
> -----------------------------------------------------------
>
> (Updated Oct. 1, 2013, 2:04 p.m.)
>
>
> Review request for qpid, Fraser Adams and rajith attapattu.
>
>
> Bugs: QPID-5197
> https://issues.apache.org/jira/browse/QPID-5197
>
>
> Repository: qpid
>
>
> Description
> -------
>
> QPID-5197: Remove obsolete --cluster-durable/persistLastNode options in java code.
> QPID-5197: Remove obsolete --cluster-durable/persistLastNode options in C++ and python.
>
> Fraser, can you look at the Java part of this and see if it is correct?
>
>
> Diffs
> -----
>
> /trunk/qpid/cpp/src/qpid/client/QueueOptions.h 1528082
> /trunk/qpid/cpp/src/qpid/client/QueueOptions.cpp 1528082
> /trunk/qpid/cpp/src/tests/QueueOptionsTest.cpp 1528082
> /trunk/qpid/doc/book/src/cpp-broker/Cheat-Sheet-for-configuring-Queue-Options.xml 1528082
> /trunk/qpid/doc/book/src/cpp-broker/Managing-CPP-Broker.xml 1528082
> /trunk/qpid/java/client/src/main/java/org/apache/qpid/client/messaging/address/QpidQueueOptions.java 1528082
> /trunk/qpid/tools/src/java/bin/qpid-web/web/qmf-ui/scripts/qmf-ui.js 1528082
> /trunk/qpid/tools/src/java/bin/qpid-web/web/ui/qmf.html 1528082
> /trunk/qpid/tools/src/java/src/main/java/org/apache/qpid/qmf2/tools/QpidConfig.java 1528082
> /trunk/qpid/tools/src/java/src/main/java/org/apache/qpid/qmf2/util/GetOpt.java 1528082
> /trunk/qpid/tools/src/py/qpid-config 1528082
>
> Diff: https://reviews.apache.org/r/14361/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alan Conway
>
>
Re: Review Request 14361: QPID-5197: Remove obsolete
--cluster-durable/persistLastNode options in java code.
Posted by rajith attapattu <ra...@gmail.com>.
> On Oct. 1, 2013, 2:29 p.m., rajith attapattu wrote:
> > Ship It!
QpidQueueOptions.java is no longer in use.
Provided the QMF changes are verified by Fraser I don't foresee any other issues.
- rajith
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14361/#review26555
-----------------------------------------------------------
On Oct. 1, 2013, 2:04 p.m., Alan Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14361/
> -----------------------------------------------------------
>
> (Updated Oct. 1, 2013, 2:04 p.m.)
>
>
> Review request for qpid, Fraser Adams and rajith attapattu.
>
>
> Bugs: QPID-5197
> https://issues.apache.org/jira/browse/QPID-5197
>
>
> Repository: qpid
>
>
> Description
> -------
>
> QPID-5197: Remove obsolete --cluster-durable/persistLastNode options in java code.
> QPID-5197: Remove obsolete --cluster-durable/persistLastNode options in C++ and python.
>
> Fraser, can you look at the Java part of this and see if it is correct?
>
>
> Diffs
> -----
>
> /trunk/qpid/cpp/src/qpid/client/QueueOptions.h 1528082
> /trunk/qpid/cpp/src/qpid/client/QueueOptions.cpp 1528082
> /trunk/qpid/cpp/src/tests/QueueOptionsTest.cpp 1528082
> /trunk/qpid/doc/book/src/cpp-broker/Cheat-Sheet-for-configuring-Queue-Options.xml 1528082
> /trunk/qpid/doc/book/src/cpp-broker/Managing-CPP-Broker.xml 1528082
> /trunk/qpid/java/client/src/main/java/org/apache/qpid/client/messaging/address/QpidQueueOptions.java 1528082
> /trunk/qpid/tools/src/java/bin/qpid-web/web/qmf-ui/scripts/qmf-ui.js 1528082
> /trunk/qpid/tools/src/java/bin/qpid-web/web/ui/qmf.html 1528082
> /trunk/qpid/tools/src/java/src/main/java/org/apache/qpid/qmf2/tools/QpidConfig.java 1528082
> /trunk/qpid/tools/src/java/src/main/java/org/apache/qpid/qmf2/util/GetOpt.java 1528082
> /trunk/qpid/tools/src/py/qpid-config 1528082
>
> Diff: https://reviews.apache.org/r/14361/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alan Conway
>
>
Re: Review Request 14361: QPID-5197: Remove obsolete
--cluster-durable/persistLastNode options in java code.
Posted by rajith attapattu <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14361/#review26555
-----------------------------------------------------------
Ship it!
Ship It!
- rajith attapattu
On Oct. 1, 2013, 2:04 p.m., Alan Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14361/
> -----------------------------------------------------------
>
> (Updated Oct. 1, 2013, 2:04 p.m.)
>
>
> Review request for qpid, Fraser Adams and rajith attapattu.
>
>
> Bugs: QPID-5197
> https://issues.apache.org/jira/browse/QPID-5197
>
>
> Repository: qpid
>
>
> Description
> -------
>
> QPID-5197: Remove obsolete --cluster-durable/persistLastNode options in java code.
> QPID-5197: Remove obsolete --cluster-durable/persistLastNode options in C++ and python.
>
> Fraser, can you look at the Java part of this and see if it is correct?
>
>
> Diffs
> -----
>
> /trunk/qpid/cpp/src/qpid/client/QueueOptions.h 1528082
> /trunk/qpid/cpp/src/qpid/client/QueueOptions.cpp 1528082
> /trunk/qpid/cpp/src/tests/QueueOptionsTest.cpp 1528082
> /trunk/qpid/doc/book/src/cpp-broker/Cheat-Sheet-for-configuring-Queue-Options.xml 1528082
> /trunk/qpid/doc/book/src/cpp-broker/Managing-CPP-Broker.xml 1528082
> /trunk/qpid/java/client/src/main/java/org/apache/qpid/client/messaging/address/QpidQueueOptions.java 1528082
> /trunk/qpid/tools/src/java/bin/qpid-web/web/qmf-ui/scripts/qmf-ui.js 1528082
> /trunk/qpid/tools/src/java/bin/qpid-web/web/ui/qmf.html 1528082
> /trunk/qpid/tools/src/java/src/main/java/org/apache/qpid/qmf2/tools/QpidConfig.java 1528082
> /trunk/qpid/tools/src/java/src/main/java/org/apache/qpid/qmf2/util/GetOpt.java 1528082
> /trunk/qpid/tools/src/py/qpid-config 1528082
>
> Diff: https://reviews.apache.org/r/14361/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alan Conway
>
>
Re: Review Request 14361: QPID-5197: Remove obsolete
--cluster-durable/persistLastNode options
Posted by Alan Conway <ac...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14361/
-----------------------------------------------------------
(Updated Oct. 1, 2013, 7:46 p.m.)
Review request for qpid, Fraser Adams and rajith attapattu.
Summary (updated)
-----------------
QPID-5197: Remove obsolete --cluster-durable/persistLastNode options
Bugs: QPID-5197
https://issues.apache.org/jira/browse/QPID-5197
Repository: qpid
Description
-------
QPID-5197: Remove obsolete --cluster-durable/persistLastNode options in java code.
QPID-5197: Remove obsolete --cluster-durable/persistLastNode options in C++ and python.
Fraser, can you look at the Java part of this and see if it is correct?
Diffs
-----
/trunk/qpid/cpp/src/qpid/client/QueueOptions.h 1528082
/trunk/qpid/cpp/src/qpid/client/QueueOptions.cpp 1528082
/trunk/qpid/cpp/src/tests/QueueOptionsTest.cpp 1528082
/trunk/qpid/doc/book/src/cpp-broker/Cheat-Sheet-for-configuring-Queue-Options.xml 1528082
/trunk/qpid/doc/book/src/cpp-broker/Managing-CPP-Broker.xml 1528082
/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/messaging/address/QpidQueueOptions.java 1528082
/trunk/qpid/tools/src/java/bin/qpid-web/web/qmf-ui/scripts/qmf-ui.js 1528082
/trunk/qpid/tools/src/java/bin/qpid-web/web/ui/qmf.html 1528082
/trunk/qpid/tools/src/java/src/main/java/org/apache/qpid/qmf2/tools/QpidConfig.java 1528082
/trunk/qpid/tools/src/java/src/main/java/org/apache/qpid/qmf2/util/GetOpt.java 1528082
/trunk/qpid/tools/src/py/qpid-config 1528082
Diff: https://reviews.apache.org/r/14361/diff/
Testing
-------
Thanks,
Alan Conway
Re: Review Request 14361: QPID-5197: Remove obsolete
--cluster-durable/persistLastNode options in java code.
Posted by Alan Conway <ac...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14361/
-----------------------------------------------------------
(Updated Oct. 1, 2013, 2:04 p.m.)
Review request for qpid, Fraser Adams and rajith attapattu.
Changes
-------
Add Fraser Adams
Bugs: QPID-5197
https://issues.apache.org/jira/browse/QPID-5197
Repository: qpid
Description (updated)
-------
QPID-5197: Remove obsolete --cluster-durable/persistLastNode options in java code.
QPID-5197: Remove obsolete --cluster-durable/persistLastNode options in C++ and python.
Fraser, can you look at the Java part of this and see if it is correct?
Diffs
-----
/trunk/qpid/cpp/src/qpid/client/QueueOptions.h 1528082
/trunk/qpid/cpp/src/qpid/client/QueueOptions.cpp 1528082
/trunk/qpid/cpp/src/tests/QueueOptionsTest.cpp 1528082
/trunk/qpid/doc/book/src/cpp-broker/Cheat-Sheet-for-configuring-Queue-Options.xml 1528082
/trunk/qpid/doc/book/src/cpp-broker/Managing-CPP-Broker.xml 1528082
/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/messaging/address/QpidQueueOptions.java 1528082
/trunk/qpid/tools/src/java/bin/qpid-web/web/qmf-ui/scripts/qmf-ui.js 1528082
/trunk/qpid/tools/src/java/bin/qpid-web/web/ui/qmf.html 1528082
/trunk/qpid/tools/src/java/src/main/java/org/apache/qpid/qmf2/tools/QpidConfig.java 1528082
/trunk/qpid/tools/src/java/src/main/java/org/apache/qpid/qmf2/util/GetOpt.java 1528082
/trunk/qpid/tools/src/py/qpid-config 1528082
Diff: https://reviews.apache.org/r/14361/diff/
Testing
-------
Thanks,
Alan Conway
Re: Review Request 14361: QPID-5197: Remove obsolete
--cluster-durable/persistLastNode options in java code.
Posted by Gordon Sim <gs...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14361/#review26553
-----------------------------------------------------------
Ship it!
Ship It!
- Gordon Sim
On Oct. 1, 2013, 1:40 p.m., Alan Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14361/
> -----------------------------------------------------------
>
> (Updated Oct. 1, 2013, 1:40 p.m.)
>
>
> Review request for qpid and rajith attapattu.
>
>
> Bugs: QPID-5197
> https://issues.apache.org/jira/browse/QPID-5197
>
>
> Repository: qpid
>
>
> Description
> -------
>
> QPID-5197: Remove obsolete --cluster-durable/persistLastNode options in java code.
>
>
> QPID-5197: Remove obsolete --cluster-durable/persistLastNode options in C++ and python.
>
>
> Diffs
> -----
>
> /trunk/qpid/cpp/src/qpid/client/QueueOptions.h 1528082
> /trunk/qpid/cpp/src/qpid/client/QueueOptions.cpp 1528082
> /trunk/qpid/cpp/src/tests/QueueOptionsTest.cpp 1528082
> /trunk/qpid/doc/book/src/cpp-broker/Cheat-Sheet-for-configuring-Queue-Options.xml 1528082
> /trunk/qpid/doc/book/src/cpp-broker/Managing-CPP-Broker.xml 1528082
> /trunk/qpid/java/client/src/main/java/org/apache/qpid/client/messaging/address/QpidQueueOptions.java 1528082
> /trunk/qpid/tools/src/java/bin/qpid-web/web/qmf-ui/scripts/qmf-ui.js 1528082
> /trunk/qpid/tools/src/java/bin/qpid-web/web/ui/qmf.html 1528082
> /trunk/qpid/tools/src/java/src/main/java/org/apache/qpid/qmf2/tools/QpidConfig.java 1528082
> /trunk/qpid/tools/src/java/src/main/java/org/apache/qpid/qmf2/util/GetOpt.java 1528082
> /trunk/qpid/tools/src/py/qpid-config 1528082
>
> Diff: https://reviews.apache.org/r/14361/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alan Conway
>
>