You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@allura.apache.org by Dave Brondsema <da...@brondsema.net> on 2015/04/14 23:17:59 UTC
[allura:tickets] #7870 Clean up .ini files
---
** [tickets:#7870] Clean up .ini files**
**Status:** in-progress
**Milestone:** unreleased
**Labels:** sf-current sf-2
**Created:** Tue Apr 14, 2015 09:17 PM UTC by Dave Brondsema
**Last Updated:** Tue Apr 14, 2015 09:17 PM UTC
**Owner:** Dave Brondsema
We should standardize on comment syntax, and add examples/comments for all config values that are possible.
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #7870 Clean up .ini files
Posted by Heith Seewald <hs...@slashdotmedia.com>.
- **status**: review --> closed
- **Comment**:
Ok, looks great!
---
** [tickets:#7870] Clean up .ini files**
**Status:** closed
**Milestone:** unreleased
**Labels:** sf-current sf-2
**Created:** Tue Apr 14, 2015 09:17 PM UTC by Dave Brondsema
**Last Updated:** Mon Apr 20, 2015 04:12 PM UTC
**Owner:** Dave Brondsema
We should standardize on comment syntax, and add examples/comments for all config values that are possible.
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #7870 Clean up .ini files
Posted by Dave Brondsema <da...@brondsema.net>.
- **labels**: sf-current, sf-2 --> sf-2
---
** [tickets:#7870] Clean up .ini files**
**Status:** closed
**Milestone:** unreleased
**Labels:** sf-2
**Created:** Tue Apr 14, 2015 09:17 PM UTC by Dave Brondsema
**Last Updated:** Mon Apr 20, 2015 04:53 PM UTC
**Owner:** Dave Brondsema
We should standardize on comment syntax, and add examples/comments for all config values that are possible.
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #7870 Clean up .ini files
Posted by Heith Seewald <hs...@slashdotmedia.com>.
- **Reviewer**: Heith Seewald
---
** [tickets:#7870] Clean up .ini files**
**Status:** review
**Milestone:** unreleased
**Labels:** sf-current sf-2
**Created:** Tue Apr 14, 2015 09:17 PM UTC by Dave Brondsema
**Last Updated:** Wed Apr 15, 2015 08:06 PM UTC
**Owner:** Dave Brondsema
We should standardize on comment syntax, and add examples/comments for all config values that are possible.
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] Re: #7870 Clean up .ini files
Posted by Dave Brondsema <da...@brondsema.net>.
1. yes it should be the same. `forgemail.url` is used in outgoing emails. I think we could remove it and just use `base_url` but I didn't do that at this point.
4. the `oauth.can_import_forum` stuff is pretty old and doubtfully even used by anyone. So I don't want to document it more :)
6. Yes, intentionally. I grouped them with other related settings (outgoing mail, URLs, incoming mail) rather than by name since they seemed to fit better with other settings than with themselves
Inheritance is explained in the comments the top of the file.
Everything else addressed with a new commit on `db/7870` branch and ready for review.
---
** [tickets:#7870] Clean up .ini files**
**Status:** in-progress
**Milestone:** unreleased
**Labels:** sf-current sf-2
**Created:** Tue Apr 14, 2015 09:17 PM UTC by Dave Brondsema
**Last Updated:** Mon Apr 20, 2015 03:55 PM UTC
**Owner:** Dave Brondsema
We should standardize on comment syntax, and add examples/comments for all config values that are possible.
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #7870 Clean up .ini files
Posted by Heith Seewald <hs...@slashdotmedia.com>.
Looking really good overall! I have a few minor notes relating to the .ini file:
1. `line 81` forgemail.url <— what is this and is it normally the same as the base_url?
2. `line 114`: typo in `integratino`
3. `line 126`: what is a: `login_fragment`?
4. `lines 322/323` could use an example use case.
5. `line 370`: poll_interval = unit of time??
6. `lines: 57, 81, 390-394 ` The forgemail settings are scattered.
7. `line 407`: unit of time?
8. `line 410` — example of a site-wide notification would be nice.
9. `line 426`: A quick def of what `soft-delete` in context of allura
10. `line 485`: I’m getting a 404 for the python logging doc with that url
Some indication of how to use inheritance (like you did in the test.ini) to over-ride local settings would be handy. (this may be better in the docs)
** A huge improvement overall!**
---
** [tickets:#7870] Clean up .ini files**
**Status:** review
**Milestone:** unreleased
**Labels:** sf-current sf-2
**Created:** Tue Apr 14, 2015 09:17 PM UTC by Dave Brondsema
**Last Updated:** Thu Apr 16, 2015 05:13 PM UTC
**Owner:** Dave Brondsema
We should standardize on comment syntax, and add examples/comments for all config values that are possible.
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #7870 Clean up .ini files
Posted by Dave Brondsema <da...@brondsema.net>.
- **status**: review --> in-progress
---
** [tickets:#7870] Clean up .ini files**
**Status:** in-progress
**Milestone:** unreleased
**Labels:** sf-current sf-2
**Created:** Tue Apr 14, 2015 09:17 PM UTC by Dave Brondsema
**Last Updated:** Mon Apr 20, 2015 03:16 PM UTC
**Owner:** Dave Brondsema
We should standardize on comment syntax, and add examples/comments for all config values that are possible.
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #7870 Clean up .ini files
Posted by Dave Brondsema <da...@brondsema.net>.
- **status**: in-progress --> review
- **Comment**:
{allura,forgehg}:db/7870
* run tests, ensure they pass
* make sure taskd and `paster serve` work as expected
* read `development.ini` and make sure the comments and examples all make sense
---
** [tickets:#7870] Clean up .ini files**
**Status:** review
**Milestone:** unreleased
**Labels:** sf-current sf-2
**Created:** Tue Apr 14, 2015 09:17 PM UTC by Dave Brondsema
**Last Updated:** Tue Apr 14, 2015 09:18 PM UTC
**Owner:** Dave Brondsema
We should standardize on comment syntax, and add examples/comments for all config values that are possible.
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #7870 Clean up .ini files
Posted by Dave Brondsema <da...@brondsema.net>.
- **status**: in-progress --> review
---
** [tickets:#7870] Clean up .ini files**
**Status:** review
**Milestone:** unreleased
**Labels:** sf-current sf-2
**Created:** Tue Apr 14, 2015 09:17 PM UTC by Dave Brondsema
**Last Updated:** Mon Apr 20, 2015 03:55 PM UTC
**Owner:** Dave Brondsema
We should standardize on comment syntax, and add examples/comments for all config values that are possible.
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.