[GitHub] [incubator-nuttx] patacongo opened a new pull request #961: arch/arm/: Rename up_intstack_* to arm_intstack_*

[GitBox <gi...@apache.org>]

patacongo opened a new pull request #961:
URL: https://github.com/apache/incubator-nuttx/pull/961


   ## Summary
   
   The naming standard at https://cwiki.apache.org/confluence/display/NUTTX/Naming+FAQ requires that all architecture-private functions begin with the name of the arch, not up_.
   
   This PR addresses only these name changes for the ARM-private functions up_instack_base() and up_instack_top() which should be called arm_instack_base() and arm_instack_top().
   
   ## Impact
   
   There should be no impact of this change (other that one step toward more consistent naming).
   
   ## Testing
   
   Normal PR checks are sufficient
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] patacongo commented on pull request #961: arch/arm/: Rename up_intstack_* to arm_intstack_*

[GitBox <gi...@apache.org>]

patacongo commented on pull request #961:
URL: https://github.com/apache/incubator-nuttx/pull/961#issuecomment-623148255


   There are several expected nxstyle errors in this change.  These are in the header files arch/arm/src/lc23450/chip.h and arch/arm/src/imx6/chip.h.  Those header files contain extensive assembly language macro definitions that include TABs.  Also, the TAB alignment of assembly language commands does not satisfy nxstyle's C header file expections.
   
   Please ignore these two classes of errors in these two header files when making your decision to merge.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org