You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by sachingoel0101 <gi...@git.apache.org> on 2015/10/03 13:10:14 UTC
[GitHub] flink pull request: [FLINK-2811][web-dashboard]Add page with Confi...
GitHub user sachingoel0101 opened a pull request:
https://github.com/apache/flink/pull/1219
[FLINK-2811][web-dashboard]Add page with Configuration Overview.
Here's a screenshot:
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sachingoel0101/flink config_page
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1219.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1219
----
commit b67706de973265a34a787c0a4621c7b4334ac909
Author: Sachin Goel <sa...@gmail.com>
Date: 2015-10-03T08:39:36Z
[FLINK-2811][web-dashboard]Add page with Configuration Overview.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2811][web-dashboard]Add page with Confi...
Posted by sachingoel0101 <gi...@git.apache.org>.
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1219#issuecomment-145633502
Yes. You're right. I'd misunderstood Stephan's comment. The goal is to group similar keys together, and sorting alphabetically will definitely take care of that.
On a separate note, does it make sense to have this type of structure:
*Job Manager*
jobmanager.*
*Akka*
akka.
*Recovery*
ha.*
and so on. Of course, if no keys are available under a group, it won't be displayed at all. Or we can just leave it at sorted alphabetically. Your call.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2811][web-dashboard]Add page with Confi...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1219#issuecomment-145485508
How about mapping the jobmanager config to `/jobmanager/config` and later mapping the jobmanager log to `jobmanager/logfile`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2811][web-dashboard]Add page with Confi...
Posted by sachingoel0101 <gi...@git.apache.org>.
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1219#issuecomment-145847895
Okay. I already have the basic functionality up.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2811][web-dashboard]Add page with Confi...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1219#issuecomment-145485606
And the `.out` file to `/jobmanager/stdout` or so...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2811][web-dashboard]Add page with Confi...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1219#issuecomment-145320562
Thank you for resolving the issue so quickly.
I think its good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2811][web-dashboard]Add page with Confi...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1219#issuecomment-145787219
Very good, Sachin. Thanks! I will try it out again and then merge it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2811][web-dashboard]Add page with Confi...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1219
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2811][web-dashboard]Add page with Confi...
Posted by sachingoel0101 <gi...@git.apache.org>.
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1219#issuecomment-145496489
That sounds good enough. I'll push a fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2811][web-dashboard]Add page with Confi...
Posted by sachingoel0101 <gi...@git.apache.org>.
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1219#issuecomment-145532006
Updated as per @StephanEwen's comments. Here's another screenshot:
The `/logfile` and `/stdout` urls are dummy and contain nothing right now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2811][web-dashboard]Add page with Confi...
Posted by iampeter <gi...@git.apache.org>.
Github user iampeter commented on the pull request:
https://github.com/apache/flink/pull/1219#issuecomment-145842071
@sachingoel0101 unfortunately haven't had time yet, so I guess you can take on it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2811][web-dashboard]Add page with Confi...
Posted by sachingoel0101 <gi...@git.apache.org>.
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1219#issuecomment-145546618
1. I don't know if someone else is working on this, but this way we can provide a log and out file the way it is displayed, say on travis. Updated in real time. And of course, put a button to download them.
2. Sure. I will add a commit for that and we can decide on 1 after that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2811][web-dashboard]Add page with Confi...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1219#issuecomment-145575599
Regarding 1) Great idea Sachin. I never liked it in Travis, but I see how it can be useful for the JM logs. What about addressing Stephans comments for now and then adding the update + download thing later? This is rather time critical, because we want to add it to the release and there is consensus to remove the old interface.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2811][web-dashboard]Add page with Confi...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1219#issuecomment-145536979
Two comments:
1) In the old web frontend, we showed the log and out files raw in a new tab. I think that was good, it allows to download/save the files without extra logic.
2) If it is not too much effort, could you sort the config keys (probably on the backend side)? Would make bigger configs easier to navigate...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2811][web-dashboard]Add page with Confi...
Posted by sachingoel0101 <gi...@git.apache.org>.
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1219#issuecomment-145604812
@uce , Great. I think someone else was working on providing job manager log and out access. If not, I'll give it a shot in a few days.
@StephanEwen, is sorting with respect to size of keys okay? Also, there is no need to do this on the backend. Angular can do that pretty straightforward.
Attaching a screenshot again:
Sorting is by key lengths, which isn't exactly ideal.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2811][web-dashboard]Add page with Confi...
Posted by sachingoel0101 <gi...@git.apache.org>.
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1219#issuecomment-145458067
On the user end, a url '/config' makes more sense IMO. On the server end, `config` is already mapped to something else, so I chose a `/jmconfig` there.
If you think `/jobManagerConfig` is better however, let me know. I will push a commit for that.
On a related note, '/jobmanager/config' might be a better choice for url. Are there any job manager statistics which should be made available under a `/jobmanager` url? Running jobs and completed jobs are already there.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2811][web-dashboard]Add page with Confi...
Posted by sachingoel0101 <gi...@git.apache.org>.
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1219#issuecomment-145620411
I was thinking more about the actual pixel length but achieving that is proving to be kind of hard.
Alphabetically should be okay I think.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2811][web-dashboard]Add page with Confi...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1219#issuecomment-145617179
I think alphabetically is better.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2811][web-dashboard]Add page with Confi...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1219#issuecomment-145799335
Sachin, do you also have time to fix the job manager logs? Would be good to have it in the release. Go for the simplest solution and don't try to make it too fancy for the first version. ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2811][web-dashboard]Add page with Confi...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1219#issuecomment-145450299
Thanks for this! Looks good. I would make the naming consistent though. You mix `jmConfig` and `config`. I am for `jobManagerConfig` to make it really clear what it is. I will try this out and merge if it works as expected.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2811][web-dashboard]Add page with Confi...
Posted by sachingoel0101 <gi...@git.apache.org>.
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1219#issuecomment-145805159
I can work on it but FLINK-2728 is already assigned to @iampeter.
@iampeter, have you started working on it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2811][web-dashboard]Add page with Confi...
Posted by sachingoel0101 <gi...@git.apache.org>.
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1219#issuecomment-145776217
Here's what it looks like right now:
Let me know if you have something else in mind.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2811][web-dashboard]Add page with Confi...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1219#issuecomment-145776554
Looks good with alphabetical order imo.
On Tue, Oct 6, 2015 at 10:03 AM, Sachin Goel <no...@github.com>
wrote:
> Here's what it looks like right now:
> [image: capture]
> <https://cloud.githubusercontent.com/assets/8874261/10303034/73a25630-6c2e-11e5-91b8-9bc675baf65d.PNG>
>
> Let me know if you have something else in mind.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/flink/pull/1219#issuecomment-145776217>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2811][web-dashboard]Add page with Confi...
Posted by sachingoel0101 <gi...@git.apache.org>.
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1219#issuecomment-145789894
Okay. Cool. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2811][web-dashboard]Add page with Confi...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1219#issuecomment-145630566
I see. But pixel length or number of characters does not make it easier to navigate when you want to look up a specific key, e.g. `jobmanager.X.Y`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---