You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "gaoyajun02 (via GitHub)" <gi...@apache.org> on 2025/03/24 10:03:22 UTC

Re: [PR] [CELEBORN-1680] Introduce ShuffleFallbackCount metrics [celeborn]

gaoyajun02 commented on code in PR #2866:
URL: https://github.com/apache/celeborn/pull/2866#discussion_r2009851715


##########
master/src/main/scala/org/apache/celeborn/service/deploy/master/Master.scala:
##########
@@ -265,6 +265,10 @@ private[celeborn] class Master(
       }).sum()
   }
 
+  masterSource.addGauge(MasterSource.SHUFFLE_FALLBACK_COUNT) { () =>

Review Comment:
   "Looking at the final merged code, it's still using addGauge instead of addMeter. Was this change overlooked?"
   @turboFei @RexXiong 



##########
master/src/main/scala/org/apache/celeborn/service/deploy/master/Master.scala:
##########
@@ -265,6 +265,10 @@ private[celeborn] class Master(
       }).sum()
   }
 
+  masterSource.addGauge(MasterSource.SHUFFLE_FALLBACK_COUNT) { () =>

Review Comment:
   Looking at the final merged code, it's still using addGauge instead of addMeter. Was this change overlooked?
   @turboFei @RexXiong 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org