You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/02/26 03:35:38 UTC

[GitHub] [echarts] Ericteen opened a new pull request #14355: fix(calendar): provide correct TS type. close #14354

Ericteen opened a new pull request #14355:
URL: https://github.com/apache/echarts/pull/14355


   <!-- Please fill in the following information to help us review your PR more efficiently. -->
   
   ## Brief Information
   
   This pull request is in the type of:
   
   - [x] bug fixing
   - [ ] new feature
   - [ ] others
   
   
   
   ### What does this PR do?
   
   <!-- USE ONCE SENTENCE TO DESCRIBE WHAT THIS PR DOES. -->
   fixed issue #14354 
   
   
   ### Fixed issues
   
   <!--
   - #xxxx: ...
   -->
   TS type error, details #14354 
   
   ## Details
   
   ### Before: What was the problem?
   
   <!-- DESCRIBE THE BUG OR REQUIREMENT HERE. -->
   when you set the `calendar.itemStyle.color` property, `__canvasGradient` is required.
   
   <!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
   
   
   ### After: How is it fixed in this PR?
   
   <!-- THE RESULT AFTER FIXING AND A SIMPLE EXPLANATION ABOUT HOW IT IS FIXED. -->
   ```ts
   export declare type ZRColor = ColorString | Omit<LinearGradientObject, '__canvasGradient'> | Omit<RadialGradientObject, '__canvasGradient'> | PatternObject;
   ```
   <!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
   
   
   
   ## Usage
   
   ### Are there any API changes?
   
   - [ ] The API has been changed.
   
   <!-- LIST THE API CHANGES HERE -->
   
   
   
   ### Related test cases or examples to use the new APIs
   
   NA.
   
   
   
   ## Others
   
   ### Merging options
   
   - [ ] Please squash the commits into a single one when merge.
   
   ### Other information
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] pissang edited a comment on pull request #14355: fix(calendar): provide correct TS type. close #14354

Posted by GitBox <gi...@apache.org>.
pissang edited a comment on pull request #14355:
URL: https://github.com/apache/echarts/pull/14355#issuecomment-786394175


   Thanks! I did a fix in the underlying zrender https://github.com/ecomfe/zrender/pull/727


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] Ericteen closed pull request #14355: fix(calendar): provide correct TS type. close #14354

Posted by GitBox <gi...@apache.org>.
Ericteen closed pull request #14355:
URL: https://github.com/apache/echarts/pull/14355


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] commented on pull request #14355: fix(calendar): provide correct TS type. close #14354

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #14355:
URL: https://github.com/apache/echarts/pull/14355#issuecomment-786388258


   Thanks for your contribution!
   The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] pissang commented on pull request #14355: fix(calendar): provide correct TS type. close #14354

Posted by GitBox <gi...@apache.org>.
pissang commented on pull request #14355:
URL: https://github.com/apache/echarts/pull/14355#issuecomment-786394175


   Thanks! I did a fix in the zrender https://github.com/ecomfe/zrender/pull/727


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org