You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@submarine.apache.org by GitBox <gi...@apache.org> on 2020/02/03 14:48:05 UTC
[GitHub] [submarine] kevin85421 opened a new pull request #171:
Submarine-368. [WEB] Add items to the sidebar with Angular
kevin85421 opened a new pull request #171: Submarine-368. [WEB] Add items to the sidebar with Angular
URL: https://github.com/apache/submarine/pull/171
### What is this PR for?
1. The attachment is the sidebar of the version Vue. Our target is implementing a similar sidebar with Angular.
2. Add E2E unit test cases of the navigation of the sidebar.
3. Update the E2E test framework to avoid some compilation errors.
### What type of PR is it?
Feature
### Todos
### What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-368
### How should this be tested?
https://travis-ci.org/kevin85421/hadoop-submarine?utm_medium=notification&utm_source=github_status
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need an update? No
* Are there breaking changes for older versions? No
* Does this needs documentation? No
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] liuxunorg commented on issue #171: Submarine-368. [WEB]
Add items to the sidebar with Angular
Posted by GitBox <gi...@apache.org>.
liuxunorg commented on issue #171: Submarine-368. [WEB] Add items to the sidebar with Angular
URL: https://github.com/apache/submarine/pull/171#issuecomment-581965536
@kevin85421 Thank you contribution.
E2E testing is very important to us, and it is worth taking some time to do it well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] yuanzac commented on issue #171: Submarine-368. [WEB]
Add items to the sidebar with Angular
Posted by GitBox <gi...@apache.org>.
yuanzac commented on issue #171: Submarine-368. [WEB] Add items to the sidebar with Angular
URL: https://github.com/apache/submarine/pull/171#issuecomment-581720141
Thanks, @kevin85421.
For now, chrome is used for the e2e test. You can check code line 46 - 53 of WebDriverManager. Besides, the travis log shows that chrome is used. If chrome failed, we will try firefox. But firefox doesn't work actually. If you have bindwidth, you can help figure out how to use firefox in travis.
You mean the value of DRIVER_USE_MARIONETTE blocks your compilations? I'm not sure about that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] kevin85421 commented on issue #171: Submarine-368.
[WEB] Add items to the sidebar with Angular
Posted by GitBox <gi...@apache.org>.
kevin85421 commented on issue #171: Submarine-368. [WEB] Add items to the sidebar with Angular
URL: https://github.com/apache/submarine/pull/171#issuecomment-582269061
Thanks, @yuanzac and @liuxunorg
I have reported the issue of E2E test framework [SUBMARINE-374](https://issues.apache.org/jira/projects/SUBMARINE/issues/SUBMARINE-374).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] asfgit closed pull request #171: Submarine-368. [WEB]
Add items to the sidebar with Angular
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #171: Submarine-368. [WEB] Add items to the sidebar with Angular
URL: https://github.com/apache/submarine/pull/171
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] kevin85421 commented on issue #171: Submarine-368.
[WEB] Add items to the sidebar with Angular
Posted by GitBox <gi...@apache.org>.
kevin85421 commented on issue #171: Submarine-368. [WEB] Add items to the sidebar with Angular
URL: https://github.com/apache/submarine/pull/171#issuecomment-581743539
Thanks, @yuanzac.
I execute the E2E test on my localhost (not on travis). On my Macbook Pro, I cannot execute the test with Chrome driver, and hence I used Firefox driver. I can try to figure out how to use Firefox driver on travis in the future. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] kevin85421 commented on issue #171: Submarine-368.
[WEB] Add items to the sidebar with Angular
Posted by GitBox <gi...@apache.org>.
kevin85421 commented on issue #171: Submarine-368. [WEB] Add items to the sidebar with Angular
URL: https://github.com/apache/submarine/pull/171#issuecomment-581454987
@yuanzac I modified the file FirefoxWebDriverProvider.java. To elaborate, I change the value of **DRIVER_USE_MARIONETTE** from **false** to **true**. Without the modification, I cannot compile the code successfully. In addition, my OS is macOS 10.15.2. Can you help me review the file FirefoxWebDriverProvider.java? Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org