You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Lavkesh Lahngir <la...@gmail.com> on 2016/05/05 10:26:59 UTC
Review Request 47007: Return same handle for repeated query from same
user
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47007/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-1019
https://issues.apache.org/jira/browse/LENS-1019
Repository: lens
Description
-------
If query is repeated from user - with same query, same name, same conf on the same session
and earlier is still queued or running, then return the same handle. This will only handle the case of aysnc queries.
Diffs
-----
lens-api/src/main/java/org/apache/lens/api/LensConf.java 86504c7
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 42bd4ab
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java df13ba2
Diff: https://reviews.apache.org/r/47007/diff/
Testing
-------
testExecuteAsyncDuplicate() methods tests the following.
1. Same query, same user and same session returns the same handle.
2. After query completion, same query firing will give the different handle.
3. Differnt session and same query will return different handle.
Thanks,
Lavkesh Lahngir
Re: Review Request 47007: Return same handle for repeated query from
same user
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47007/#review131987
-----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 1794)
<https://reviews.apache.org/r/47007/#comment196025>
If session is same user would be same - as we figure out user from session itself.
We might have to add queryName for the check here.
- Amareshwari Sriramadasu
On May 5, 2016, 10:26 a.m., Lavkesh Lahngir wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47007/
> -----------------------------------------------------------
>
> (Updated May 5, 2016, 10:26 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1019
> https://issues.apache.org/jira/browse/LENS-1019
>
>
> Repository: lens
>
>
> Description
> -------
>
> If query is repeated from user - with same query, same name, same conf on the same session
> and earlier is still queued or running, then return the same handle. This will only handle the case of aysnc queries.
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/LensConf.java 86504c7
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 42bd4ab
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java df13ba2
>
> Diff: https://reviews.apache.org/r/47007/diff/
>
>
> Testing
> -------
>
> testExecuteAsyncDuplicate() methods tests the following.
> 1. Same query, same user and same session returns the same handle.
> 2. After query completion, same query firing will give the different handle.
> 3. Differnt session and same query will return different handle.
>
>
> Thanks,
>
> Lavkesh Lahngir
>
>
Re: Review Request 47007: Return same handle for repeated query from
same user
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47007/#review132817
-----------------------------------------------------------
Fix it, then Ship it!
lens-server/src/main/resources/lensserver-default.xml (line 846)
<https://reviews.apache.org/r/47007/#comment197069>
Can you generate apt files?
Refer http://lens.apache.org/developer/contribute.html#How_to_update_the_config_docs
- Amareshwari Sriramadasu
On May 11, 2016, 2:26 p.m., Lavkesh Lahngir wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47007/
> -----------------------------------------------------------
>
> (Updated May 11, 2016, 2:26 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1019
> https://issues.apache.org/jira/browse/LENS-1019
>
>
> Repository: lens
>
>
> Description
> -------
>
> If query is repeated from user - with same query, same name, same conf on the same session
> and earlier is still queued or running, then return the same handle. This will only handle the case of aysnc queries.
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 7cf6449
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 2a11f97
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java b12943e
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 900770b
> lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java a6c7b13
> lens-server/src/main/resources/lensserver-default.xml 9580397
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 62c0280
>
> Diff: https://reviews.apache.org/r/47007/diff/
>
>
> Testing
> -------
>
> testExecuteAsyncDuplicate() methods tests the following.
> 1. Same query, same user and same session returns the same handle.
> 2. After query completion, same query firing will give the different handle.
> 3. Differnt session and same query will return different handle.
>
>
> Thanks,
>
> Lavkesh Lahngir
>
>
Re: Review Request 47007: Return same handle for repeated query from
same user
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47007/#review132891
-----------------------------------------------------------
We might have to disable this feature for test (in lens-server/src/test/resources/lens-site.xml). Many test cases fire the same query in same session and rely on it to create multiple queries in server.
- Puneet Gupta
On May 12, 2016, 10:05 a.m., Lavkesh Lahngir wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47007/
> -----------------------------------------------------------
>
> (Updated May 12, 2016, 10:05 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1019
> https://issues.apache.org/jira/browse/LENS-1019
>
>
> Repository: lens
>
>
> Description
> -------
>
> If query is repeated from user - with same query, same name, same conf on the same session
> and earlier is still queued or running, then return the same handle. This will only handle the case of aysnc queries.
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 7cf6449
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 2a11f97
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java b12943e
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 900770b
> lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java a6c7b13
> lens-server/src/main/resources/lensserver-default.xml 9580397
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 62c0280
> src/site/apt/admin/config.apt 4bf1e7c
>
> Diff: https://reviews.apache.org/r/47007/diff/
>
>
> Testing
> -------
>
> testExecuteAsyncDuplicate() methods tests the following.
> 1. Same query, same user and same session returns the same handle.
> 2. After query completion, same query firing will give the different handle.
> 3. Differnt session and same query will return different handle.
>
>
> Thanks,
>
> Lavkesh Lahngir
>
>
Re: Review Request 47007: Return same handle for repeated query from
same user
Posted by Lavkesh Lahngir <la...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47007/
-----------------------------------------------------------
(Updated May 12, 2016, 10:05 a.m.)
Review request for lens.
Changes
-------
Added apt file.
Bugs: LENS-1019
https://issues.apache.org/jira/browse/LENS-1019
Repository: lens
Description
-------
If query is repeated from user - with same query, same name, same conf on the same session
and earlier is still queued or running, then return the same handle. This will only handle the case of aysnc queries.
Diffs (updated)
-----
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 7cf6449
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 2a11f97
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java b12943e
lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 900770b
lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java a6c7b13
lens-server/src/main/resources/lensserver-default.xml 9580397
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 62c0280
src/site/apt/admin/config.apt 4bf1e7c
Diff: https://reviews.apache.org/r/47007/diff/
Testing
-------
testExecuteAsyncDuplicate() methods tests the following.
1. Same query, same user and same session returns the same handle.
2. After query completion, same query firing will give the different handle.
3. Differnt session and same query will return different handle.
Thanks,
Lavkesh Lahngir
Re: Review Request 47007: Return same handle for repeated query from
same user
Posted by Lavkesh Lahngir <la...@gmail.com>.
> On May 12, 2016, 6:08 a.m., Puneet Gupta wrote:
> > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java, line 1847
> > <https://reviews.apache.org/r/47007/diff/7/?file=1379662#file1379662line1847>
> >
> > Syncronize on sessionHandle also required. Please check.
If we lock the session, then only one query could be sumitted at one time.
If we don't lock the session then there could be cases where duplicate queries can be launched.
For now we could ignore this because locking session will increase the wait time of valid parallel query submissions.
- Lavkesh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47007/#review132830
-----------------------------------------------------------
On May 11, 2016, 2:26 p.m., Lavkesh Lahngir wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47007/
> -----------------------------------------------------------
>
> (Updated May 11, 2016, 2:26 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1019
> https://issues.apache.org/jira/browse/LENS-1019
>
>
> Repository: lens
>
>
> Description
> -------
>
> If query is repeated from user - with same query, same name, same conf on the same session
> and earlier is still queued or running, then return the same handle. This will only handle the case of aysnc queries.
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 7cf6449
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 2a11f97
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java b12943e
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 900770b
> lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java a6c7b13
> lens-server/src/main/resources/lensserver-default.xml 9580397
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 62c0280
>
> Diff: https://reviews.apache.org/r/47007/diff/
>
>
> Testing
> -------
>
> testExecuteAsyncDuplicate() methods tests the following.
> 1. Same query, same user and same session returns the same handle.
> 2. After query completion, same query firing will give the different handle.
> 3. Differnt session and same query will return different handle.
>
>
> Thanks,
>
> Lavkesh Lahngir
>
>
Re: Review Request 47007: Return same handle for repeated query from
same user
Posted by Puneet Gupta <pu...@gmail.com>.
> On May 12, 2016, 6:08 a.m., Puneet Gupta wrote:
> > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java, line 1847
> > <https://reviews.apache.org/r/47007/diff/7/?file=1379662#file1379662line1847>
> >
> > Syncronize on sessionHandle also required. Please check.
>
> Lavkesh Lahngir wrote:
> If we lock the session, then only one query could be sumitted at one time.
> If we don't lock the session then there could be cases where duplicate queries can be launched.
> For now we could ignore this because locking session will increase the wait time of valid parallel query submissions.
OK
- Puneet
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47007/#review132830
-----------------------------------------------------------
On May 11, 2016, 2:26 p.m., Lavkesh Lahngir wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47007/
> -----------------------------------------------------------
>
> (Updated May 11, 2016, 2:26 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1019
> https://issues.apache.org/jira/browse/LENS-1019
>
>
> Repository: lens
>
>
> Description
> -------
>
> If query is repeated from user - with same query, same name, same conf on the same session
> and earlier is still queued or running, then return the same handle. This will only handle the case of aysnc queries.
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 7cf6449
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 2a11f97
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java b12943e
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 900770b
> lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java a6c7b13
> lens-server/src/main/resources/lensserver-default.xml 9580397
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 62c0280
>
> Diff: https://reviews.apache.org/r/47007/diff/
>
>
> Testing
> -------
>
> testExecuteAsyncDuplicate() methods tests the following.
> 1. Same query, same user and same session returns the same handle.
> 2. After query completion, same query firing will give the different handle.
> 3. Differnt session and same query will return different handle.
>
>
> Thanks,
>
> Lavkesh Lahngir
>
>
Re: Review Request 47007: Return same handle for repeated query from
same user
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47007/#review132830
-----------------------------------------------------------
Fix it, then Ship it!
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 1847)
<https://reviews.apache.org/r/47007/#comment197082>
Syncronize on sessionHandle also required. Please check.
- Puneet Gupta
On May 11, 2016, 2:26 p.m., Lavkesh Lahngir wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47007/
> -----------------------------------------------------------
>
> (Updated May 11, 2016, 2:26 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1019
> https://issues.apache.org/jira/browse/LENS-1019
>
>
> Repository: lens
>
>
> Description
> -------
>
> If query is repeated from user - with same query, same name, same conf on the same session
> and earlier is still queued or running, then return the same handle. This will only handle the case of aysnc queries.
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 7cf6449
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 2a11f97
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java b12943e
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 900770b
> lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java a6c7b13
> lens-server/src/main/resources/lensserver-default.xml 9580397
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 62c0280
>
> Diff: https://reviews.apache.org/r/47007/diff/
>
>
> Testing
> -------
>
> testExecuteAsyncDuplicate() methods tests the following.
> 1. Same query, same user and same session returns the same handle.
> 2. After query completion, same query firing will give the different handle.
> 3. Differnt session and same query will return different handle.
>
>
> Thanks,
>
> Lavkesh Lahngir
>
>
Re: Review Request 47007: Return same handle for repeated query from
same user
Posted by Lavkesh Lahngir <la...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47007/
-----------------------------------------------------------
(Updated May 11, 2016, 2:26 p.m.)
Review request for lens.
Changes
-------
Synchronized on the activeQueries list, and other review comments.
Bugs: LENS-1019
https://issues.apache.org/jira/browse/LENS-1019
Repository: lens
Description
-------
If query is repeated from user - with same query, same name, same conf on the same session
and earlier is still queued or running, then return the same handle. This will only handle the case of aysnc queries.
Diffs (updated)
-----
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 7cf6449
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 2a11f97
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java b12943e
lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 900770b
lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java a6c7b13
lens-server/src/main/resources/lensserver-default.xml 9580397
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 62c0280
Diff: https://reviews.apache.org/r/47007/diff/
Testing
-------
testExecuteAsyncDuplicate() methods tests the following.
1. Same query, same user and same session returns the same handle.
2. After query completion, same query firing will give the different handle.
3. Differnt session and same query will return different handle.
Thanks,
Lavkesh Lahngir
Re: Review Request 47007: Return same handle for repeated query from
same user
Posted by Puneet Gupta <pu...@gmail.com>.
> On May 11, 2016, 10:37 a.m., Puneet Gupta wrote:
> > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java, line 1806
> > <https://reviews.apache.org/r/47007/diff/6/?file=1378034#file1378034line1806>
> >
> > executePrepareAsync() needs to be handled for duplicate query.
>
> Lavkesh Lahngir wrote:
> Should we do it in the next patch ??
ok
- Puneet
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47007/#review132635
-----------------------------------------------------------
On May 11, 2016, 2:26 p.m., Lavkesh Lahngir wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47007/
> -----------------------------------------------------------
>
> (Updated May 11, 2016, 2:26 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1019
> https://issues.apache.org/jira/browse/LENS-1019
>
>
> Repository: lens
>
>
> Description
> -------
>
> If query is repeated from user - with same query, same name, same conf on the same session
> and earlier is still queued or running, then return the same handle. This will only handle the case of aysnc queries.
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 7cf6449
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 2a11f97
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java b12943e
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 900770b
> lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java a6c7b13
> lens-server/src/main/resources/lensserver-default.xml 9580397
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 62c0280
>
> Diff: https://reviews.apache.org/r/47007/diff/
>
>
> Testing
> -------
>
> testExecuteAsyncDuplicate() methods tests the following.
> 1. Same query, same user and same session returns the same handle.
> 2. After query completion, same query firing will give the different handle.
> 3. Differnt session and same query will return different handle.
>
>
> Thanks,
>
> Lavkesh Lahngir
>
>
Re: Review Request 47007: Return same handle for repeated query from
same user
Posted by Lavkesh Lahngir <la...@gmail.com>.
> On May 11, 2016, 10:37 a.m., Puneet Gupta wrote:
> > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java, line 1806
> > <https://reviews.apache.org/r/47007/diff/6/?file=1378034#file1378034line1806>
> >
> > executePrepareAsync() needs to be handled for duplicate query.
Should we do it in the next patch ??
- Lavkesh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47007/#review132635
-----------------------------------------------------------
On May 10, 2016, 1:59 p.m., Lavkesh Lahngir wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47007/
> -----------------------------------------------------------
>
> (Updated May 10, 2016, 1:59 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1019
> https://issues.apache.org/jira/browse/LENS-1019
>
>
> Repository: lens
>
>
> Description
> -------
>
> If query is repeated from user - with same query, same name, same conf on the same session
> and earlier is still queued or running, then return the same handle. This will only handle the case of aysnc queries.
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 7cf6449
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 2a11f97
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java b12943e
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 900770b
> lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java a6c7b13
> lens-server/src/main/resources/lensserver-default.xml 9580397
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 62c0280
>
> Diff: https://reviews.apache.org/r/47007/diff/
>
>
> Testing
> -------
>
> testExecuteAsyncDuplicate() methods tests the following.
> 1. Same query, same user and same session returns the same handle.
> 2. After query completion, same query firing will give the different handle.
> 3. Differnt session and same query will return different handle.
>
>
> Thanks,
>
> Lavkesh Lahngir
>
>
Re: Review Request 47007: Return same handle for repeated query from
same user
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47007/#review132635
-----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 183)
<https://reviews.apache.org/r/47007/#comment196901>
Should we chnage the name to keep it in sync with property name ?
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 1310)
<https://reviews.apache.org/r/47007/#comment196902>
Do we need to call removeFromActiveQueries() in this case ?
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 1806)
<https://reviews.apache.org/r/47007/#comment196903>
executePrepareAsync() needs to be handled for duplicate query.
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 1814)
<https://reviews.apache.org/r/47007/#comment196904>
can we update cachedHandle variable name and log message as per the new property name
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 1841)
<https://reviews.apache.org/r/47007/#comment196905>
small Typo in method name
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 1844)
<https://reviews.apache.org/r/47007/#comment196906>
Synchronize based on session ?
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 1845)
<https://reviews.apache.org/r/47007/#comment196908>
We may get ConcurrentModificationException if add or remove active queries is called on LensSessionImpl.
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 1847)
<https://reviews.apache.org/r/47007/#comment196907>
First session check is not required
- Puneet Gupta
On May 10, 2016, 1:59 p.m., Lavkesh Lahngir wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47007/
> -----------------------------------------------------------
>
> (Updated May 10, 2016, 1:59 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1019
> https://issues.apache.org/jira/browse/LENS-1019
>
>
> Repository: lens
>
>
> Description
> -------
>
> If query is repeated from user - with same query, same name, same conf on the same session
> and earlier is still queued or running, then return the same handle. This will only handle the case of aysnc queries.
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 7cf6449
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 2a11f97
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java b12943e
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 900770b
> lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java a6c7b13
> lens-server/src/main/resources/lensserver-default.xml 9580397
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 62c0280
>
> Diff: https://reviews.apache.org/r/47007/diff/
>
>
> Testing
> -------
>
> testExecuteAsyncDuplicate() methods tests the following.
> 1. Same query, same user and same session returns the same handle.
> 2. After query completion, same query firing will give the different handle.
> 3. Differnt session and same query will return different handle.
>
>
> Thanks,
>
> Lavkesh Lahngir
>
>
Re: Review Request 47007: Return same handle for repeated query from
same user
Posted by Lavkesh Lahngir <la...@gmail.com>.
> On May 11, 2016, 9:26 a.m., Rajat Khandelwal wrote:
> > lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java, line 212
> > <https://reviews.apache.org/r/47007/diff/6/?file=1378036#file1378036line212>
> >
> > Returning null might make hash values equal for all configuration objects.
Arrays.equals() returns false if any of the parameters are null.
- Lavkesh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47007/#review132628
-----------------------------------------------------------
On May 10, 2016, 1:59 p.m., Lavkesh Lahngir wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47007/
> -----------------------------------------------------------
>
> (Updated May 10, 2016, 1:59 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1019
> https://issues.apache.org/jira/browse/LENS-1019
>
>
> Repository: lens
>
>
> Description
> -------
>
> If query is repeated from user - with same query, same name, same conf on the same session
> and earlier is still queued or running, then return the same handle. This will only handle the case of aysnc queries.
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 7cf6449
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 2a11f97
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java b12943e
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 900770b
> lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java a6c7b13
> lens-server/src/main/resources/lensserver-default.xml 9580397
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 62c0280
>
> Diff: https://reviews.apache.org/r/47007/diff/
>
>
> Testing
> -------
>
> testExecuteAsyncDuplicate() methods tests the following.
> 1. Same query, same user and same session returns the same handle.
> 2. After query completion, same query firing will give the different handle.
> 3. Differnt session and same query will return different handle.
>
>
> Thanks,
>
> Lavkesh Lahngir
>
>
Re: Review Request 47007: Return same handle for repeated query from
same user
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47007/#review132628
-----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java (line 203)
<https://reviews.apache.org/r/47007/#comment196891>
Can be generalized to take `Writable` argument and renaming to `hashWritable` or something.
lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java (line 212)
<https://reviews.apache.org/r/47007/#comment196892>
Returning null might make hash values equal for all configuration objects.
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java (lines 782 - 792)
<https://reviews.apache.org/r/47007/#comment196893>
Abstraction already available: `
RestAPITestUtil.executeAndGetHandle(target(), Optional.of(sesssionHandle), Optional.of("select * from " + TEST_TABLE), Optional.of(conf), mt);
- Rajat Khandelwal
On May 10, 2016, 7:29 p.m., Lavkesh Lahngir wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47007/
> -----------------------------------------------------------
>
> (Updated May 10, 2016, 7:29 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1019
> https://issues.apache.org/jira/browse/LENS-1019
>
>
> Repository: lens
>
>
> Description
> -------
>
> If query is repeated from user - with same query, same name, same conf on the same session
> and earlier is still queued or running, then return the same handle. This will only handle the case of aysnc queries.
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 7cf6449
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 2a11f97
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java b12943e
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 900770b
> lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java a6c7b13
> lens-server/src/main/resources/lensserver-default.xml 9580397
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 62c0280
>
> Diff: https://reviews.apache.org/r/47007/diff/
>
>
> Testing
> -------
>
> testExecuteAsyncDuplicate() methods tests the following.
> 1. Same query, same user and same session returns the same handle.
> 2. After query completion, same query firing will give the different handle.
> 3. Differnt session and same query will return different handle.
>
>
> Thanks,
>
> Lavkesh Lahngir
>
>
Re: Review Request 47007: Return same handle for repeated query from
same user
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47007/#review132613
-----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java (line 47)
<https://reviews.apache.org/r/47007/#comment196879>
Lets use @slf4j
- Amareshwari Sriramadasu
On May 10, 2016, 1:59 p.m., Lavkesh Lahngir wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47007/
> -----------------------------------------------------------
>
> (Updated May 10, 2016, 1:59 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1019
> https://issues.apache.org/jira/browse/LENS-1019
>
>
> Repository: lens
>
>
> Description
> -------
>
> If query is repeated from user - with same query, same name, same conf on the same session
> and earlier is still queued or running, then return the same handle. This will only handle the case of aysnc queries.
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 7cf6449
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 2a11f97
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java b12943e
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 900770b
> lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java a6c7b13
> lens-server/src/main/resources/lensserver-default.xml 9580397
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 62c0280
>
> Diff: https://reviews.apache.org/r/47007/diff/
>
>
> Testing
> -------
>
> testExecuteAsyncDuplicate() methods tests the following.
> 1. Same query, same user and same session returns the same handle.
> 2. After query completion, same query firing will give the different handle.
> 3. Differnt session and same query will return different handle.
>
>
> Thanks,
>
> Lavkesh Lahngir
>
>
Re: Review Request 47007: Return same handle for repeated query from
same user
Posted by Lavkesh Lahngir <la...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47007/
-----------------------------------------------------------
(Updated May 10, 2016, 1:59 p.m.)
Review request for lens.
Changes
-------
In sessionimpl, a list of active queries is added for quick access for queries from the same user.
Bugs: LENS-1019
https://issues.apache.org/jira/browse/LENS-1019
Repository: lens
Description
-------
If query is repeated from user - with same query, same name, same conf on the same session
and earlier is still queued or running, then return the same handle. This will only handle the case of aysnc queries.
Diffs (updated)
-----
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 7cf6449
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 2a11f97
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java b12943e
lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 900770b
lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java a6c7b13
lens-server/src/main/resources/lensserver-default.xml 9580397
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 62c0280
Diff: https://reviews.apache.org/r/47007/diff/
Testing
-------
testExecuteAsyncDuplicate() methods tests the following.
1. Same query, same user and same session returns the same handle.
2. After query completion, same query firing will give the different handle.
3. Differnt session and same query will return different handle.
Thanks,
Lavkesh Lahngir
Re: Review Request 47007: Return same handle for repeated query from
same user
Posted by Lavkesh Lahngir <la...@gmail.com>.
> On May 10, 2016, 2:56 a.m., Puneet Gupta wrote:
> > lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java, line 212
> > <https://reviews.apache.org/r/47007/diff/5/?file=1376859#file1376859line212>
> >
> > Should we return empty byte[] to prevent NP is code ?
Empty array could also be equal.. There won't be any nullpointer actually even we return null. Arrays.equals() returns false if any of the argument is null.
and setter will also not thorw nullpointer.
> On May 10, 2016, 2:56 a.m., Puneet Gupta wrote:
> > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java, line 847
> > <https://reviews.apache.org/r/47007/diff/5/?file=1376860#file1376860line847>
> >
> > What is the run time for this test case ? Is it possible to optimize to reduce the run time
> >
> > Instead of DeferredPersistentResultFormatter we can also use QueryExecutionServiceImpl#pauseQuerySubmitter. This will make sure query does not finish execution. See if this makes ur life simpler.
in my machine
mvn test -Dtest="TestQueryService#testExecuteAsyncDuplicate"
the module lens server took 01:31 min
After using pauseQuerySubmitter
- Lavkesh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47007/#review132366
-----------------------------------------------------------
On May 9, 2016, 5:24 p.m., Lavkesh Lahngir wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47007/
> -----------------------------------------------------------
>
> (Updated May 9, 2016, 5:24 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1019
> https://issues.apache.org/jira/browse/LENS-1019
>
>
> Repository: lens
>
>
> Description
> -------
>
> If query is repeated from user - with same query, same name, same conf on the same session
> and earlier is still queued or running, then return the same handle. This will only handle the case of aysnc queries.
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 23537cb
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 94b79d0
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 42bd4ab
> lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java a6c7b13
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java df13ba2
>
> Diff: https://reviews.apache.org/r/47007/diff/
>
>
> Testing
> -------
>
> testExecuteAsyncDuplicate() methods tests the following.
> 1. Same query, same user and same session returns the same handle.
> 2. After query completion, same query firing will give the different handle.
> 3. Differnt session and same query will return different handle.
>
>
> Thanks,
>
> Lavkesh Lahngir
>
>
Re: Review Request 47007: Return same handle for repeated query from
same user
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47007/#review132366
-----------------------------------------------------------
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java (line 149)
<https://reviews.apache.org/r/47007/#comment196548>
Please updated lensserver-default.xml also.
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java (line 150)
<https://reviews.apache.org/r/47007/#comment196549>
should we also mention same session, same name and same query parameters ?
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java (line 153)
<https://reviews.apache.org/r/47007/#comment196547>
should be change the name to
lens.server.duplicate.query.allowed
lens.server.optimise.on.duplicate.query
lens.server.use.first.query.for.duplicate.submission
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java (line 194)
<https://reviews.apache.org/r/47007/#comment196550>
should we rename this to queryConfigHash or just configHash ? This is hash of serverconfig + session config + query config
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 1780)
<https://reviews.apache.org/r/47007/#comment196551>
Should we change the name of the method checkQueryInCache()? Its slightly misleading.
Some options :
checkForRepeteadQuery().
chcekForDuplicateQuery().
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 1809)
<https://reviews.apache.org/r/47007/#comment196552>
Please update the code for TODO.
Please close the comments form previous reviews which are already addressed.
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 1810)
<https://reviews.apache.org/r/47007/#comment196553>
LENS-904 "Session handle not found" may store all the queries for a session. In that case we can just iterate over the session specific queries.
Need to confirm this with Rajat.
lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java (line 212)
<https://reviews.apache.org/r/47007/#comment196554>
Should we return empty byte[] to prevent NP is code ?
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java (line 756)
<https://reviews.apache.org/r/47007/#comment196555>
I think we can just test for one media type (XML). This will save some test time. Other test cases are already testing all media types for the APIs used in this test case. @Rajat/Amareshwari ... thoughts ?
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java (line 783)
<https://reviews.apache.org/r/47007/#comment196556>
This is not a guaranteed operation., depends on the stage in which query is.
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java (line 787)
<https://reviews.apache.org/r/47007/#comment196557>
can we wait for handle1/2 to finish rather than firing one more query ?
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java (line 801)
<https://reviews.apache.org/r/47007/#comment196560>
Should we also test how query configuration affects the handling of duplicate query?
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java (line 807)
<https://reviews.apache.org/r/47007/#comment196558>
+1 for comments
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java (line 847)
<https://reviews.apache.org/r/47007/#comment196559>
What is the run time for this test case ? Is it possible to optimize to reduce the run time
Instead of DeferredPersistentResultFormatter we can also use QueryExecutionServiceImpl#pauseQuerySubmitter. This will make sure query does not finish execution. See if this makes ur life simpler.
- Puneet Gupta
On May 9, 2016, 5:24 p.m., Lavkesh Lahngir wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47007/
> -----------------------------------------------------------
>
> (Updated May 9, 2016, 5:24 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1019
> https://issues.apache.org/jira/browse/LENS-1019
>
>
> Repository: lens
>
>
> Description
> -------
>
> If query is repeated from user - with same query, same name, same conf on the same session
> and earlier is still queued or running, then return the same handle. This will only handle the case of aysnc queries.
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 23537cb
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 94b79d0
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 42bd4ab
> lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java a6c7b13
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java df13ba2
>
> Diff: https://reviews.apache.org/r/47007/diff/
>
>
> Testing
> -------
>
> testExecuteAsyncDuplicate() methods tests the following.
> 1. Same query, same user and same session returns the same handle.
> 2. After query completion, same query firing will give the different handle.
> 3. Differnt session and same query will return different handle.
>
>
> Thanks,
>
> Lavkesh Lahngir
>
>
Re: Review Request 47007: Return same handle for repeated query from
same user
Posted by Lavkesh Lahngir <la...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47007/
-----------------------------------------------------------
(Updated May 9, 2016, 5:24 p.m.)
Review request for lens.
Changes
-------
Removed unrequired things.
Bugs: LENS-1019
https://issues.apache.org/jira/browse/LENS-1019
Repository: lens
Description
-------
If query is repeated from user - with same query, same name, same conf on the same session
and earlier is still queued or running, then return the same handle. This will only handle the case of aysnc queries.
Diffs (updated)
-----
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 23537cb
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 94b79d0
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 42bd4ab
lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java a6c7b13
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java df13ba2
Diff: https://reviews.apache.org/r/47007/diff/
Testing
-------
testExecuteAsyncDuplicate() methods tests the following.
1. Same query, same user and same session returns the same handle.
2. After query completion, same query firing will give the different handle.
3. Differnt session and same query will return different handle.
Thanks,
Lavkesh Lahngir
Re: Review Request 47007: Return same handle for repeated query from
same user
Posted by Lavkesh Lahngir <la...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47007/
-----------------------------------------------------------
(Updated May 9, 2016, 2:38 p.m.)
Review request for lens.
Bugs: LENS-1019
https://issues.apache.org/jira/browse/LENS-1019
Repository: lens
Description
-------
If query is repeated from user - with same query, same name, same conf on the same session
and earlier is still queued or running, then return the same handle. This will only handle the case of aysnc queries.
Diffs (updated)
-----
lens-api/pom.xml 9b5e5f8
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 23537cb
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 94b79d0
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 42bd4ab
lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java a6c7b13
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java df13ba2
Diff: https://reviews.apache.org/r/47007/diff/
Testing
-------
testExecuteAsyncDuplicate() methods tests the following.
1. Same query, same user and same session returns the same handle.
2. After query completion, same query firing will give the different handle.
3. Differnt session and same query will return different handle.
Thanks,
Lavkesh Lahngir
Re: Review Request 47007: Return same handle for repeated query from
same user
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47007/#review132255
-----------------------------------------------------------
lens-api/pom.xml (line 38)
<https://reviews.apache.org/r/47007/#comment196450>
why are we putting hadoop-client dependency on lens-api ?
lens-api will be client facing and it should not bring hadoop-client dependency here.
lens-api/src/main/java/org/apache/lens/api/util/CommonUtils.java (line 98)
<https://reviews.apache.org/r/47007/#comment196451>
Lets move the utils to LensUtil in lens-server-api
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 1796)
<https://reviews.apache.org/r/47007/#comment196453>
Shall we have the feature enable or disable at server side?
- Amareshwari Sriramadasu
On May 9, 2016, 11:59 a.m., Lavkesh Lahngir wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47007/
> -----------------------------------------------------------
>
> (Updated May 9, 2016, 11:59 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1019
> https://issues.apache.org/jira/browse/LENS-1019
>
>
> Repository: lens
>
>
> Description
> -------
>
> If query is repeated from user - with same query, same name, same conf on the same session
> and earlier is still queued or running, then return the same handle. This will only handle the case of aysnc queries.
>
>
> Diffs
> -----
>
> lens-api/pom.xml 9b5e5f8
> lens-api/src/main/java/org/apache/lens/api/util/CommonUtils.java 119c924
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 94b79d0
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 42bd4ab
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java df13ba2
>
> Diff: https://reviews.apache.org/r/47007/diff/
>
>
> Testing
> -------
>
> testExecuteAsyncDuplicate() methods tests the following.
> 1. Same query, same user and same session returns the same handle.
> 2. After query completion, same query firing will give the different handle.
> 3. Differnt session and same query will return different handle.
>
>
> Thanks,
>
> Lavkesh Lahngir
>
>
Re: Review Request 47007: Return same handle for repeated query from
same user
Posted by Lavkesh Lahngir <la...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47007/
-----------------------------------------------------------
(Updated May 9, 2016, 11:59 a.m.)
Review request for lens.
Changes
-------
1. Hash has the byte array instead of the String.
2. Hash the Configuration object instead of LensConf.
Bugs: LENS-1019
https://issues.apache.org/jira/browse/LENS-1019
Repository: lens
Description
-------
If query is repeated from user - with same query, same name, same conf on the same session
and earlier is still queued or running, then return the same handle. This will only handle the case of aysnc queries.
Diffs (updated)
-----
lens-api/pom.xml 9b5e5f8
lens-api/src/main/java/org/apache/lens/api/util/CommonUtils.java 119c924
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 94b79d0
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 42bd4ab
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java df13ba2
Diff: https://reviews.apache.org/r/47007/diff/
Testing
-------
testExecuteAsyncDuplicate() methods tests the following.
1. Same query, same user and same session returns the same handle.
2. After query completion, same query firing will give the different handle.
3. Differnt session and same query will return different handle.
Thanks,
Lavkesh Lahngir
Re: Review Request 47007: Return same handle for repeated query from
same user
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47007/#review132239
-----------------------------------------------------------
lens-api/src/main/java/org/apache/lens/api/LensConf.java (line 123)
<https://reviews.apache.org/r/47007/#comment196431>
Can we use byte[] itself ?
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 1773)
<https://reviews.apache.org/r/47007/#comment196424>
Should we log user also? Might help with debugging.
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 1799)
<https://reviews.apache.org/r/47007/#comment196433>
We need hash of Configuration( LensConf will not have session info)
- Puneet Gupta
On May 9, 2016, 9:41 a.m., Lavkesh Lahngir wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47007/
> -----------------------------------------------------------
>
> (Updated May 9, 2016, 9:41 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1019
> https://issues.apache.org/jira/browse/LENS-1019
>
>
> Repository: lens
>
>
> Description
> -------
>
> If query is repeated from user - with same query, same name, same conf on the same session
> and earlier is still queued or running, then return the same handle. This will only handle the case of aysnc queries.
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/LensConf.java 86504c7
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 94b79d0
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 42bd4ab
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java df13ba2
>
> Diff: https://reviews.apache.org/r/47007/diff/
>
>
> Testing
> -------
>
> testExecuteAsyncDuplicate() methods tests the following.
> 1. Same query, same user and same session returns the same handle.
> 2. After query completion, same query firing will give the different handle.
> 3. Differnt session and same query will return different handle.
>
>
> Thanks,
>
> Lavkesh Lahngir
>
>
Re: Review Request 47007: Return same handle for repeated query from
same user
Posted by Lavkesh Lahngir <la...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47007/
-----------------------------------------------------------
(Updated May 9, 2016, 9:41 a.m.)
Review request for lens.
Changes
-------
Review comments. Checking the query name, storing the hash of the lensconf.
Bugs: LENS-1019
https://issues.apache.org/jira/browse/LENS-1019
Repository: lens
Description
-------
If query is repeated from user - with same query, same name, same conf on the same session
and earlier is still queued or running, then return the same handle. This will only handle the case of aysnc queries.
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/LensConf.java 86504c7
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 94b79d0
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 42bd4ab
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java df13ba2
Diff: https://reviews.apache.org/r/47007/diff/
Testing
-------
testExecuteAsyncDuplicate() methods tests the following.
1. Same query, same user and same session returns the same handle.
2. After query completion, same query firing will give the different handle.
3. Differnt session and same query will return different handle.
Thanks,
Lavkesh Lahngir
Re: Review Request 47007: Return same handle for repeated query from
same user
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On May 5, 2016, 12:14 p.m., Puneet Gupta wrote:
> > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java, line 1797
> > <https://reviews.apache.org/r/47007/diff/1/?file=1372924#file1372924line1797>
> >
> > Some more things that we need to decide on
> >
> > 1. What do we do if the partition for a query is re-registered /dropped
> >
> > 2. Data changes on stoarge will not be handled
> >
> > 3. Session conf may also get updated between requests. How do we handle that
User can cancel earlier queued or running query, before submitting again, in all the above cases - If it is a genuine resubmission.
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47007/#review131812
-----------------------------------------------------------
On May 5, 2016, 10:26 a.m., Lavkesh Lahngir wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47007/
> -----------------------------------------------------------
>
> (Updated May 5, 2016, 10:26 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1019
> https://issues.apache.org/jira/browse/LENS-1019
>
>
> Repository: lens
>
>
> Description
> -------
>
> If query is repeated from user - with same query, same name, same conf on the same session
> and earlier is still queued or running, then return the same handle. This will only handle the case of aysnc queries.
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/LensConf.java 86504c7
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 42bd4ab
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java df13ba2
>
> Diff: https://reviews.apache.org/r/47007/diff/
>
>
> Testing
> -------
>
> testExecuteAsyncDuplicate() methods tests the following.
> 1. Same query, same user and same session returns the same handle.
> 2. After query completion, same query firing will give the different handle.
> 3. Differnt session and same query will return different handle.
>
>
> Thanks,
>
> Lavkesh Lahngir
>
>
Re: Review Request 47007: Return same handle for repeated query from
same user
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47007/#review131812
-----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 1764)
<https://reviews.apache.org/r/47007/#comment195844>
We need to handle executePrepareAsync also.
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 1773)
<https://reviews.apache.org/r/47007/#comment195843>
Lets info log when this optimization is applied
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 1792)
<https://reviews.apache.org/r/47007/#comment195840>
This TODO will be required especially to ensure we don't miss this optimization on parallel requests.
We can synchronize on session
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 1795)
<https://reviews.apache.org/r/47007/#comment195842>
Some more things that we need to decide on
1. What do we do if the partition for a query is re-registered /dropped
2. Data changes on stoarge will not be handled
3. Session conf may also get updated between requests. How do we handle that
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 1796)
<https://reviews.apache.org/r/47007/#comment195841>
qconf.equals(context.getLensConf()) will not work since LensConf has extra information( which may come form Driver Hooks)
- Puneet Gupta
On May 5, 2016, 10:26 a.m., Lavkesh Lahngir wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47007/
> -----------------------------------------------------------
>
> (Updated May 5, 2016, 10:26 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1019
> https://issues.apache.org/jira/browse/LENS-1019
>
>
> Repository: lens
>
>
> Description
> -------
>
> If query is repeated from user - with same query, same name, same conf on the same session
> and earlier is still queued or running, then return the same handle. This will only handle the case of aysnc queries.
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/LensConf.java 86504c7
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 42bd4ab
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java df13ba2
>
> Diff: https://reviews.apache.org/r/47007/diff/
>
>
> Testing
> -------
>
> testExecuteAsyncDuplicate() methods tests the following.
> 1. Same query, same user and same session returns the same handle.
> 2. After query completion, same query firing will give the different handle.
> 3. Differnt session and same query will return different handle.
>
>
> Thanks,
>
> Lavkesh Lahngir
>
>
Re: Review Request 47007: Return same handle for repeated query from
same user
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47007/#review132080
-----------------------------------------------------------
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java (lines 22 - 74)
<https://reviews.apache.org/r/47007/#comment196140>
These will cause checkstyle errors.
- Rajat Khandelwal
On May 5, 2016, 3:56 p.m., Lavkesh Lahngir wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47007/
> -----------------------------------------------------------
>
> (Updated May 5, 2016, 3:56 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1019
> https://issues.apache.org/jira/browse/LENS-1019
>
>
> Repository: lens
>
>
> Description
> -------
>
> If query is repeated from user - with same query, same name, same conf on the same session
> and earlier is still queued or running, then return the same handle. This will only handle the case of aysnc queries.
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/LensConf.java 86504c7
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 42bd4ab
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java df13ba2
>
> Diff: https://reviews.apache.org/r/47007/diff/
>
>
> Testing
> -------
>
> testExecuteAsyncDuplicate() methods tests the following.
> 1. Same query, same user and same session returns the same handle.
> 2. After query completion, same query firing will give the different handle.
> 3. Differnt session and same query will return different handle.
>
>
> Thanks,
>
> Lavkesh Lahngir
>
>
Re: Review Request 47007: Return same handle for repeated query from
same user
Posted by Sushil Mohanty <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47007/#review131810
-----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 1772)
<https://reviews.apache.org/r/47007/#comment195836>
Check style error 'if' construct must use '{}'s
- Sushil Mohanty
On May 5, 2016, 10:26 a.m., Lavkesh Lahngir wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47007/
> -----------------------------------------------------------
>
> (Updated May 5, 2016, 10:26 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1019
> https://issues.apache.org/jira/browse/LENS-1019
>
>
> Repository: lens
>
>
> Description
> -------
>
> If query is repeated from user - with same query, same name, same conf on the same session
> and earlier is still queued or running, then return the same handle. This will only handle the case of aysnc queries.
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/LensConf.java 86504c7
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 42bd4ab
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java df13ba2
>
> Diff: https://reviews.apache.org/r/47007/diff/
>
>
> Testing
> -------
>
> testExecuteAsyncDuplicate() methods tests the following.
> 1. Same query, same user and same session returns the same handle.
> 2. After query completion, same query firing will give the different handle.
> 3. Differnt session and same query will return different handle.
>
>
> Thanks,
>
> Lavkesh Lahngir
>
>