You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by da...@apache.org on 2022/01/01 17:13:16 UTC

[camel] 02/04: CAMEL-17403: camel-core - Dump route as xml include source location:line if debugger enabled

This is an automated email from the ASF dual-hosted git repository.

davsclaus pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git

commit 761ac5a5cf4f8256eb1e1d9a7192090658d8916a
Author: Claus Ibsen <cl...@gmail.com>
AuthorDate: Sat Jan 1 18:08:38 2022 +0100

    CAMEL-17403: camel-core - Dump route as xml include source location:line if debugger enabled
---
 .../org/apache/camel/util/DumpModelAsXmlSourceLocationTest.java   | 8 +++++---
 .../camel/api/management/mbean/ManagedCamelContextMBean.java      | 1 +
 .../org/apache/camel/management/mbean/ManagedCamelContext.java    | 1 +
 3 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/core/camel-core/src/test/java/org/apache/camel/util/DumpModelAsXmlSourceLocationTest.java b/core/camel-core/src/test/java/org/apache/camel/util/DumpModelAsXmlSourceLocationTest.java
index cb9cb9f..12964d8 100644
--- a/core/camel-core/src/test/java/org/apache/camel/util/DumpModelAsXmlSourceLocationTest.java
+++ b/core/camel-core/src/test/java/org/apache/camel/util/DumpModelAsXmlSourceLocationTest.java
@@ -41,7 +41,8 @@ public class DumpModelAsXmlSourceLocationTest extends ContextTestSupport {
         assertNotNull(xml);
         log.info(xml);
 
-        Assertions.assertTrue(xml.contains("sourceLineNumber=\"64\" sourceLocation=\"org.apache.camel.util.DumpModelAsXmlSourceLocationTest$1\""));
+        Assertions.assertTrue(xml.contains(
+                "sourceLineNumber=\"64\" sourceLocation=\"org.apache.camel.util.DumpModelAsXmlSourceLocationTest$1\""));
     }
 
     @Test
@@ -51,13 +52,14 @@ public class DumpModelAsXmlSourceLocationTest extends ContextTestSupport {
         assertNotNull(xml);
         log.info(xml);
 
-        Assertions.assertTrue(xml.contains("<from sourceLineNumber=\"25\" sourceLocation=\"org.apache.camel.util.MyCoolRoute\" uri=\"direct:cool\"/>"));
+        Assertions.assertTrue(xml.contains(
+                "<from sourceLineNumber=\"25\" sourceLocation=\"org.apache.camel.util.MyCoolRoute\" uri=\"direct:cool\"/>"));
         Assertions.assertTrue(xml.contains("sourceLineNumber=\"26\" sourceLocation=\"org.apache.camel.util.MyCoolRoute\""));
     }
 
     @Override
     protected RouteBuilder[] createRouteBuilders() throws Exception {
-        return new RouteBuilder[]{
+        return new RouteBuilder[] {
                 new RouteBuilder() {
                     @Override
                     public void configure() throws Exception {
diff --git a/core/camel-management-api/src/main/java/org/apache/camel/api/management/mbean/ManagedCamelContextMBean.java b/core/camel-management-api/src/main/java/org/apache/camel/api/management/mbean/ManagedCamelContextMBean.java
index ef78ac3..ce040c5 100644
--- a/core/camel-management-api/src/main/java/org/apache/camel/api/management/mbean/ManagedCamelContextMBean.java
+++ b/core/camel-management-api/src/main/java/org/apache/camel/api/management/mbean/ManagedCamelContextMBean.java
@@ -205,6 +205,7 @@ public interface ManagedCamelContextMBean extends ManagedPerformanceCounterMBean
     String dumpRouteTemplatesAsXml() throws Exception;
 
     @ManagedOperation(description = "Dumps all routes with mappings between node ids and their source location/line-number (currently only XML and YAML routes supported) as XML")
+    @Deprecated
     String dumpRoutesSourceLocationsAsXml() throws Exception;
 
     /**
diff --git a/core/camel-management/src/main/java/org/apache/camel/management/mbean/ManagedCamelContext.java b/core/camel-management/src/main/java/org/apache/camel/management/mbean/ManagedCamelContext.java
index 94fc7b5..b9ea91e 100644
--- a/core/camel-management/src/main/java/org/apache/camel/management/mbean/ManagedCamelContext.java
+++ b/core/camel-management/src/main/java/org/apache/camel/management/mbean/ManagedCamelContext.java
@@ -619,6 +619,7 @@ public class ManagedCamelContext extends ManagedPerformanceCounter implements Ti
     }
 
     @Override
+    @Deprecated
     public String dumpRoutesSourceLocationsAsXml() throws Exception {
         StringBuilder sb = new StringBuilder();
         sb.append("<routeLocations>");