You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by GitBox <gi...@apache.org> on 2022/04/05 20:20:52 UTC

[GitHub] [incubator-shenyu] Mayank-KS opened a new pull request, #3197: [type: refactor #3088] Format data-permission-sqlmap.xml

Mayank-KS opened a new pull request, #3197:
URL: https://github.com/apache/incubator-shenyu/pull/3197

   Format SQL to improve code readability in shenyu-admin.
   Format data-permission-sqlmap.xml
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shenyu] Mayank-KS commented on pull request #3197: [type: refactor #3088] Format data-permission-sqlmap.xml

Posted by GitBox <gi...@apache.org>.
Mayank-KS commented on PR #3197:
URL: https://github.com/apache/incubator-shenyu/pull/3197#issuecomment-1091628931

   WeChat is banned in my country, so is there any other platform where I can join and interact like slack, discord or telegram?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shenyu] Mayank-KS closed pull request #3197: [type: refactor #3088] Format data-permission-sqlmap.xml

Posted by GitBox <gi...@apache.org>.
Mayank-KS closed pull request #3197: [type: refactor #3088] Format data-permission-sqlmap.xml
URL: https://github.com/apache/incubator-shenyu/pull/3197


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shenyu] Mayank-KS commented on pull request #3197: [type: refactor #3088] Format data-permission-sqlmap.xml

Posted by GitBox <gi...@apache.org>.
Mayank-KS commented on PR #3197:
URL: https://github.com/apache/incubator-shenyu/pull/3197#issuecomment-1094006683

   @midnight2104 please give some update
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shenyu] midnight2104 commented on pull request #3197: [type: refactor #3088] Format data-permission-sqlmap.xml

Posted by GitBox <gi...@apache.org>.
midnight2104 commented on PR #3197:
URL: https://github.com/apache/incubator-shenyu/pull/3197#issuecomment-1091515732

   Good job. If you want, you can add me on WeChat `LL332595980` and invite you to join the shenyu contributor group.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shenyu] codecov-commenter commented on pull request #3197: [type: refactor #3088] Format data-permission-sqlmap.xml

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #3197:
URL: https://github.com/apache/incubator-shenyu/pull/3197#issuecomment-1089800350

   # [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/3197?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#3197](https://codecov.io/gh/apache/incubator-shenyu/pull/3197?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (caf0738) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/7ea9bdfd2b14a4b9abdff8be960d89e2f0374205?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7ea9bdf) will **increase** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@            Coverage Diff            @@
   ##             master    #3197   +/-   ##
   =========================================
     Coverage     57.62%   57.63%           
     Complexity     4546     4546           
   =========================================
     Files           730      730           
     Lines         20818    20818           
     Branches       1915     1915           
   =========================================
   + Hits          11997    11998    +1     
   + Misses         7761     7759    -2     
   - Partials       1060     1061    +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/3197?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...henyu/plugin/grpc/resolver/ShenyuNameResolver.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3197/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9yZXNvbHZlci9TaGVueXVOYW1lUmVzb2x2ZXIuamF2YQ==) | `62.76% <0.00%> (-1.07%)` | :arrow_down: |
   | [...gin/apache/dubbo/cache/ApacheDubboConfigCache.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3197/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWR1YmJvL3NoZW55dS1wbHVnaW4tYXBhY2hlLWR1YmJvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcGx1Z2luL2FwYWNoZS9kdWJiby9jYWNoZS9BcGFjaGVEdWJib0NvbmZpZ0NhY2hlLmphdmE=) | `75.28% <0.00%> (+1.12%)` | :arrow_up: |
   | [...n/alibaba/dubbo/cache/AlibabaDubboConfigCache.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3197/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWR1YmJvL3NoZW55dS1wbHVnaW4tYWxpYmFiYS1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9hbGliYWJhL2R1YmJvL2NhY2hlL0FsaWJhYmFEdWJib0NvbmZpZ0NhY2hlLmphdmE=) | `77.01% <0.00%> (+1.14%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/3197?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/3197?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b2309bf...caf0738](https://codecov.io/gh/apache/incubator-shenyu/pull/3197?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shenyu] midnight2104 commented on a diff in pull request #3197: [type: refactor #3088] Format data-permission-sqlmap.xml

Posted by GitBox <gi...@apache.org>.
midnight2104 commented on code in PR #3197:
URL: https://github.com/apache/incubator-shenyu/pull/3197#discussion_r843446386


##########
shenyu-admin/src/main/resources/mappers/data-permission-sqlmap.xml:
##########
@@ -28,24 +28,34 @@
     </resultMap>
 
     <sql id="Base_Column_List">
-        id, date_created, date_updated, user_id, data_id, data_type
+        id, 
+        date_created, 
+        date_updated, 
+        user_id, 
+        data_id, 
+        data_type
     </sql>
 
     <delete id="deleteByUniqueKey">
-        delete from data_permission where data_id = #{dataId, jdbcType=VARCHAR}
-        and user_id = #{userId,jdbcType=VARCHAR} and data_type = #{dataType,jdbcType=INTEGER}
+        delete from data_permission 

Review Comment:
   - The keywords  should be Uppercase;
   -  Keep keywords right aligned；
   -  Keep fields left aligned；



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shenyu] Mayank-KS commented on pull request #3197: [type: refactor #3088] Format data-permission-sqlmap.xml

Posted by GitBox <gi...@apache.org>.
Mayank-KS commented on PR #3197:
URL: https://github.com/apache/incubator-shenyu/pull/3197#issuecomment-1089892787

   done with the changes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shenyu] midnight2104 merged pull request #3197: [type: refactor #3088] Format data-permission-sqlmap.xml

Posted by GitBox <gi...@apache.org>.
midnight2104 merged PR #3197:
URL: https://github.com/apache/incubator-shenyu/pull/3197


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org