[GitHub] [spark] viirya commented on a change in pull request #35238: [SPARK-36649][SQL] Support `Trigger.AvailableNow` on Kafka data source

[GitBox <gi...@apache.org>]

viirya commented on a change in pull request #35238:
URL: https://github.com/apache/spark/pull/35238#discussion_r788527444



##########
File path: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaMicroBatchStream.scala
##########
@@ -98,7 +100,10 @@ private[kafka010] class KafkaMicroBatchStream(
     } else if (minOffsetPerTrigger.isDefined) {
       ReadLimit.minRows(minOffsetPerTrigger.get, maxTriggerDelayMs)
     } else {
-      maxOffsetsPerTrigger.map(ReadLimit.maxRows).getOrElse(super.getDefaultReadLimit)
+      // Calling ReadLimit.allAvailable() explicitly instead of super.getDefaultReadLimit because
+      // scala compiler bug https://github.com/scala/bug/issues/12523
+      // TODO revert to calling super.getDefaultReadLimit when scala complier bug is fixed

Review comment:
       It is better to create a JIRA ticket and add into the comment here for tracking it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org