You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by br...@apache.org on 2012/01/27 06:18:49 UTC

svn commit: r1236531 - /trafficserver/traffic/branches/3.0.x/STATUS

Author: briang
Date: Fri Jan 27 05:18:48 2012
New Revision: 1236531

URL: http://svn.apache.org/viewvc?rev=1236531&view=rev
Log:
Added new proposasls for backport

Modified:
    trafficserver/traffic/branches/3.0.x/STATUS

Modified: trafficserver/traffic/branches/3.0.x/STATUS
URL: http://svn.apache.org/viewvc/trafficserver/traffic/branches/3.0.x/STATUS?rev=1236531&r1=1236530&r2=1236531&view=diff
==============================================================================
--- trafficserver/traffic/branches/3.0.x/STATUS (original)
+++ trafficserver/traffic/branches/3.0.x/STATUS Fri Jan 27 05:18:48 2012
@@ -84,6 +84,22 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK:
    Jira: https://issues.apache.org/jira/browse/TS-1049
    +1: zwoop
 
+  *) PluginVC should schedule to the local queue instead of the external queue.
+   Trunk patch: http://svn.apache.org/viewvc?view=revision&revision=1228526
+   Jira: https://issues.apache.org/jira/browse/TS-1074
+   +1: briang
+
+  *) Transformation plugins cause connection close when content length is not known ahead
+   Trunk patch: http://svn.apache.org/viewvc?view=revision&revision=1197133
+   Jira: https://issues.apache.org/jira/browse/TS-1004
+   +1: briang
+
+  *) HTTP: forward map based on request receive port.
+   Trunk patch: http://svn.apache.org/viewvc?view=revision&revision=1159440
+                http://svn.apache.org/viewvc?view=revision&revision=1159655
+   Jira: https://issues.apache.org/jira/browse/TS-876
+   +1: briang 
+
 
 RELEASE PROCESS
 



Re: svn commit: r1236531 - /trafficserver/traffic/branches/3.0.x/STATUS

Posted by Brian Geffon <br...@gmail.com>.
Ok, I've created a new patch that merges both commits, i'll re-add to
STATUS.

Brian

On Fri, Jan 27, 2012 at 3:46 PM, Brian Geffon <br...@gmail.com> wrote:

> So from what I can tell, the frequent_accept deal was not for TS-876, it
> was for TS-919, in the following commit:
> http://svn.apache.org/viewvc?view=revision&revision=1159655. So the fix
> he committed for TS-876 was in UrlRewrite.cc and was a missing constructor
> initialization. So I'll submit a new patch that doesn't merge the fixes for
> two different bugs and add it back into STATUS.
>
> So since all the correct code is already in trunk for TS-876 should I just
> leave a note in STATUS that points to the Jira for the correct patch?
>
> Brian
>
>
> 2012/1/27 Igor Galić <i....@brainsware.org>
>
>>
>>
>> ----- Original Message -----
>> > On 01/27/2012 02:04 AM, Igor Galić wrote:
>> > >
>> > > This one changes frequent_accept from a default of true to false
>> > > which
>> > > is one of the things that gave amc so much headache over TS-1077,
>> > > so I'm
>> > > a little ambivalent.
>> > >
>> > >
>> >
>> > Yes. Unless the logic around the accept code is also modified,
>> > changing
>> > frequent_accept from true to false is bad mojo (it would disable
>> > multiple accept threads for example, and never allow accept on the
>> > net-threads).
>>
>> ACK.
>>
>> Brian, can you fix this up and propose your own patch?
>>
>> > -- leif
>>
>> i
>>
>> --
>> Igor Galić
>>
>> Tel: +43 (0) 664 886 22 883
>> Mail: i.galic@brainsware.org
>> URL: http://brainsware.org/
>> GPG: 6880 4155 74BD FD7C B515  2EA5 4B1D 9E08 A097 C9AE
>>
>>
>

Re: svn commit: r1236531 - /trafficserver/traffic/branches/3.0.x/STATUS

Posted by Brian Geffon <br...@gmail.com>.
So from what I can tell, the frequent_accept deal was not for TS-876, it
was for TS-919, in the following commit:
http://svn.apache.org/viewvc?view=revision&revision=1159655. So the fix he
committed for TS-876 was in UrlRewrite.cc and was a missing constructor
initialization. So I'll submit a new patch that doesn't merge the fixes for
two different bugs and add it back into STATUS.

So since all the correct code is already in trunk for TS-876 should I just
leave a note in STATUS that points to the Jira for the correct patch?

Brian

2012/1/27 Igor Galić <i....@brainsware.org>

>
>
> ----- Original Message -----
> > On 01/27/2012 02:04 AM, Igor Galić wrote:
> > >
> > > This one changes frequent_accept from a default of true to false
> > > which
> > > is one of the things that gave amc so much headache over TS-1077,
> > > so I'm
> > > a little ambivalent.
> > >
> > >
> >
> > Yes. Unless the logic around the accept code is also modified,
> > changing
> > frequent_accept from true to false is bad mojo (it would disable
> > multiple accept threads for example, and never allow accept on the
> > net-threads).
>
> ACK.
>
> Brian, can you fix this up and propose your own patch?
>
> > -- leif
>
> i
>
> --
> Igor Galić
>
> Tel: +43 (0) 664 886 22 883
> Mail: i.galic@brainsware.org
> URL: http://brainsware.org/
> GPG: 6880 4155 74BD FD7C B515  2EA5 4B1D 9E08 A097 C9AE
>
>

Re: svn commit: r1236531 - /trafficserver/traffic/branches/3.0.x/STATUS

Posted by Igor Galić <i....@brainsware.org>.

----- Original Message -----
> On 01/27/2012 02:04 AM, Igor Galić wrote:
> >
> > This one changes frequent_accept from a default of true to false
> > which
> > is one of the things that gave amc so much headache over TS-1077,
> > so I'm
> > a little ambivalent.
> >
> >
> 
> Yes. Unless the logic around the accept code is also modified,
> changing
> frequent_accept from true to false is bad mojo (it would disable
> multiple accept threads for example, and never allow accept on the
> net-threads).

ACK.

Brian, can you fix this up and propose your own patch?

> -- leif

i

-- 
Igor Galić

Tel: +43 (0) 664 886 22 883
Mail: i.galic@brainsware.org
URL: http://brainsware.org/
GPG: 6880 4155 74BD FD7C B515  2EA5 4B1D 9E08 A097 C9AE


Re: svn commit: r1236531 - /trafficserver/traffic/branches/3.0.x/STATUS

Posted by Leif Hedstrom <zw...@apache.org>.
On 01/27/2012 02:04 AM, Igor Galić wrote:
>
> This one changes frequent_accept from a default of true to false which
> is one of the things that gave amc so much headache over TS-1077, so I'm
> a little ambivalent.
>
>

Yes. Unless the logic around the accept code is also modified, changing 
frequent_accept from true to false is bad mojo (it would disable 
multiple accept threads for example, and never allow accept on the 
net-threads).

-- leif


Re: svn commit: r1236531 - /trafficserver/traffic/branches/3.0.x/STATUS

Posted by Igor Galić <i....@brainsware.org>.

----- Original Message -----
> Author: briang
> Date: Fri Jan 27 05:18:48 2012
> New Revision: 1236531
> 
> URL: http://svn.apache.org/viewvc?rev=1236531&view=rev
> Log:
> Added new proposasls for backport
> 
> Modified:
>     trafficserver/traffic/branches/3.0.x/STATUS
> 
> Modified: trafficserver/traffic/branches/3.0.x/STATUS
> URL:
> http://svn.apache.org/viewvc/trafficserver/traffic/branches/3.0.x/STATUS?rev=1236531&r1=1236530&r2=1236531&view=diff
> ==============================================================================
> --- trafficserver/traffic/branches/3.0.x/STATUS (original)
> +++ trafficserver/traffic/branches/3.0.x/STATUS Fri Jan 27 05:18:48
> 2012
> @@ -84,6 +84,22 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK:
>     Jira: https://issues.apache.org/jira/browse/TS-1049
>     +1: zwoop
>  
> +  *) PluginVC should schedule to the local queue instead of the
> external queue.
> +   Trunk patch:
> http://svn.apache.org/viewvc?view=revision&revision=1228526
> +   Jira: https://issues.apache.org/jira/browse/TS-1074
> +   +1: briang
> +
> +  *) Transformation plugins cause connection close when content
> length is not known ahead
> +   Trunk patch:
> http://svn.apache.org/viewvc?view=revision&revision=1197133
> +   Jira: https://issues.apache.org/jira/browse/TS-1004
> +   +1: briang
> +
> +  *) HTTP: forward map based on request receive port.
> +   Trunk patch:
> http://svn.apache.org/viewvc?view=revision&revision=1159440
> +
>                http://svn.apache.org/viewvc?view=revision&revision=1159655

This one changes frequent_accept from a default of true to false which
is one of the things that gave amc so much headache over TS-1077, so I'm
a little ambivalent. 

> +   Jira: https://issues.apache.org/jira/browse/TS-876
> +   +1: briang
> +
>  
>  RELEASE PROCESS
>  
> 
> 
> 

-- 
Igor Galić

Tel: +43 (0) 664 886 22 883
Mail: i.galic@brainsware.org
URL: http://brainsware.org/
GPG: 6880 4155 74BD FD7C B515  2EA5 4B1D 9E08 A097 C9AE