[jira] [Commented] (AMBARI-16093) LogSearch Integration creates too many error logs during connection failures

["Hudson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMBARI-16093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15257131#comment-15257131 ] 

Hudson commented on AMBARI-16093:
---------------------------------

FAILURE: Integrated in Ambari-trunk-Commit #4733 (See [https://builds.apache.org/job/Ambari-trunk-Commit/4733/])
AMBARI-16093. LogSearch Integration creates too many error logs during (rnettleton: [http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=e1e51217e801696640ea5fa25b3d4e7fb61be412])
* ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperImpl.java
* ambari-server/src/main/java/org/apache/ambari/server/controller/logging/Utils.java
* ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingSearchPropertyProvider.java
* ambari-server/src/test/java/org/apache/ambari/server/controller/logging/UtilsTest.java


> LogSearch Integration creates too many error logs during connection failures
> ----------------------------------------------------------------------------
>
>                 Key: AMBARI-16093
>                 URL: https://issues.apache.org/jira/browse/AMBARI-16093
>             Project: Ambari
>          Issue Type: Bug
>          Components: ambari-server
>    Affects Versions: 2.4.0
>            Reporter: Robert Nettleton
>            Assignee: Robert Nettleton
>             Fix For: 2.4.0
>
>         Attachments: AMBARI-16093.patch
>
>
> The Ambari LogSearch integration layer is currently creating too many repeated error log messages in ambari-server.log when a connection attempt fails.
> Hundreds of instances of the following log message:
> {code}
> 2016-04-20 14:57:13,000 ERROR qtp-ambari-client-324 LoggingSearchPropertyProvider - Error occurred while making request to LogSearch service, unable to populate logging properties on this resource 
> {code}
> appear when a connection attempt to the LogSearch service fails.
> This problem can occur when:
> 1. The LogSearch service crashes or is unexpectedly brought down
> 2. There is a lag time during which a crashed service is still considered to be in the STARTED state, which is the state checked by the LoggingSearchPropertyProvider to determine if a connection should be attempted.  
> 3. This causes the LogSearch integration code to log many connection attempt failures un-necessarily, since only one instance of this message is necessary. 
> The LogSearch integration code should use a static counter to determine how many times a given error log should appear.  
> I'm working on a fix for this, and will submit a patch shortly. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)