You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "pvary (via GitHub)" <gi...@apache.org> on 2023/05/18 13:12:20 UTC

[GitHub] [iceberg] pvary opened a new pull request, #7643: Core: Make all of the BaseFile stat maps immutable

pvary opened a new pull request, #7643:
URL: https://github.com/apache/iceberg/pull/7643

   The BaseFile statistics maps are inconsistent.
   
   Modifiable:
   - lowerBounds
   - upperBounds
   
   Non-modifiable:
   - columnSizes
   - valueCounts
   - nullValueCounts
   - nanValueCounts
   
   I think this is an oversight in #2343 when we wanted to make sure that it is possible to Serialize/Deserialize the stats, but accidentally made some of them modifiable at the same time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] pvary merged pull request #7643: Core: Make all of the BaseFile stat maps immutable

Posted by "pvary (via GitHub)" <gi...@apache.org>.
pvary merged PR #7643:
URL: https://github.com/apache/iceberg/pull/7643


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] pvary commented on pull request #7643: Core: Make all of the BaseFile stat maps immutable

Posted by "pvary (via GitHub)" <gi...@apache.org>.
pvary commented on PR #7643:
URL: https://github.com/apache/iceberg/pull/7643#issuecomment-1564091023

   Thanks @stevenzwu for the review!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org