You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2023/02/11 22:47:39 UTC
[GitHub] [incubator-pekko-persistence-dynamodb] pjfanning opened a new pull request, #19: test with newer akka
pjfanning opened a new pull request, #19:
URL: https://github.com/apache/incubator-pekko-persistence-dynamodb/pull/19
this is an experiment - the main branch uses akka 2.5 and pekko is based on akka 2.6
It's possible that upgrading to akka 2.6 breaks some tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-dynamodb] pjfanning commented on pull request #19: test with newer akka
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #19:
URL: https://github.com/apache/incubator-pekko-persistence-dynamodb/pull/19#issuecomment-1431547980
Thanks @Thejipppp - your change gets that test to pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-dynamodb] pjfanning commented on pull request #19: test with newer akka
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #19:
URL: https://github.com/apache/incubator-pekko-persistence-dynamodb/pull/19#issuecomment-1431087036
@spangaer would you be able to take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-dynamodb] pjfanning commented on pull request #19: test with newer akka
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #19:
URL: https://github.com/apache/incubator-pekko-persistence-dynamodb/pull/19#issuecomment-1426895193
@spangaer would you be able to review this at some stage?
* I started https://github.com/apache/incubator-pekko-persistence-dynamodb/pull/17 and discovered some tests were broken
* this repo currently uses akka 2.5 in its build/tests - pekko is based on akka 2.6
* it appears from this experimental PR that the upgrade to akka 2.6 is the main cause of the test failures
* akka 2.6 testkit relies on a newer version of scalatest/scalactic and I had to modify 1 test to get it to compile and pass
* I had to enable java serialization in akka for 3 tests (akka 2.6 must have disabled this feature for security reasons)
* there is CurrentPersistenceIdsSpec which is still broken - it stackoverflows
If you could have a look that would be great. Any pointers on how to fix CurrentPersistenceIdsSpec would be appreciated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-dynamodb] pjfanning commented on pull request #19: test with newer akka
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #19:
URL: https://github.com/apache/incubator-pekko-persistence-dynamodb/pull/19#issuecomment-1437294637
@mdedetrich would you have to review this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-dynamodb] pjfanning merged pull request #19: test with newer akka
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #19:
URL: https://github.com/apache/incubator-pekko-persistence-dynamodb/pull/19
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-dynamodb] Thejipppp commented on pull request #19: test with newer akka
Posted by "Thejipppp (via GitHub)" <gi...@apache.org>.
Thejipppp commented on PR #19:
URL: https://github.com/apache/incubator-pekko-persistence-dynamodb/pull/19#issuecomment-1431472806
Hi (I'm the person @spangaer poked)
As per the documentation, https://doc.akka.io/docs/akka/current/stream/operators/Source-or-Flow/concatLazy.html,
`To defer the materialization of the given source (or to completely avoid its materialization if the original upstream fails or cancels), wrap it into [Source.lazySource](https://doc.akka.io/docs/akka/current/stream/operators/Source/lazySource.html).`,
it's good practice to wrap the innersource of the concatLazy in a lazySource.
I tried it out by replacing line 102 of akka.persistence.dynamodb.query.scaladsl.internal.DynamoDBCurrentPersistenceIdsQuery.scala
`currentResult.concatLazy(lazyStream(nextResult))`
by
`currentResult.concatLazy(
Source.lazySource{ () =>
lazyStream(nextResult)
}
)`
And the test turned green :)
Inspiration taken from https://stackoverflow.com/questions/50269332/akka-streams-concatenating-streams-that-initialise-resources
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-dynamodb] spangaer commented on pull request #19: test with newer akka
Posted by "spangaer (via GitHub)" <gi...@apache.org>.
spangaer commented on PR #19:
URL: https://github.com/apache/incubator-pekko-persistence-dynamodb/pull/19#issuecomment-1431284249
Good that you poked, I missed the first one.
I'll either look myself or poke someone else (a holiday is closing in on me, so it might take a day or 10 for it to progress).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org