You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/07/06 18:02:11 UTC
[GitHub] [lucene] dsmiley opened a new pull request #206: LUCENE-10003 No C style array declaration
dsmiley opened a new pull request #206:
URL: https://github.com/apache/lucene/pull/206
https://issues.apache.org/jira/browse/LUCENE-10003
The first commit was purely automated by IntelliJ.
The second commit are my hand edits to other spots IntellIJ didn't find because it was in a comment or some other file like a .jflex. These hand edits were found via
```
^(?!\s*(\/\/|\/?\*).*).*\b((?!instanceof)\w+)\s+\w+(\[])+\s*[=,;)]
```
Expect a separate PR to add checks to prevent this syntax via tooling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] rmuir commented on pull request #206: LUCENE-10003 No C style array declaration
Posted by GitBox <gi...@apache.org>.
rmuir commented on pull request #206:
URL: https://github.com/apache/lucene/pull/206#issuecomment-874976665
Why are we not doing this with spotless? As mentioned on the JIRA, I'm really -1 on the approach of enforcing *formatting* with anything but spotless. Sorry, it will just be annoying. The purpose of spotless is to avoid troubles like these.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] dsmiley merged pull request #206: LUCENE-10003 No C style array declaration
Posted by GitBox <gi...@apache.org>.
dsmiley merged pull request #206:
URL: https://github.com/apache/lucene/pull/206
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] dsmiley commented on pull request #206: LUCENE-10003 No C style array declaration
Posted by GitBox <gi...@apache.org>.
dsmiley commented on pull request #206:
URL: https://github.com/apache/lucene/pull/206#issuecomment-904273346
I think this PR is ready; I've made the changes. WDYT @dweiss @rmuir ? Remember this is just the rote changes, mostly done via IntelliJ's inspection automation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] dsmiley commented on pull request #206: LUCENE-10003 No C style array declaration
Posted by GitBox <gi...@apache.org>.
dsmiley commented on pull request #206:
URL: https://github.com/apache/lucene/pull/206#issuecomment-875011653
This PR isn't about automatic enforcement so I think your veto is intended at the conversation in the JIRA issue about how to enforce.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org