You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Kenneth Giusti <kg...@apache.org> on 2015/03/04 23:11:05 UTC
Review Request 31746: DISPATCH-98: Allow per-message values for
message annotations
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31746/
-----------------------------------------------------------
Review request for qpid, Alan Conway, Ernie Allen, michael goulish, and Ted Ross.
Bugs: DISPATCH-98
https://issues.apache.org/jira/browse/DISPATCH-98
Repository: qpid-dispatch
Description
-------
Allow the independent setting of each supported message annotation.
First, the message annotation map of a received message is walked, and the known annotations (trace, to-override, ingress) are identified.
During that processing, updated values for these fields may be created. Each updated value is encoded into its own buffer chain. Each buffer chain is stored individually in the per-reference (private) part of the message structure.
If the message is copied, any message annotation buffers are cloned. The annotations can be overridden without affecting the annotations in the source message.
When the message is to be sent, the buffer chains containing the new annotations are 'spliced' into the outgoing message.
Diffs
-----
trunk/include/qpid/dispatch/buffer.h 1664131
trunk/include/qpid/dispatch/compose.h 1664131
trunk/include/qpid/dispatch/ctools.h 1664131
trunk/include/qpid/dispatch/message.h 1664131
trunk/src/buffer.c 1664131
trunk/src/compose.c 1664131
trunk/src/message.c 1664131
trunk/src/message_private.h 1664131
trunk/src/router_node.c 1664131
trunk/tests/CMakeLists.txt 1664131
trunk/tests/buffer_test.c PRE-CREATION
trunk/tests/compose_test.c 1664131
trunk/tests/message_test.c 1664131
trunk/tests/run_unit_tests_size.c 1664131
Diff: https://reviews.apache.org/r/31746/diff/
Testing
-------
New unit tests for the new methods introduced by this patch.
Thanks,
Kenneth Giusti
Re: Review Request 31746: DISPATCH-98: Allow per-message values for
message annotations
Posted by Alan Conway <ac...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31746/#review75349
-----------------------------------------------------------
trunk/src/compose.c
<https://reviews.apache.org/r/31746/#comment122331>
I think the inline declaration is non-portable, see:
http://stackoverflow.com/questions/6312597/is-inline-without-static-or-extern-ever-useful-in-c99
Do you intend it to be used outside this file? If not, remove it from .h and make it "static inline" in .c.
If you do, move the definition to .h (with inline) and put an "extern inline" declaration in this file.
- Alan Conway
On March 4, 2015, 10:11 p.m., Kenneth Giusti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31746/
> -----------------------------------------------------------
>
> (Updated March 4, 2015, 10:11 p.m.)
>
>
> Review request for qpid, Alan Conway, Ernie Allen, michael goulish, and Ted Ross.
>
>
> Bugs: DISPATCH-98
> https://issues.apache.org/jira/browse/DISPATCH-98
>
>
> Repository: qpid-dispatch
>
>
> Description
> -------
>
> Allow the independent setting of each supported message annotation.
>
> First, the message annotation map of a received message is walked, and the known annotations (trace, to-override, ingress) are identified.
>
> During that processing, updated values for these fields may be created. Each updated value is encoded into its own buffer chain. Each buffer chain is stored individually in the per-reference (private) part of the message structure.
>
> If the message is copied, any message annotation buffers are cloned. The annotations can be overridden without affecting the annotations in the source message.
>
> When the message is to be sent, the buffer chains containing the new annotations are 'spliced' into the outgoing message.
>
>
> Diffs
> -----
>
> trunk/include/qpid/dispatch/buffer.h 1664131
> trunk/include/qpid/dispatch/compose.h 1664131
> trunk/include/qpid/dispatch/ctools.h 1664131
> trunk/include/qpid/dispatch/message.h 1664131
> trunk/src/buffer.c 1664131
> trunk/src/compose.c 1664131
> trunk/src/message.c 1664131
> trunk/src/message_private.h 1664131
> trunk/src/router_node.c 1664131
> trunk/tests/CMakeLists.txt 1664131
> trunk/tests/buffer_test.c PRE-CREATION
> trunk/tests/compose_test.c 1664131
> trunk/tests/message_test.c 1664131
> trunk/tests/run_unit_tests_size.c 1664131
>
> Diff: https://reviews.apache.org/r/31746/diff/
>
>
> Testing
> -------
>
> New unit tests for the new methods introduced by this patch.
>
>
> Thanks,
>
> Kenneth Giusti
>
>
Re: Review Request 31746: DISPATCH-98: Allow per-message values for
message annotations
Posted by Ted Ross <tr...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31746/#review76275
-----------------------------------------------------------
Ship it!
Ship It!
- Ted Ross
On March 10, 2015, 9:01 a.m., Kenneth Giusti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31746/
> -----------------------------------------------------------
>
> (Updated March 10, 2015, 9:01 a.m.)
>
>
> Review request for qpid, Alan Conway, Ernie Allen, michael goulish, and Ted Ross.
>
>
> Bugs: DISPATCH-98
> https://issues.apache.org/jira/browse/DISPATCH-98
>
>
> Repository: qpid-dispatch
>
>
> Description
> -------
>
> Allow the independent setting of each supported message annotation.
>
> First, the message annotation map of a received message is walked, and the known annotations (trace, to-override, ingress) are identified.
>
> During that processing, updated values for these fields may be created. Each updated value is encoded into its own buffer chain. Each buffer chain is stored individually in the per-reference (private) part of the message structure.
>
> If the message is copied, any message annotation buffers are cloned. The annotations can be overridden without affecting the annotations in the source message.
>
> When the message is to be sent, the buffer chains containing the new annotations are 'spliced' into the outgoing message.
>
>
> Diffs
> -----
>
> trunk/include/qpid/dispatch/buffer.h 1665514
> trunk/include/qpid/dispatch/compose.h 1665514
> trunk/include/qpid/dispatch/ctools.h 1665514
> trunk/include/qpid/dispatch/message.h 1665514
> trunk/src/buffer.c 1665514
> trunk/src/compose.c 1665514
> trunk/src/message.c 1665514
> trunk/src/message_private.h 1665514
> trunk/src/router_node.c 1665514
> trunk/tests/CMakeLists.txt 1665514
> trunk/tests/buffer_test.c PRE-CREATION
> trunk/tests/compose_test.c 1665514
> trunk/tests/message_test.c 1665514
> trunk/tests/run_unit_tests_size.c 1665514
>
> Diff: https://reviews.apache.org/r/31746/diff/
>
>
> Testing
> -------
>
> New unit tests for the new methods introduced by this patch.
>
>
> Thanks,
>
> Kenneth Giusti
>
>
Re: Review Request 31746: DISPATCH-98: Allow per-message values for
message annotations
Posted by Kenneth Giusti <kg...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31746/
-----------------------------------------------------------
(Updated March 10, 2015, 1:01 p.m.)
Review request for qpid, Alan Conway, Ernie Allen, michael goulish, and Ted Ross.
Bugs: DISPATCH-98
https://issues.apache.org/jira/browse/DISPATCH-98
Repository: qpid-dispatch
Description
-------
Allow the independent setting of each supported message annotation.
First, the message annotation map of a received message is walked, and the known annotations (trace, to-override, ingress) are identified.
During that processing, updated values for these fields may be created. Each updated value is encoded into its own buffer chain. Each buffer chain is stored individually in the per-reference (private) part of the message structure.
If the message is copied, any message annotation buffers are cloned. The annotations can be overridden without affecting the annotations in the source message.
When the message is to be sent, the buffer chains containing the new annotations are 'spliced' into the outgoing message.
Diffs (updated)
-----
trunk/include/qpid/dispatch/buffer.h 1665514
trunk/include/qpid/dispatch/compose.h 1665514
trunk/include/qpid/dispatch/ctools.h 1665514
trunk/include/qpid/dispatch/message.h 1665514
trunk/src/buffer.c 1665514
trunk/src/compose.c 1665514
trunk/src/message.c 1665514
trunk/src/message_private.h 1665514
trunk/src/router_node.c 1665514
trunk/tests/CMakeLists.txt 1665514
trunk/tests/buffer_test.c PRE-CREATION
trunk/tests/compose_test.c 1665514
trunk/tests/message_test.c 1665514
trunk/tests/run_unit_tests_size.c 1665514
Diff: https://reviews.apache.org/r/31746/diff/
Testing
-------
New unit tests for the new methods introduced by this patch.
Thanks,
Kenneth Giusti
Re: Review Request 31746: DISPATCH-98: Allow per-message values for
message annotations
Posted by Alan Conway <ac...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31746/#review75401
-----------------------------------------------------------
Ship it!
Ship It!
- Alan Conway
On March 5, 2015, 9:08 p.m., Kenneth Giusti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31746/
> -----------------------------------------------------------
>
> (Updated March 5, 2015, 9:08 p.m.)
>
>
> Review request for qpid, Alan Conway, Ernie Allen, michael goulish, and Ted Ross.
>
>
> Bugs: DISPATCH-98
> https://issues.apache.org/jira/browse/DISPATCH-98
>
>
> Repository: qpid-dispatch
>
>
> Description
> -------
>
> Allow the independent setting of each supported message annotation.
>
> First, the message annotation map of a received message is walked, and the known annotations (trace, to-override, ingress) are identified.
>
> During that processing, updated values for these fields may be created. Each updated value is encoded into its own buffer chain. Each buffer chain is stored individually in the per-reference (private) part of the message structure.
>
> If the message is copied, any message annotation buffers are cloned. The annotations can be overridden without affecting the annotations in the source message.
>
> When the message is to be sent, the buffer chains containing the new annotations are 'spliced' into the outgoing message.
>
>
> Diffs
> -----
>
> trunk/include/qpid/dispatch/buffer.h 1664131
> trunk/include/qpid/dispatch/compose.h 1664131
> trunk/include/qpid/dispatch/ctools.h 1664131
> trunk/include/qpid/dispatch/message.h 1664131
> trunk/src/buffer.c 1664131
> trunk/src/compose.c 1664131
> trunk/src/message.c 1664131
> trunk/src/message_private.h 1664131
> trunk/src/router_node.c 1664131
> trunk/tests/CMakeLists.txt 1664131
> trunk/tests/buffer_test.c PRE-CREATION
> trunk/tests/compose_test.c 1664131
> trunk/tests/message_test.c 1664131
> trunk/tests/run_unit_tests_size.c 1664131
>
> Diff: https://reviews.apache.org/r/31746/diff/
>
>
> Testing
> -------
>
> New unit tests for the new methods introduced by this patch.
>
>
> Thanks,
>
> Kenneth Giusti
>
>
Re: Review Request 31746: DISPATCH-98: Allow per-message values for
message annotations
Posted by Kenneth Giusti <kg...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31746/
-----------------------------------------------------------
(Updated March 5, 2015, 9:08 p.m.)
Review request for qpid, Alan Conway, Ernie Allen, michael goulish, and Ted Ross.
Bugs: DISPATCH-98
https://issues.apache.org/jira/browse/DISPATCH-98
Repository: qpid-dispatch
Description
-------
Allow the independent setting of each supported message annotation.
First, the message annotation map of a received message is walked, and the known annotations (trace, to-override, ingress) are identified.
During that processing, updated values for these fields may be created. Each updated value is encoded into its own buffer chain. Each buffer chain is stored individually in the per-reference (private) part of the message structure.
If the message is copied, any message annotation buffers are cloned. The annotations can be overridden without affecting the annotations in the source message.
When the message is to be sent, the buffer chains containing the new annotations are 'spliced' into the outgoing message.
Diffs (updated)
-----
trunk/include/qpid/dispatch/buffer.h 1664131
trunk/include/qpid/dispatch/compose.h 1664131
trunk/include/qpid/dispatch/ctools.h 1664131
trunk/include/qpid/dispatch/message.h 1664131
trunk/src/buffer.c 1664131
trunk/src/compose.c 1664131
trunk/src/message.c 1664131
trunk/src/message_private.h 1664131
trunk/src/router_node.c 1664131
trunk/tests/CMakeLists.txt 1664131
trunk/tests/buffer_test.c PRE-CREATION
trunk/tests/compose_test.c 1664131
trunk/tests/message_test.c 1664131
trunk/tests/run_unit_tests_size.c 1664131
Diff: https://reviews.apache.org/r/31746/diff/
Testing
-------
New unit tests for the new methods introduced by this patch.
Thanks,
Kenneth Giusti