[GitHub] [maven-scm] slawekjaranowski commented on a diff in pull request #142: [SCM-979] ScmLogger nonsense dropped

[GitBox <gi...@apache.org>]

slawekjaranowski commented on code in PR #142:
URL: https://github.com/apache/maven-scm/pull/142#discussion_r878243579


##########
maven-scm-api/src/main/java/org/apache/maven/scm/command/AbstractCommand.java:
##########
@@ -35,7 +35,7 @@
 public abstract class AbstractCommand
     implements Command
 {
-    private ScmLogger logger = new Slf4jScmLogger( getClass() );
+    protected Logger logger = LoggerFactory.getLogger( getClass() );

Review Comment:
   better is private and to have separate logger for each class, in this way logger name will be inconsistent with usage.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org