You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/02/16 10:11:20 UTC
[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #3455: NO-JIRA Avoid creation of unnecessary StringBuilder instance in Netty…
franz1981 commented on a change in pull request #3455:
URL: https://github.com/apache/activemq-artemis/pull/3455#discussion_r576702323
##########
File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyAcceptor.java
##########
@@ -863,17 +863,19 @@ public NettyAcceptor setShutdownTimeout(int shutdownTimeout) {
}
private static String getProtocols(Map<String, ProtocolManager> protocolManager) {
- StringBuilder sb = new StringBuilder();
- if (protocolManager != null) {
+ if (protocolManager == null) {
Review comment:
how many times this is supposed to happen?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org