You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2015/05/21 02:42:47 UTC

Re: Review Request 34306: Added capabilities field to FrameworkInfo.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34306/
-----------------------------------------------------------

(Updated May 21, 2015, 12:42 a.m.)


Review request for mesos, Jie Yu and Niklas Nielsen.


Changes
-------

updated summary and description.


Summary (updated)
-----------------

Added capabilities field to FrameworkInfo.


Bugs: MESOS-2654
    https://issues.apache.org/jira/browse/MESOS-2654


Repository: mesos


Description (updated)
-------

Capability message was added to make this extensible in future. For example, receiving optimistic offers might be another capability.


Diffs
-----

  include/mesos/mesos.proto 9cc5782256156ed59fd4640091413b76480d939f 

Diff: https://reviews.apache.org/r/34306/diff/


Testing
-------

make check


Thanks,

Vinod Kone

Re: Review Request 34306: Added capabilities field to FrameworkInfo.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34306/#review84650
-----------------------------------------------------------


Patch looks great!

Reviews applied: [34304, 34306]

All tests passed.

- Mesos ReviewBot


On May 21, 2015, 12:42 a.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34306/
> -----------------------------------------------------------
> 
> (Updated May 21, 2015, 12:42 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Niklas Nielsen.
> 
> 
> Bugs: MESOS-2654
>     https://issues.apache.org/jira/browse/MESOS-2654
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Capability message was added to make this extensible in future. For example, receiving optimistic offers might be another capability.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 9cc5782256156ed59fd4640091413b76480d939f 
> 
> Diff: https://reviews.apache.org/r/34306/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 34306: Added capabilities field to FrameworkInfo.

Posted by Ben Mahler <be...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34306/#review86327
-----------------------------------------------------------


Could we print the framework's capabilities when it registers with the master? Would help debugging, as I was just tripped up by forgetting to set it.

Also, might be easy to fold in to printing the 'checkpoint' capability (maybe also at some point folding it in to the Capabilities enum).

- Ben Mahler


On May 21, 2015, 12:42 a.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34306/
> -----------------------------------------------------------
> 
> (Updated May 21, 2015, 12:42 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Niklas Nielsen.
> 
> 
> Bugs: MESOS-2654
>     https://issues.apache.org/jira/browse/MESOS-2654
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Capability message was added to make this extensible in future. For example, receiving optimistic offers might be another capability.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 9cc5782256156ed59fd4640091413b76480d939f 
> 
> Diff: https://reviews.apache.org/r/34306/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 34306: Added capabilities field to FrameworkInfo.

Posted by Niklas Nielsen <ni...@qni.dk>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34306/#review84743
-----------------------------------------------------------

Ship it!


Ship It!

- Niklas Nielsen


On May 20, 2015, 5:42 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34306/
> -----------------------------------------------------------
> 
> (Updated May 20, 2015, 5:42 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Niklas Nielsen.
> 
> 
> Bugs: MESOS-2654
>     https://issues.apache.org/jira/browse/MESOS-2654
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Capability message was added to make this extensible in future. For example, receiving optimistic offers might be another capability.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 9cc5782256156ed59fd4640091413b76480d939f 
> 
> Diff: https://reviews.apache.org/r/34306/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 34306: Added capabilities field to FrameworkInfo.

Posted by Jie Yu <yu...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34306/#review84785
-----------------------------------------------------------

Ship it!


Ship It!

- Jie Yu


On May 21, 2015, 12:42 a.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34306/
> -----------------------------------------------------------
> 
> (Updated May 21, 2015, 12:42 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Niklas Nielsen.
> 
> 
> Bugs: MESOS-2654
>     https://issues.apache.org/jira/browse/MESOS-2654
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Capability message was added to make this extensible in future. For example, receiving optimistic offers might be another capability.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 9cc5782256156ed59fd4640091413b76480d939f 
> 
> Diff: https://reviews.apache.org/r/34306/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>